Move all templating-related helpers from run_steps.go into separate file #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
approved these changes
Jan 11, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
…ile (#421) * Move templating helpers to own file * Move another helper over * Introduce tiny helper * Move code around * Use renderTemplate helper * Move tests too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've wanted to get an overview of all the things that relate to templating and thought it would be better if all of that goes into its own file.
I also added a tiny new helper so that the interaction between
runStepsand templating might be a bit clearer.