Correctly abort on interrupt instead of going into endless loop #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `:GoMetaLinter` just pointed me to this "ineffective break statement" that I introduced in #328 with the following comment: > It also makes sure that we don't enqueue more tasks/steps after being > canceled: that's the code in `(*executor).Start()` that aborts the > `Range` call if the context has been cancelled/timed-out and aborts > execution of a task if the goroutine already blocked on > `x.par.Acquire()`. Well... turns out that wasn't the case, was it? Instead the code only broke out of the `select` and continued trying to acquire a lock. I also suspect that this bug might have something to do with a customer reporting that long-running containers are not stopped when hitting Ctrl-C (https://github.com/sourcegraph/sourcegraph/issues/16026) even after we thought the issue was fixed with #328. I'm not 100% sure on this one though.
eseliger
approved these changes
Jan 21, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Running `:GoMetaLinter` just pointed me to this "ineffective break statement" that I introduced in #328 with the following comment: > It also makes sure that we don't enqueue more tasks/steps after being > canceled: that's the code in `(*executor).Start()` that aborts the > `Range` call if the context has been cancelled/timed-out and aborts > execution of a task if the goroutine already blocked on > `x.par.Acquire()`. Well... turns out that wasn't the case, was it? Instead the code only broke out of the `select` and continued trying to acquire a lock. I also suspect that this bug might have something to do with a customer reporting that long-running containers are not stopped when hitting Ctrl-C (https://github.com/sourcegraph/sourcegraph/issues/16026) even after we thought the issue was fixed with #328. I'm not 100% sure on this one though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
:GoMetaLinterjust pointed me to this "ineffective breakstatement" that I introduced in #328 with the following comment:
Well... turns out that wasn't the case, was it?
Instead the code only broke out of the
selectand continued trying toacquire a lock.
I also suspect that this bug might have something to do with a customer
reporting that long-running containers are not stopped when hitting
Ctrl-C (https://github.com/sourcegraph/sourcegraph/issues/16026) even
after we thought the issue was fixed with #328. I'm not 100% sure on
this one though.