Keep repo archives cached for later executed tasks #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to fix the issue discovered by @eseliger here: #442 (comment) Short version: the previous implementation would only avoid deleting an archive if there were *currently active tasks* holding references to it. If tasks that need the same archive would execute sequentially, though, the archive would be downloaded, deleted, downloaded again. This here is a fix for the issue by first marking all repository archives for later use and only once all marks have been turned into references and those references have been closed is the archive deleted.
This was referenced Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to fix the issue discovered by @eseliger here: #442 (comment)
Short version: the previous implementation would only avoid deleting an
archive if there were currently active tasks holding references to it.
If tasks that need the same archive would execute sequentially, though,
the archive would be downloaded, deleted, downloaded again.
This here is a fix for the issue by first marking all repository
archives for later use and only once all marks have been turned into
references and those references have been closed is the archive deleted.