Link to troubleshooting docs when src campaign apply|preview fails #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes https://github.com/sourcegraph/sourcegraph/issues/17259, but contrary to what I stated in the original ticket, I think it makes more sense to always link to these docs. Why? 1. It's two lines. It doesn't hurt. 2. It's really tricky to find out exactly when to link to the docs and when not. Especially since running the steps could result in an error that could be fixed through the troubleshooting guide (example: broken docker setup).
eseliger
approved these changes
Feb 1, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
) This fixes https://github.com/sourcegraph/sourcegraph/issues/17259, but contrary to what I stated in the original ticket, I think it makes more sense to always link to these docs. Why? 1. It's two lines. It doesn't hurt. 2. It's really tricky to find out exactly when to link to the docs and when not. Especially since running the steps could result in an error that could be fixed through the troubleshooting guide (example: broken docker setup).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/sourcegraph/sourcegraph/issues/17259, but
contrary to what I stated in the original ticket, I think it makes more
sense to always link to these docs.
Why?
when not. Especially since running the steps could result in an error
that could be fixed through the troubleshooting guide (example:
broken docker setup).
Screenshots