s/campaign/batch change/ #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
eseliger
approved these changes
Mar 9, 2021
mrnugget
approved these changes
Mar 9, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Rename command files. * cmd/src campaigns → batch * Minimal package renames. * schemata changes * non-GraphQL renames * Rename Docker image. * Migrate GraphQL. * update readme * Update canned errors in tests. * changelog * insert pr number here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fairly mechanical, although I actually did most of it by hand. The only bit that's really interesting is that I needed to abstract two GraphQL mutations to maintain cross-version compatibility: I did so by introducing a new
Operationsinterface ininternal/batchers/graphqlthat delegates to an appropriate implementation based on our existing "feature flag" quirk detection, and takes that level of detail out ofinternal/batchers/Service.We're also renaming the volume workspace Docker image: this is fine, since previous tagged versions will continue to just work. The release automation will be mildly spicy when we do the next
srcrelease, as there's only so much one can bench test without actually invoking GitHub Actions; it may be worth cutting a release as soon as we have the documentation up to date while this is (relatively) fresh in my mind, even though it will lift the veil on the great renaming slightly early. (Since everything is aliased, nothing should break in practice.)This is paired with https://github.com/sourcegraph/sourcegraph/pull/18963, which includes the schema changes required to make this work. Those schema changes are not breaking, but we should nevertheless keep both repos in sync for (I hope) obvious reasons.
Closes sourcegraph/sourcegraph#18940.