Extract code from batches package into smaller sub-packages #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed another commit that creates the |
eseliger
approved these changes
Apr 14, 2021
internal/batches/step_changes.go
Outdated
| @@ -0,0 +1 @@ | |||
| package batches | |||
There was a problem hiding this comment.
is this file required for anything?
LawnGnome
approved these changes
Apr 15, 2021
mrnugget
added a commit
that referenced
this pull request
Apr 22, 2021
This is a follow-up to #511 and #512. It cleans up the code that's shared between `batch apply` and `previe` by trying to make the boundaries between the "TUI + execution"-glue-code, the `service` pkg, the `executor` pkg and the helpers clearer. A lot of this is subjective, of course (what does "clearer" even mean, man), but I think less duplication is Good and less cross-talk between a trio of components too.
mrnugget
added a commit
that referenced
this pull request
Apr 22, 2021
This is a follow-up to #511 and #512. It cleans up the code that's shared between `batch apply` and `previe` by trying to make the boundaries between the "TUI + execution"-glue-code, the `service` pkg, the `executor` pkg and the helpers clearer. A lot of this is subjective, of course (what does "clearer" even mean, man), but I think less duplication is Good and less cross-talk between a trio of components too.
mrnugget
added a commit
that referenced
this pull request
Apr 23, 2021
* Clean up shared code between `batch apply` and `preview` This is a follow-up to #511 and #512. It cleans up the code that's shared between `batch apply` and `previe` by trying to make the boundaries between the "TUI + execution"-glue-code, the `service` pkg, the `executor` pkg and the helpers clearer. A lot of this is subjective, of course (what does "clearer" even mean, man), but I think less duplication is Good and less cross-talk between a trio of components too. * Remove commented out code * Fix comment
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Create executor, git, service packages * Rename Opts in executor * Rename ServiceOpts * Move LogManager to log package * workspace pkg, unexport types and rename WorkspaceCreator to Creator * Remove unused file
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Clean up shared code between `batch apply` and `preview` This is a follow-up to #511 and #512. It cleans up the code that's shared between `batch apply` and `previe` by trying to make the boundaries between the "TUI + execution"-glue-code, the `service` pkg, the `executor` pkg and the helpers clearer. A lot of this is subjective, of course (what does "clearer" even mean, man), but I think less duplication is Good and less cross-talk between a trio of components too. * Remove commented out code * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards cleaning up this code base a bit.
It extracts code into smaller sub-packages:
executormockgitlogserviceworkspaceAnd it renames some of the types so they make more sense in this new structure:
batches.ExecutorOptstoexecutor.Optsfor example.This doesn't magically fix problems, but it makes it easier to see where dependencies and strong coupling exists.
And it's only the first step: there's still a few TODOs that I added. Next I want to clear up the interplay between
serviceandexecutorand themainpackage.I opened this PR to make reviewing easier: it doesn't change behaviour but only renames and moves things