Skip to content

codeintel: Update codeintel/upload package #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2021
Merged

codeintel: Update codeintel/upload package #541

merged 3 commits into from
May 24, 2021

Conversation

@efritz
Copy link
Contributor

@efritz efritz commented May 18, 2021 •
edited
Loading

This updates the codeintelutils package that handles the logic of uploading LSIF indexes to a Sourcegraph instance. This is a big overhaul that affects UX. Screenies below.

Pre-merge checklist:

@efritz efritz changed the title WIP. codeintel: Update codeintel/upload package May 18, 2021
@efritz efritz mentioned this pull request May 20, 2021
Merged
@efritz efritz self-assigned this May 20, 2021
@efritz efritz force-pushed the ef/update-lsif-upload-package branch from 44ed092 to f335e01 Compare May 20, 2021 18:49
@efritz efritz requested review from Strum355 and mrnugget May 20, 2021 19:09
@efritz efritz marked this pull request as ready for review May 20, 2021 19:09
Strum355
Strum355 approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@Strum355 Strum355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 🎉 for CI purposes, is this disableable?

@efritz
Copy link
Contributor Author

efritz commented May 20, 2021

@Strum355 Sure is. You can pass -json to get machine-readable output, -no-progress for no animation, and the lib/output library apparently detects TTY.

@efritz efritz requested a review from eseliger May 20, 2021 23:34
eseliger
eseliger approved these changes May 20, 2021
View reviewed changes
@efritz efritz merged commit 5df0445 into main May 24, 2021
@efritz efritz deleted the ef/update-lsif-upload-package branch May 24, 2021 21:56
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@efritz
codeintel: Update codeintel/upload package (#541)
d42603b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eseliger eseliger eseliger approved these changes

@mrnugget mrnugget Awaiting requested review from mrnugget

+1 more reviewer

@Strum355 Strum355 Strum355 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@efritz efritz

Labels

team/graph

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@efritz @Strum355 @eseliger