Make template package independent of src-cli internals #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eseliger
commented
Sep 1, 2021
eseliger
commented
- Get rid of dependency on graphql.Repository
- Move git package into sg/sg/lib
- Get rid of dependency on graphql.Repository - Move git package into sg/sg/lib
eseliger
force-pushed
the
es/independent-template-pkg
branch
from
e1ae294 to
58a66e3
Compare
mrnugget
approved these changes
Sep 1, 2021
| continue | ||
| } | ||
|
|
||
| stepCtx := &template.StepContext{ |
There was a problem hiding this comment.
Do you need a fresh template.StepContext in every iteration?
Comment on lines
+88
to
+100
| type TemplatingBranch struct { | ||
| Name string | ||
| TargetOID string | ||
| } | ||
|
|
||
| type TemplatingRepository struct { | ||
| ID string | ||
| Name string | ||
| DefaultBranch TemplatingBranch | ||
| FileMatches map[string]bool | ||
| } | ||
|
|
||
| func (r TemplatingRepository) SearchResultPaths() (list fileMatchPathList) { |
There was a problem hiding this comment.
Do we need the Templating in the name? template.TemplatingRepository is a bit redundant.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
- Get rid of dependency on graphql.Repository - Move git package into sg/sg/lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.