Start/Wait on exec.Cmd when using pipes #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might've been the cause for the flaky test we saw, because the docs say that `cmd.Run()` in combination with `StdoutPipe`/`StderrPipe` is wrong: > `Wait` will close the pipe after seeing the command exit, so most callers > need not close the pipe themselves. It is thus incorrect to call `Wait` > before all reads from the pipe have completed. For the same reason, it > is incorrect to call `Run` when using `StdoutPipe`. See the example for > idiomatic usage. See: https://pkg.go.dev/os/exec#example-Cmd.StdoutPipe
eseliger
approved these changes
Sep 6, 2021
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This might've been the cause for the flaky test we saw, because the docs say that `cmd.Run()` in combination with `StdoutPipe`/`StderrPipe` is wrong: > `Wait` will close the pipe after seeing the command exit, so most callers > need not close the pipe themselves. It is thus incorrect to call `Wait` > before all reads from the pipe have completed. For the same reason, it > is incorrect to call `Run` when using `StdoutPipe`. See the example for > idiomatic usage. See: https://pkg.go.dev/os/exec#example-Cmd.StdoutPipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might've been the cause for the flaky test we saw (example failure here).
The docs say that
cmd.Run()in combination withStdoutPipe/StderrPipeis wrong:See: https://pkg.go.dev/os/exec#example-Cmd.StdoutPipe