fix: reindex is not working due to incorrect ctx propagation#1066
Merged
keegancsmith merged 1 commit intoMay 28, 2026
Merged
Conversation
michaellzc
changed the title
valerybugakov
approved these changes
May 28, 2026
keegancsmith
approved these changes
May 28, 2026
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Funnily enough this is a race condition, so in some recent testing I did I didn't hit the race.
I was curious how we regressed here. Was due to this #933 which introduced ctx.
keegancsmith
deleted the
05-27-fix_reindex_is_not_working_due_to_incorrect_ctc_propagation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://app.plain.com/workspace/w_01K95VFHPKPY4ERZD73YRRR0RH/thread/th_01KQSHJ734488GMP83EP44GSJ2/
during reindex, the background operation is canceled alone with the completion of http request. need to start its own context. hence, user clicking "reindex" never really works.
tested locally and confirmed clicking "Reindex now" created a new index file on disk:
also validated the previous behaviour, the file stayed unchanged after clicking "Reindex now".