Add small test for v15 backwards compatibility#23
Merged
Conversation
keegancsmith
requested changes
Aug 21, 2019
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
These files are huge. Can we instead just index a very simple repo containing one file?
$ du -h test-index/
4.7M test-index/
Member
|
@kzh ping? |
Contributor
Author
|
Hey @keegancsmith, I updated the test to make use of a golden file for validation. Sorry, I got a little sidetracked with the performance testing on symbol search. |
keegancsmith
approved these changes
Aug 28, 2019
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
Two changes before landing:
- Can you include a way to update the golden file. Normally one adds a
-updateflag. EG see how we do it in the sourcegraph repo or the golang repo https://sourcegraph.com/search?q=r:%5Egithub.com/%28sourcegraph/sourcegraph%7Cgolang/go%29%24+flag%5C.%5BA-Z%5D+%28golden%7Cupdate%29+f:test.go - Marshal the golden files with indentation. Will make it easier to review changes to them.
keegancsmith
approved these changes
Aug 29, 2019
Change-Id: Id28f9477a400b7d5649bbc0e8a4d567813792fae
kzh
force-pushed
the
backwards-compat-test
branch
from
dc2d8c3 to
9fc94e0
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.