Simplify go-git optimization and reenable it#940
Merged
jtibshirani merged 1 commit intomainfrom Apr 11, 2025
Merged
Conversation
keegancsmith
approved these changes
Apr 11, 2025
janhartman
approved these changes
Apr 11, 2025
abraverm
pushed a commit
to abraverm/zoekt
that referenced
this pull request
Jan 15, 2026
This PR re-enables the go-git optimization that was disabled in sourcegraph#870 because it caused a huge bug. This PR removes the part of the optimization that was causing the bug, setting `LargeObjectThreshold`. An alternative would be to track down the root cause of the bug in go-git, so that we could keep setting `LargeObjectThreshold`. However, I don't feel that's worth it as: * The memory improvement from this change was pretty small (see sourcegraph#854) * Eventually we want to move away from go-git towards a "vanilla" direct git usage
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables the go-git optimization that was disabled in #870 because it caused a huge bug. This PR removes the part of the optimization that was causing the bug, setting
LargeObjectThreshold.An alternative would be to track down the root cause of the bug in go-git, so that we could keep setting
LargeObjectThreshold. However, I don't feel that's worth it as: