Skip to content

fix(skills/developing-a-feature): proceed with teardown when the repo has no CI#11

Merged
sourcehawk merged 1 commit into
mainfrom
fix/teardown-no-ci
May 30, 2026
Merged

fix(skills/developing-a-feature): proceed with teardown when the repo has no CI#11
sourcehawk merged 1 commit into
mainfrom
fix/teardown-no-ci

Conversation

@sourcehawk
Copy link
Copy Markdown
Owner

Description

The teardown step (developing-a-feature Step 7) gated deleting the plan/state
files on the integration PR's CI going green, but had no branch for repositories
that run no CI. An agent following it faithfully polls for checks that never
appear and stalls — the workflow hangs at the finish line. The text also gave no
way to distinguish "no CI exists" from "CI hasn't registered yet," so the agent
couldn't safely conclude either. This keys the gate on the repo's CI
configuration instead, so the workflow completes whether or not CI is present.

Changes

  • Step 7 now decides the teardown gate by inspecting the repo's CI configuration,
    not by polling gh pr checks run state (which can't tell absent from pending).
  • CI configured for the PR's branch → wait for green, unchanged.
  • No CI configured → the full local suite already pasted via
    verification-before-completion is the authority, so proceed; no polling.
  • Scoped the "local green isn't the gate" red flag to "when CI runs," and added a
    red flag against polling for checks that will never appear.

Testing

Developed through superpowers:writing-skills RED → GREEN → REFACTOR with
isolated subagents:

  • RED: an agent on the old text, given honest evidence (zero checks, CI
    status unknown), refused to count local green, fell back to arbitrary
    time-based polling, and stalled — reproducing the reported hang.
  • GREEN: the same no-CI scenario on the new text → agent settles CI from
    configuration and tears down immediately, no polling.
  • REFACTOR/regression: CI-configured-but-pending scenario on the new text →
    agent still waits for green and refuses premature teardown. No hole opened.

JSON in .claude-plugin/ unaffected; no provider- or product-specific strings
introduced (the skill says "inspect the repo's CI configuration").

🤖 Generated with Claude Code

… has no CI

Step 7 gated teardown of the plan/state files on the integration PR's CI
going green, with no branch for repos that run no CI. A faithful agent
then polls for checks that never appear and stalls. The text also gave no
way to tell "no CI exists" from "CI hasn't registered yet," so the agent
couldn't safely conclude either.

Key the gate on inspecting the repo's CI configuration instead of polling
run state: if a pipeline is wired to run on the PR's branch, wait for green
as before; if none is, the full local suite already pasted via
verification-before-completion is the authority, so proceed. Refine the
"local green isn't the gate" red flag to scope it to "when CI runs," and
add a red flag against polling for checks that will never appear.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 30, 2026 19:58
@sourcehawk sourcehawk merged commit c5c1790 into main May 30, 2026
1 check failed
@sourcehawk sourcehawk deleted the fix/teardown-no-ci branch May 30, 2026 19:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants