feat(skills/drafting-a-release): gate the release point on the user#18
Merged
Conversation
The skill silently cut releases from the default-branch tip: step 1 established the baseline from `<last-tag>..` (implicitly HEAD) and the target was never surfaced as a user decision. Baseline subagent testing confirmed agents either tagged HEAD without asking or inferred a target themselves from "WIP"-looking commits and folded it into the version question — never asking where the release should be cut. Add a first gate that asks, on every release, whether to cut from the branch tip or a specific commit. A specific commit may be given as a SHA, any resolvable ref, or a description of intent; the skill resolves it to one concrete commit and confirms short SHA + subject + date before using it. The resolved commit bounds the changelog range at `<last-tag>..<target>` and becomes `--target` at publish, keeping anything past the release point out of the notes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a user-prompted gate to
drafting-a-releasefor choosing what a releaseis cut from. The skill previously cut silently from the default-branch tip and
never surfaced the release point as a decision, so a release could pick up
unfinished commits sitting on top of the intended cut. This gate asks, on every
release, whether to cut from the branch tip or a specific commit.
Changes
vs. a specific commit, ahead of establishing the baseline.
of intent; the skill resolves it to one concrete commit and confirms short
SHA + subject + date before using it — even for a literal SHA.
<target>: the changelog/version range is boundedat
<last-tag>..<target>and it is passed as--targetat publish, keepinganything past the release point out of the notes.
gate now always surfaces the commit the tag lands on.
observed in baseline testing.
Testing
Developed through the
superpowers:writing-skillsRED→GREEN→REFACTOR loop withisolated subagents (skill inlined, not loaded from the repo). RED: with the
current skill, a clean scenario was cut silently from
mainand a "WIP on top"scenario had the agent infer the target itself without asking. GREEN: with the
new gate, the clean scenario's first question became "branch tip or a specific
commit?", and an intent-described point ("up to where the billing rework landed")
was resolved to the right commit, confirmed with SHA + subject + date, and used
as both the
<last-tag>..<target>range bound and--target. No newrationalizations surfaced in REFACTOR.
🤖 Generated with Claude Code