Fix/primitive grace status bug#99
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts grace-period health reporting for “alive” workload primitives (Deployment/ReplicaSet/StatefulSet/DaemonSet) so they can report GraceStatusHealthy when readiness meets the desired target, updates related unit/E2E tests, and adds “Further Reading” links plus expanded AI contribution instructions.
Changes:
- Update default grace status handlers for Deployment/ReplicaSet/StatefulSet/DaemonSet to treat “desired ready” as
GraceStatusHealthy. - Extend unit tests for the new healthy grace cases and adjust the DaemonSet E2E “Degraded after grace” scenario to use a custom grace handler.
- Add “Further Reading” references and expand Copilot/AI instruction docs.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a “Further Reading” link to a related blog post. |
| pkg/primitives/deployment/handlers.go | Changes Deployment grace health classification to include a Healthy branch when ready meets/exceeds desired. |
| pkg/primitives/deployment/handlers_test.go | Adds unit tests for newly introduced Healthy grace behavior. |
| pkg/primitives/replicaset/handlers.go | Changes ReplicaSet grace health classification to include a Healthy branch when ready meets/exceeds desired. |
| pkg/primitives/replicaset/handlers_test.go | Adds unit tests for newly introduced Healthy grace behavior. |
| pkg/primitives/statefulset/handlers.go | Changes StatefulSet grace health classification to include a Healthy branch when ready meets/exceeds desired. |
| pkg/primitives/statefulset/handlers_test.go | Adds unit tests for newly introduced Healthy grace behavior. |
| pkg/primitives/daemonset/handlers.go | Updates DaemonSet grace health classification to include a Healthy branch when all desired pods are ready. |
| pkg/primitives/daemonset/handlers_test.go | Adds a unit test for the “all ready => Healthy” grace behavior. |
| e2e/primitives/daemonset_test.go | Updates grace-period Degraded E2E test to use a custom grace handler now that the default grace handler can return Healthy. |
| docs/guidelines.md | Adds “Further Reading” link. |
| .github/copilot-instructions.md | Expands docs/package references and adds E2E testing guidance. |
| .ai/base.md | Mirrors the Copilot instruction updates for the AI base instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.