chore: source the feature-dev workflow skills from the feature-dev-workflow plugin#41
Merged
Conversation
…ow plugin The seven workflow skills (planning/developing/fanning-out/reviewing/ opening-a-pull-request/writing-github-issues/testing) now ship as the `feature-dev-workflow` plugin, enabled in .claude/settings.json. Remove the in-repo .claude/skills/ copies and repoint CLAUDE.md's workflow section at the plugin (skills referenced as feature-dev-workflow:<skill>). The two recent local fixes (push-state-before-merge, teardown-after-CI-green) are ported to the plugin in sourcehawk/feature-dev-workflow#1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Removing .claude/skills/ only works if the feature-dev-workflow plugin is enabled for every checkout. Check in .claude/settings.json (enabledPlugins: feature-dev-workflow + superpowers) and flip the .gitignore exception from the now-removed .claude/skills/ to .claude/settings.json. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Moves the repository’s feature-development workflow skills out of .claude/skills/ and into the external feature-dev-workflow plugin, updating contributor-facing documentation accordingly so the workflow is invoked via feature-dev-workflow:<skill>.
Changes:
- Update
CLAUDE.mdto reference the plugin-provided workflow skills and adjust the workflow diagram/wording. - Remove the in-repo copies of the 7 feature-development workflow skills and their templates.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| CLAUDE.md | Repoints workflow documentation/diagram from local skills to feature-dev-workflow:* plugin skills. |
| .claude/skills/writing-github-issues/templates/feature.md | Removes local issue template (now expected to come from plugin). |
| .claude/skills/writing-github-issues/templates/epic.md | Removes local issue template (now expected to come from plugin). |
| .claude/skills/writing-github-issues/templates/bug.md | Removes local issue template (now expected to come from plugin). |
| .claude/skills/writing-github-issues/SKILL.md | Removes local writing-github-issues skill (now expected to come from plugin). |
| .claude/skills/testing-a-feature/SKILL.md | Removes local testing-a-feature skill (now expected to come from plugin). |
| .claude/skills/reviewing-feature-progress/SKILL.md | Removes local reviewing-feature-progress skill (now expected to come from plugin). |
| .claude/skills/planning-a-feature/templates/feature-state.md | Removes local planning state template (now expected to come from plugin). |
| .claude/skills/planning-a-feature/SKILL.md | Removes local planning-a-feature skill (now expected to come from plugin). |
| .claude/skills/opening-a-pull-request/templates/pull-request-ready.md | Removes local PR body template (now expected to come from plugin). |
| .claude/skills/opening-a-pull-request/templates/pull-request-draft.md | Removes local PR body template (now expected to come from plugin). |
| .claude/skills/opening-a-pull-request/SKILL.md | Removes local opening-a-pull-request skill (now expected to come from plugin). |
| .claude/skills/fanning-out-with-worktrees/SKILL.md | Removes local fanning-out-with-worktrees skill (now expected to come from plugin). |
| .claude/skills/developing-a-feature/SKILL.md | Removes local developing-a-feature skill (now expected to come from plugin). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -6,40 +6,42 @@ Code is the source of truth for *what*; `AGENTS.md` is the source of truth for * | |||
|
|
|||
| ## Local skills and the feature-development workflow | |||
| ## Local skills and the feature-development workflow | ||
|
|
||
| The `.claude/skills/` directory holds project-shared skills that every contributor and every Claude session in this repo uses. The skills below choreograph feature work end to end — invoke `planning-a-feature` at feature conception and let the cross-references fan out from there. | ||
| The feature-development workflow skills come from the **`feature-dev-workflow`** plugin (enabled in `.claude/settings.json` under `enabledPlugins`), not from this repo. They choreograph feature work end to end — invoke `feature-dev-workflow:planning-a-feature` at feature conception and let the cross-references fan out from there. |
| State --> D[feature-dev-workflow:developing-a-feature] | ||
|
|
||
| D --> DShape{single-PR<br/>or multi-PR?} | ||
| DShape -->|single-PR| Direct[Implement directly<br/>TDD + testing-a-feature] |
| ### Editing local skills | ||
| ### Editing the workflow skills | ||
|
|
||
| These skills live in the `feature-dev-workflow` plugin (`github.com/sourcehawk/feature-dev-workflow`), not in this repo — edit them there, then bump the enabled version here: |
Comment on lines
+42
to
+44
| ### Editing the workflow skills | ||
|
|
||
| These skills live in the `feature-dev-workflow` plugin (`github.com/sourcehawk/feature-dev-workflow`), not in this repo — edit them there, then bump the enabled version here: |
…epo) The feature-dev workflow + its diagram are documented in github.com/sourcehawk/feature-dev-workflow now; CLAUDE.md keeps only a pointer + the editing note. Also retitle the section (the skills are no longer 'local'). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seven feature-development workflow skills (planning-a-feature, developing-a-feature, fanning-out-with-worktrees, reviewing-feature-progress, opening-a-pull-request, writing-github-issues, testing-a-feature) now ship as the
feature-dev-workflowplugin, enabled in.claude/settings.json.Changes
Remove the in-repo
.claude/skills/copies (7 skills + their templates).Repoint CLAUDE.md's "Local skills and the feature-development workflow" section at the plugin: the workflow diagram and prose now reference the skills as
feature-dev-workflow:<skill>, and "Editing the workflow skills" points atgithub.com/sourcehawk/feature-dev-workflow. Also corrected the diagram's teardown note to "after CI green" (matching the ported fix).Commit
.claude/settings.json(enabledPlugins: feature-dev-workflow + superpowers) so the plugin is enabled for every checkout, and flip the.gitignoreexception from the now-removed.claude/skills/to.claude/settings.json.AGENTS.md is unaffected (its
operator-skills/entry is a different, unrelated directory).Fix parity
The two recent local skill fixes are ported to the plugin in sourcehawk/feature-dev-workflow#1 so nothing is lost:
main, so this ports the same fix into the plugin for parity before the in-repo copies are removed.Note
Branches with unmerged skill edits (e.g.
feat/issue-body-diagrams-and-wrapping) will conflict with this removal on merge; port their skill work into the plugin rather than back into.claude/skills/.Verify before merge
The
feature-dev-workflowmarketplace must be resolvable on a fresh checkout forenabledPluginsto load — committingsettings.jsonenables the plugin but doesn't itself register the marketplace source. Confirm the marketplace is registered the way contributors will get it (repo-level marketplace config or documentedclaude plugin marketplace add github.com/sourcehawk/feature-dev-workflow), else a clean clone gets neither the in-repo skills (removed here) nor the plugin.