refactor: exclude bink and mss32 fake files, use include of header#57
Open
refactor: exclude bink and mss32 fake files, use include of header#57
Conversation
Contributor
|
Ok, I am a bit confused. Are the fake definition not in scope due to this changes, or do I need to test this? Could it be possible to just import our Fake headers from the project here into Ghidra without adding it to the export, use the structs and values from there and remove the Fake structure inside the Crusader folder in Ghidra completely? |
Contributor
Author
|
Hmmm, what I wanted to happen is that those Fake files are deleted, as including Mss32.h would be enough to cover all relevant reimplementations, right? So everything in the /Mss32/ folder in this PR can be removed, right? So, for example, this usage is now correct, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the miles (and bink issues) mentioned in #56
Note namespace
msschanged toMSS,SND_SoundSystemObjchanged toDAT_SoundSystemStateNamespace
_enumschanged toenums