Refactor windows lib functions#58
Merged
Merged
Conversation
TheRedDaemon
requested changes
May 9, 2026
TheRedDaemon
approved these changes
May 9, 2026
gynt
pushed a commit
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved os-specific functions that the game uses to OpenSHC/OS instead of leaving them out of the repo. This allows us to get 100% match and avoid crashes due to mixing statically linked CRT in the original exe and in the OpenSHC dll.
REIMPLEMENTED_CRTis set to 0 in CMakeLists.txt for the OpenSHC dll target. This should be set to 1 if all OS functions are reimplemented (or stubbed) and testing is required.We can either use
// STUBor// FUNCTIONfor any OS function depending on whether we want to ignore reimplementation accuracy of the static lib function (preferred), or whether we want to actually track reimplementation progress of the lib function (can be used if static lib functions turn out to be linker/compiler generated in a custom fashion for the original binary)