Skip to content

Middleware loader #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 14, 2015
Merged

Middleware loader #167

merged 6 commits into from
Aug 14, 2015

Conversation

@robhrt7
Copy link
Member

@robhrt7 robhrt7 commented Aug 13, 2015

Following issue #117, I've created a configurable middleware loader with these requirements in mind:

  • Organize middlewares into logical groups ('pre-html', 'html', 'response' and etc) to escape conflicts between plugins
  • Allow middleware plugins to define custom group and execution order from their options.js
  • Keep configuration safe, so by default, any plugin could not override core middlewares execution order
  • Allow configuration of middlewares, including an ability to replace core modules with other extensions and disabling
  • Keep compatibility with older middleware plugins

@cheshirsky, could you please do a short CR?

@cheshirsky cheshirsky assigned cheshirsky and unassigned cheshirsky Aug 14, 2015
@robhrt7 robhrt7 force-pushed the opertino/middleware-loader branch from fa7d83b to 97f8cec Compare August 14, 2015 10:18
cheshirsky
cheshirsky reviewed Aug 14, 2015
View reviewed changes
core/lib/utils.js Outdated
Copy link
Member

@cheshirsky cheshirsky Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use lodash.noConflict, just in case.

Copy link
Member Author

@robhrt7 robhrt7 Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is applicable to server environment.

robhrt7 added 2 commits August 14, 2015 16:02
@robhrt7
improving error handling
d78ae3e
@robhrt7
Merge branch '0.5.4-dev' into opertino/middleware-loader
c975e33 
* 0.5.4-dev:
  fix numbered list line-height
  clarify: handle error if no info about spec found
  run app in CI with log:trace
  improve options extension in core modules
  utils.extendOptions (cherry picked from commit 6d0f0c3)
robhrt7 added a commit that referenced this pull request Aug 14, 2015
@robhrt7
Merge pull request #167 from sourcejs/opertino/middleware-loader
6ab7814 
middleware loader
@robhrt7 robhrt7 merged commit 6ab7814 into 0.5.4-dev Aug 14, 2015
@robhrt7 robhrt7 deleted the opertino/middleware-loader branch August 14, 2015 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robhrt7 @cheshirsky