GitHub Auth

[cheshirsky]

Basic github auth module is added.

[robhrt7]

Like

[robhrt7]

Please remove white borders from assets/i/unknown.gif

[robhrt7]

Never require something in runtime, do it on app start.

[cheshirsky]

ok

[robhrt7]

I couldn't make it work locally, even when I changed app secret and callback URL to http://local.host:8080/auth/done, could you please provide some instructions?

And since this auth will always need aditional setup, we should turn in off by default.

[cheshirsky]

Please remove white borders from assets/i/unknown.gif

Done.

I couldn't make it work locally, even when I changed app secret and callback URL to http://local.host:8080/auth/done, could you please provide some instructions?

Both http://127.0.0.1:8080 and http:/localhost:8080 work fine, they just should be identical for callback and homepage URLs. You don't need any specific paths like '/auth/done'.

Would you like me to write some tips or doc for it?

And since this auth will always need aditional setup, we should turn in off by default.

Done.

[robhrt7]

please use .source_* namespace

[robhrt7]

please move requires to top, before module exports

[cheshirsky]

done

[robhrt7]

Use demo key, I've created it for localhost:8080

Client ID
cf00a9e7ee5d9d6af36f
Client Secret
aebe08e0aa66f6911e4f54df81ce64c9d6e0003b

[robhrt7]

Add short doc about auth in /docs section, and define that it's disabled by default right now. Then do a squash commit to 0.4.1, I don't have any more comments.

[cheshirsky]

Ok, I`ll do it asap.

[cheshirsky]

Add short doc about auth in /docs section, and define that it's disabled by default right now. Then do a squash commit to 0.4.1, I don't have any more comments.

Short doc is added. I`m going to extend it by usage examples soon.

Use demo key, I've created it for localhost:8080

done.