Fix type_union_implicit rule for Draft 0, 1, and 2#1214
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Fix type_union_implicit rule for Draft 0, 1, and 2#1214staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Fixed vocabulary URI checks in type_union_implicit rule that were using hyper-schema# instead of schema# for Draft 0, 1, and 2. This caused the rule to not detect enum keyword presence, incorrectly adding type array alongside enum. Also updated test expectations to reflect correct behavior where type should not be preserved alongside enum. Co-Authored-By: unknown <>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type_union_implicit rule for Draft 0, 1, and 2
Summary
Fixed a bug in the
type_union_implicitcanonicalizer rule where incorrect vocabulary URIs were being checked for JSON Schema Draft 0, 1, and 2. The rule was checking forhyper-schema#URIs instead ofschema#URIs, which caused it to not detect whenenumwas present, incorrectly adding atypearray alongsideenum.The root cause was an inconsistency within the rule itself - lines 21-30 correctly check for
schema#URIs, but lines 101-117 were checkinghyper-schema#URIs for the same drafts.Review & Testing Checklist for Human
schema#rather thanhyper-schema#as the vocabulary identifier. This is consistent with Draft 3's check on line 96-98 which usesschema#.enumwill no longer get the implicittypearray added.core.alterschemapass with no regressions.Recommended test plan: Run
makefrom the repository root to verify all tests pass and no formatting changes remain.Notes