Refactor SchemaMapResolver::add to use reidentify() function

[staging-devin-ai-integration]

Refactor SchemaMapResolver::add to use reidentify() function

Summary

Replaced manual ID assignment logic in SchemaMapResolver::add with a call to the existing reidentify() function to eliminate code duplication. The original code manually checked vocabulary URIs to determine whether to use "id" or "$id" as the identifier keyword, but this logic was already implemented in the reidentify() utility function.

Changes:

• Removed 15 lines of manual vocabulary checking and ID assignment
• Replaced with single call to sourcemeta::core::reidentify(subschema, key.second, *this, entry.dialect)
• Eliminated TODO comment about de-duplication since the logic is no longer duplicated

Review & Testing Checklist for Human

• Verify ID keyword assignment across schema drafts: Test that schemas from different JSON Schema drafts (draft-00 through draft-04 vs. newer drafts) correctly get assigned "id" vs "$id" keywords respectively
• Validate parameter mapping: Confirm that passing entry.dialect as the default_dialect parameter to reidentify() produces the same behavior as the original vocabulary-based logic
• Test edge cases: Verify behavior with schemas that have ambiguous or missing dialect information

Notes

The refactoring relies on the assumption that entry.dialect provides equivalent information to the original subschema_vocabularies.contains() checks. While all existing tests pass, the subtle difference in dialect determination approach warrants careful testing with various schema draft versions.

Link to Devin run: https://staging.itsdev.in/sessions/401ea5f3a27a40a3a9d2e80079a3f984
Requested by: @jviotti

[staging-devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[staging-devin-ai-integration]

Closing due to inactivity for more than 7 days. Configure here.