Add read-only iterator support to SchemaTransformer#90
Closed
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
Add read-only iterator support to SchemaTransformer#90staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Allow clients to iterate over registered rules for introspection. Provides standard C++ iterator interface with begin(), end(), cbegin(), and cend() methods returning const iterators over the underlying rules map. - Add const_iterator type alias and iterator methods to SchemaTransformer class - Implement begin(), end(), cbegin(), cend() methods in transformer.cc - Add comprehensive tests for iterator functionality including empty transformer, rule access, range-based for loops, and const correctness - Follow existing iterator patterns from SchemaIterator and JSON containers Co-Authored-By: Juan Cruz Viotti <jv@jviotti.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add read-only iterator support to SchemaTransformer
Summary
Adds read-only iterator support to the
SchemaTransformerclass to allow clients to iterate over registered rules for introspection purposes. The implementation provides a standard C++ iterator interface withbegin(),end(),cbegin(), andcend()methods that return const iterators over the underlying rules map.Key changes:
const_iteratortype alias and iterator methods toSchemaTransformerpublic interfacestd::map<std::string, std::unique_ptr<SchemaTransformRule>>SchemaIteratorand JSON container classes in the codebaseThe iterator returns key-value pairs where the key is the rule name (string) and the value is a
unique_ptrto theSchemaTransformRule. This enables range-based for loops and standard iterator operations for rule introspection.Review & Testing Checklist for Human
Notes
Session Info: Requested by Juan Cruz Viotti (@jviotti)
Link to Devin run: https://staging.itsdev.in/sessions/573e86fd8e3b4ba1a6ad0b8558225b35
Technical Details:
make configure compileSchemaIteratorand JSON containers in the codebasestd::mapstructure directly, which provides full introspection but comes with standard map iterator caveats (invalidation on modification, etc.)