Skip to content

Do not store JSON documents as URL strings #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Do not store JSON documents as URL strings #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions www/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,6 @@ function safeJSON (string) {
}

function onAnalyze (value) {
// For shareability purposes
const url = new URL(window.location.href)
url.searchParams.set('json', value)
window.history.replaceState({ value }, '', url.href)

const jsonDocument = safeJSON(value)
if (typeof jsonDocument === 'undefined') {
document.getElementById('json-error').style.display = 'block'
Expand All @@ -187,9 +182,4 @@ document.getElementById('analyze').addEventListener('click', () => {
return onAnalyze(code.getValue())
})

const urlValue = new URL(window.location.href).searchParams.get('json')
if (urlValue) {
code.setValue(urlValue)
}

onAnalyze(code.getValue())