Skip to content

Add a linter rule that validates the default keyword#397

Merged
jviotti merged 1 commit into
mainfrom
default-lint
Apr 15, 2025
Merged

Add a linter rule that validates the default keyword#397
jviotti merged 1 commit into
mainfrom
default-lint

Conversation

@jviotti

@jviotti jviotti commented Apr 15, 2025

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 8f33ffd Previous: 6d37617 Ratio
Compiler_Draft6_AdaptiveCard 45643541333.00003 ns/iter 43531317625.000046 ns/iter 1.05
Compiler_2019_09_OMC_JSON_V2 9473474583.000097 ns/iter 7186216374.999958 ns/iter 1.32
Evaluator_Draft4_Meta_1_No_Callback 209.31887803118576 ns/iter 169.96354947468984 ns/iter 1.23
Evaluator_Draft4_Required_Properties 458.171694633209 ns/iter 398.8419334366607 ns/iter 1.15
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 21.05610633606361 ns/iter 20.57312854900021 ns/iter 1.02
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 8.489784735373398 ns/iter 7.473657777155855 ns/iter 1.14
Evaluator_Draft4_Items_Schema 301.60470487838575 ns/iter 271.42060575179084 ns/iter 1.11
Evaluator_Draft4_Nested_Object 3.3969014340825927 ns/iter 3.168011146097555 ns/iter 1.07
Evaluator_Draft4_Properties_Triad_Optional 807.336205843855 ns/iter 751.34287512026 ns/iter 1.07
Evaluator_Draft4_Properties_Triad_Closed 701.990426362826 ns/iter 607.9475387234362 ns/iter 1.15
Evaluator_Draft4_Properties_Triad_Required 851.8742850913391 ns/iter 733.5008718596823 ns/iter 1.16
Evaluator_Draft4_Properties_Closed 48.93745809193817 ns/iter 44.58132552490147 ns/iter 1.10
Evaluator_Draft4_Non_Recursive_Ref 10.308374947931402 ns/iter 10.012298162702535 ns/iter 1.03
Evaluator_Draft4_Pattern_Properties_True 198.9394388634992 ns/iter 177.99631616810325 ns/iter 1.12
Evaluator_Draft4_Ref_To_Single_Property 7.790184401510478 ns/iter 7.315985488550027 ns/iter 1.06
Evaluator_Draft4_Additional_Properties_Type 16.493655941469807 ns/iter 15.8822253182084 ns/iter 1.04
Evaluator_Draft4_Nested_Oneof 48.80467958195024 ns/iter 47.520806303463466 ns/iter 1.03
Evaluator_Draft4_Short_Enum 8.430411503479663 ns/iter 8.212662904376852 ns/iter 1.03
Evaluator_Draft4_Long_Enum 27.823572363696183 ns/iter 26.93361757994569 ns/iter 1.03
Evaluator_Draft4_Long_Enum_Short_Strings 9.795352533112354 ns/iter 9.517129916590328 ns/iter 1.03
Evaluator_Draft4_Type_Object 5.521355901978954 ns/iter 5.444525851974333 ns/iter 1.01
Evaluator_Draft6_Property_Names 90.95280424889404 ns/iter 89.66732236508052 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 24.354225070986995 ns/iter 24.02246451280102 ns/iter 1.01
Evaluator_Draft7_Vercel_1 31348.024896635547 ns/iter 30874.765889828006 ns/iter 1.02
Evaluator_Draft7_Helm_Chart_Lock_1 101.36789543468682 ns/iter 102.86931693287113 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_2 96.82847480941545 ns/iter 94.89203383901244 ns/iter 1.02
Evaluator_Draft7_Jasmine_1 104.13782119493175 ns/iter 101.91213084933982 ns/iter 1.02
Evaluator_Draft7_Dependabot_1 701.9474876231322 ns/iter 678.367807011681 ns/iter 1.03
Evaluator_2019_09_Unevaluated_Properties 36.78172666112248 ns/iter 35.12347503396924 ns/iter 1.05
Evaluator_2019_09_OMC_JSON_V2_1 904.9965294277164 ns/iter 944.7115562955163 ns/iter 0.96
Evaluator_2020_12_Dynamic_Ref 369.24871888491384 ns/iter 380.10846241780365 ns/iter 0.97
Evaluator_2020_12_Dynamic_Ref_Single 5.421124077377316 ns/iter 5.505810537934884 ns/iter 0.98
Evaluator_2020_12_CQL_1 2178.644347545657 ns/iter 2001.0186583809511 ns/iter 1.09
Evaluator_2020_12_OpenAPI 151734.2693304337 ns/iter 149781.84224026673 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 8f33ffd Previous: 6d37617 Ratio
Compiler_Draft6_AdaptiveCard 63646789880.99996 ns/iter 63291299810 ns/iter 1.01
Compiler_2019_09_OMC_JSON_V2 9257663706.000017 ns/iter 9186888420.000002 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 283.6381353748464 ns/iter 288.86103030956207 ns/iter 0.98
Evaluator_Draft4_Required_Properties 627.2908926680934 ns/iter 628.8877702309348 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 32.55206189148955 ns/iter 33.328272107503565 ns/iter 0.98
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 13.101629662875768 ns/iter 13.099061125869438 ns/iter 1.00
Evaluator_Draft4_Items_Schema 595.946966693387 ns/iter 616.8411969330215 ns/iter 0.97
Evaluator_Draft4_Nested_Object 4.662103787556084 ns/iter 4.662654824562413 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 874.2607011893821 ns/iter 869.222959892477 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 709.0121075600433 ns/iter 691.8863337921701 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Required 853.4233061412843 ns/iter 844.5538890775368 ns/iter 1.01
Evaluator_Draft4_Properties_Closed 86.05661643656389 ns/iter 85.84860547310424 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 29.3160526724783 ns/iter 29.23443047947358 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 250.2276885796092 ns/iter 244.18957651975416 ns/iter 1.02
Evaluator_Draft4_Ref_To_Single_Property 13.382516183901428 ns/iter 13.409070958415276 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 53.4936027913892 ns/iter 53.49497968626172 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 91.46986362359064 ns/iter 91.2071041601594 ns/iter 1.00
Evaluator_Draft4_Short_Enum 17.726028329580814 ns/iter 17.744571802540737 ns/iter 1.00
Evaluator_Draft4_Long_Enum 19.651130714449632 ns/iter 19.60896586748025 ns/iter 1.00
Evaluator_Draft4_Long_Enum_Short_Strings 17.774923313661457 ns/iter 17.732255564459376 ns/iter 1.00
Evaluator_Draft4_Type_Object 10.292256065363562 ns/iter 10.26317327036057 ns/iter 1.00
Evaluator_Draft6_Property_Names 153.61780365517305 ns/iter 151.49432089618782 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 42.02249673495859 ns/iter 42.032605169591314 ns/iter 1.00
Evaluator_Draft7_Vercel_1 46717.13010589851 ns/iter 48284.37369562514 ns/iter 0.97
Evaluator_Draft7_Helm_Chart_Lock_1 280.28886164758205 ns/iter 284.55457858693734 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_2 279.5961065230427 ns/iter 276.2483556450617 ns/iter 1.01
Evaluator_Draft7_Jasmine_1 185.63351023803742 ns/iter 186.43291659611464 ns/iter 1.00
Evaluator_Draft7_Dependabot_1 1234.3305794361902 ns/iter 1233.5809555147587 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 53.836425795399265 ns/iter 54.02770616917529 ns/iter 1.00
Evaluator_2019_09_OMC_JSON_V2_1 1441.9008250190113 ns/iter 1464.3909490781377 ns/iter 0.98
Evaluator_2020_12_Dynamic_Ref 588.4353505851234 ns/iter 587.3559711407485 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref_Single 10.267806180312874 ns/iter 10.267995736164545 ns/iter 1.00
Evaluator_2020_12_CQL_1 3856.9732124046936 ns/iter 3877.4022630485515 ns/iter 0.99
Evaluator_2020_12_OpenAPI 191910.4562398683 ns/iter 188083.1310549087 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Details
Benchmark suite Current: 8f33ffd Previous: 6d37617 Ratio
Compiler_Draft6_AdaptiveCard 61368610143.6615 ns/iter 54067632913.58948 ns/iter 1.14
Compiler_2019_09_OMC_JSON_V2 8119374990.463257 ns/iter 7184599637.9852295 ns/iter 1.13
Evaluator_Draft4_Meta_1_No_Callback 173.34709277160138 ns/iter 165.45419595775132 ns/iter 1.05
Evaluator_Draft4_Required_Properties 344.012840872443 ns/iter 329.74693041820666 ns/iter 1.04
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 20.83979546502491 ns/iter 18.040747084058918 ns/iter 1.16
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 8.45298449093974 ns/iter 7.1242911089103265 ns/iter 1.19
Evaluator_Draft4_Items_Schema 484.4947190606334 ns/iter 445.5025973510117 ns/iter 1.09
Evaluator_Draft4_Nested_Object 2.1886631084660433 ns/iter 2.119324783121528 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Optional 863.2320130558556 ns/iter 816.2771497280136 ns/iter 1.06
Evaluator_Draft4_Properties_Triad_Closed 686.9120872230532 ns/iter 650.9653963752202 ns/iter 1.06
Evaluator_Draft4_Properties_Triad_Required 855.8937219508811 ns/iter 793.5815895706073 ns/iter 1.08
Evaluator_Draft4_Properties_Closed 68.62968443188839 ns/iter 67.13729672884375 ns/iter 1.02
Evaluator_Draft4_Non_Recursive_Ref 13.77702355538186 ns/iter 13.457140445669205 ns/iter 1.02
Evaluator_Draft4_Pattern_Properties_True 192.61557076062428 ns/iter 277.62575984006986 ns/iter 0.69
Evaluator_Draft4_Ref_To_Single_Property 7.529709318210244 ns/iter 7.871947981101152 ns/iter 0.96
Evaluator_Draft4_Additional_Properties_Type 26.16433129043024 ns/iter 26.94159741005276 ns/iter 0.97
Evaluator_Draft4_Nested_Oneof 60.48312582015681 ns/iter 56.7937005157556 ns/iter 1.06
Evaluator_Draft4_Short_Enum 8.44664464188518 ns/iter 8.270146622668165 ns/iter 1.02
Evaluator_Draft4_Long_Enum 10.079758921360577 ns/iter 9.655787570631706 ns/iter 1.04
Evaluator_Draft4_Long_Enum_Short_Strings 8.812075854698975 ns/iter 9.28628629398609 ns/iter 0.95
Evaluator_Draft4_Type_Object 5.1169340911736425 ns/iter 4.636997385974739 ns/iter 1.10
Evaluator_Draft6_Property_Names 113.05562139823651 ns/iter 110.64429894615286 ns/iter 1.02
Evaluator_Draft7_If_Then_Else 28.50779913534451 ns/iter 27.934743789233035 ns/iter 1.02
Evaluator_Draft7_Vercel_1 43584.17768748741 ns/iter 43714.317980997155 ns/iter 1.00
Evaluator_Draft7_Helm_Chart_Lock_1 177.5655922080173 ns/iter 180.43137703322097 ns/iter 0.98
Evaluator_Draft7_Helm_Chart_Lock_2 168.17499449294357 ns/iter 164.36141866936046 ns/iter 1.02
Evaluator_Draft7_Jasmine_1 154.14329267337533 ns/iter 138.3524561678869 ns/iter 1.11
Evaluator_Draft7_Dependabot_1 930.4718495081138 ns/iter 943.3264670270603 ns/iter 0.99
Evaluator_2019_09_Unevaluated_Properties 37.27420739881261 ns/iter 37.90680309060644 ns/iter 0.98
Evaluator_2019_09_OMC_JSON_V2_1 1193.1009853000724 ns/iter 1141.9413258740044 ns/iter 1.04
Evaluator_2020_12_Dynamic_Ref 523.5269069671631 ns/iter 470.33988537946357 ns/iter 1.11
Evaluator_2020_12_Dynamic_Ref_Single 4.911829115525423 ns/iter 4.834522198858153 ns/iter 1.02
Evaluator_2020_12_CQL_1 2635.648991213688 ns/iter 2550.8188820165233 ns/iter 1.03
Evaluator_2020_12_OpenAPI 189563.10941144754 ns/iter 180874.0548537933 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 8f33ffd Previous: 6d37617 Ratio
Evaluator_2020_12_Dynamic_Ref 619.7172606212147 ns/iter 622.3678936599426 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref_Single 9.374376732570921 ns/iter 9.379699237653515 ns/iter 1.00
Evaluator_2020_12_CQL_1 3801.2081314824077 ns/iter 3789.220941061421 ns/iter 1.00
Evaluator_2020_12_OpenAPI 229148.27717925585 ns/iter 230436.29770494383 ns/iter 0.99
Evaluator_2019_09_Unevaluated_Properties 52.105970305485826 ns/iter 52.00611489090391 ns/iter 1.00
Evaluator_2019_09_OMC_JSON_V2_1 1318.3329673488151 ns/iter 1332.3834405664525 ns/iter 0.99
Evaluator_Draft7_If_Then_Else 43.63620586485762 ns/iter 43.61009542138119 ns/iter 1.00
Evaluator_Draft7_Vercel_1 45399.83677778246 ns/iter 46081.393069631486 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_1 123.27380996558252 ns/iter 122.78228665744578 ns/iter 1.00
Evaluator_Draft7_Helm_Chart_Lock_2 119.59106187063767 ns/iter 119.21595572339756 ns/iter 1.00
Evaluator_Draft7_Jasmine_1 151.50670256000393 ns/iter 148.84712005536068 ns/iter 1.02
Evaluator_Draft7_Dependabot_1 942.0157193303902 ns/iter 943.1568044716569 ns/iter 1.00
Evaluator_Draft6_Property_Names 162.29102347118462 ns/iter 162.32676200809178 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 238.03042763576735 ns/iter 236.81382672149627 ns/iter 1.01
Evaluator_Draft4_Required_Properties 468.96806920411143 ns/iter 466.90750948388376 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 27.720277648481954 ns/iter 28.818366646365224 ns/iter 0.96
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 10.281387429171318 ns/iter 10.278864670236736 ns/iter 1.00
Evaluator_Draft4_Items_Schema 492.50904583226696 ns/iter 492.1716392872104 ns/iter 1.00
Evaluator_Draft4_Nested_Object 3.8559073932490824 ns/iter 3.862131105624404 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1021.2563876418969 ns/iter 1026.1448827216805 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Closed 820.0295096055033 ns/iter 820.6759610959624 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Required 1013.9877151046383 ns/iter 1014.0703970148319 ns/iter 1.00
Evaluator_Draft4_Properties_Closed 72.06021698820615 ns/iter 72.43740512153146 ns/iter 0.99
Evaluator_Draft4_Non_Recursive_Ref 12.486568763428568 ns/iter 12.44514234076779 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 232.19694336055457 ns/iter 229.0773829704129 ns/iter 1.01
Evaluator_Draft4_Ref_To_Single_Property 10.281553613071022 ns/iter 10.303229735288971 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 14.97623627522432 ns/iter 14.971740128145763 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 107.53640300176973 ns/iter 108.84993899848007 ns/iter 0.99
Evaluator_Draft4_Short_Enum 17.755288534191255 ns/iter 17.747248286697985 ns/iter 1.00
Evaluator_Draft4_Long_Enum 18.99071734555435 ns/iter 18.98270365258802 ns/iter 1.00
Evaluator_Draft4_Long_Enum_Short_Strings 17.77142322386097 ns/iter 17.816348681325046 ns/iter 1.00
Evaluator_Draft4_Type_Object 9.873359557852597 ns/iter 9.33027700467064 ns/iter 1.06
Compiler_2019_09_OMC_JSON_V2 9978414380.999992 ns/iter 9981684545.000008 ns/iter 1.00
Compiler_Draft6_AdaptiveCard 64026531782.00001 ns/iter 64043171999.00004 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 8f33ffd Previous: 6d37617 Ratio
Compiler_Draft6_AdaptiveCard 210808661999.9999 ns/iter 213639986300.00003 ns/iter 0.99
Compiler_2019_09_OMC_JSON_V2 26872162899.99992 ns/iter 27218770300.000072 ns/iter 0.99
Evaluator_Draft4_Meta_1_No_Callback 401.60074099992124 ns/iter 404.94818281484726 ns/iter 0.99
Evaluator_Draft4_Required_Properties 856.6912693342642 ns/iter 854.9405133928544 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 42.781106249989875 ns/iter 42.90405363405129 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 15.790997767857514 ns/iter 15.811380251262689 ns/iter 1.00
Evaluator_Draft4_Items_Schema 716.4542857144138 ns/iter 717.5904017857297 ns/iter 1.00
Evaluator_Draft4_Nested_Object 6.23622678571475 ns/iter 6.181774999999691 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Optional 1582.525446428816 ns/iter 1583.5810267856536 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Closed 1272.4091071427372 ns/iter 1290.693240761885 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 1574.510714285842 ns/iter 1588.7573660714947 ns/iter 0.99
Evaluator_Draft4_Properties_Closed 88.12665678005479 ns/iter 89.84206741776502 ns/iter 0.98
Evaluator_Draft4_Non_Recursive_Ref 32.49290207020755 ns/iter 32.65066457266969 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 236.4597727165554 ns/iter 237.47876813851255 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 15.802649553567756 ns/iter 16.059151785712903 ns/iter 0.98
Evaluator_Draft4_Additional_Properties_Type 58.235710000008105 ns/iter 58.17666071428513 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 109.0828593750004 ns/iter 109.65603124999392 ns/iter 0.99
Evaluator_Draft4_Short_Enum 24.194832751300662 ns/iter 24.149178571430443 ns/iter 1.00
Evaluator_Draft4_Long_Enum 24.05556334759017 ns/iter 24.191324999999814 ns/iter 0.99
Evaluator_Draft4_Long_Enum_Short_Strings 27.269757102255344 ns/iter 27.461726768375712 ns/iter 0.99
Evaluator_Draft4_Type_Object 13.620262439195434 ns/iter 13.631401948072417 ns/iter 1.00
Evaluator_Draft6_Property_Names 156.99410714284616 ns/iter 157.02678571428868 ns/iter 1.00
Evaluator_Draft7_If_Then_Else 53.38991964285761 ns/iter 53.48536607143168 ns/iter 1.00
Evaluator_Draft7_Vercel_1 73346.55133929756 ns/iter 72613.81249999691 ns/iter 1.01
Evaluator_Draft7_Helm_Chart_Lock_1 297.7010002566352 ns/iter 296.9367168597109 ns/iter 1.00
Evaluator_Draft7_Helm_Chart_Lock_2 273.41765743674455 ns/iter 273.8334252753089 ns/iter 1.00
Evaluator_Draft7_Jasmine_1 239.18130143073088 ns/iter 242.48612249036924 ns/iter 0.99
Evaluator_Draft7_Dependabot_1 1551.2727678570166 ns/iter 1543.2015625001277 ns/iter 1.01
Evaluator_2019_09_Unevaluated_Properties 69.09222098214127 ns/iter 70.11155133929137 ns/iter 0.99
Evaluator_2019_09_OMC_JSON_V2_1 1887.8245427000234 ns/iter 1903.9487535255814 ns/iter 0.99
Evaluator_2020_12_Dynamic_Ref 867.4402377500649 ns/iter 843.0181057954412 ns/iter 1.03
Evaluator_2020_12_Dynamic_Ref_Single 13.408271428573926 ns/iter 13.35607226180218 ns/iter 1.00
Evaluator_2020_12_CQL_1 5067.705000001297 ns/iter 5156.587999999829 ns/iter 0.98
Evaluator_2020_12_OpenAPI 286752.6717556038 ns/iter 286436.68363020587 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 6cbd7f9 into main Apr 15, 2025
@jviotti jviotti deleted the default-lint branch April 15, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant