Skip to content

Ensure prefixItems emits no annotations on empty arrays#411

Merged
jviotti merged 1 commit into
mainfrom
prefixitems-annotations-empty-array
Apr 25, 2025
Merged

Ensure prefixItems emits no annotations on empty arrays#411
jviotti merged 1 commit into
mainfrom
prefixitems-annotations-empty-array

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Apr 24, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 06fa129 Previous: 74e2d3c Ratio
Compiler_Draft6_AdaptiveCard 64243903717.00002 ns/iter 63698654365.99997 ns/iter 1.01
Compiler_2019_09_OMC_JSON_V2 9245387546.000017 ns/iter 9412964378.000027 ns/iter 0.98
Evaluator_Draft4_Meta_1_No_Callback 279.65266342968613 ns/iter 281.90399527080297 ns/iter 0.99
Evaluator_Draft4_Required_Properties 635.352278072363 ns/iter 638.9329557989973 ns/iter 0.99
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 33.77003858675376 ns/iter 32.77675834084374 ns/iter 1.03
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 13.691410393028338 ns/iter 13.703807895622546 ns/iter 1.00
Evaluator_Draft4_Items_Schema 639.9511764856503 ns/iter 637.4488177158256 ns/iter 1.00
Evaluator_Draft4_Nested_Object 5.029046532902972 ns/iter 4.990196188961892 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Optional 953.2909471110543 ns/iter 964.8961271020188 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Closed 759.3675121336747 ns/iter 764.976857796699 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 939.5717377398034 ns/iter 954.9920936935123 ns/iter 0.98
Evaluator_Draft4_Properties_Closed 86.00654287770384 ns/iter 84.30639402912453 ns/iter 1.02
Evaluator_Draft4_Non_Recursive_Ref 29.226475641549136 ns/iter 29.26810194859713 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 249.4576749337072 ns/iter 250.570138420932 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 13.449420637296381 ns/iter 13.417381629468444 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 53.59082844889037 ns/iter 53.53459742608083 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 88.91214973684666 ns/iter 88.7383640322492 ns/iter 1.00
Evaluator_Draft4_Short_Enum 16.220974025730243 ns/iter 16.25874331387 ns/iter 1.00
Evaluator_Draft4_Long_Enum 20.842412499237167 ns/iter 20.861596659974648 ns/iter 1.00
Evaluator_Draft4_Long_Enum_Short_Strings 16.180237953259613 ns/iter 16.278684629498684 ns/iter 0.99
Evaluator_Draft4_Type_Object 10.890936480203871 ns/iter 10.906432019566102 ns/iter 1.00
Evaluator_Draft6_Property_Names 135.63293584565994 ns/iter 136.18402075964076 ns/iter 1.00
Evaluator_Draft7_If_Then_Else 41.654650873128986 ns/iter 41.90357642601653 ns/iter 0.99
Evaluator_Draft7_Vercel_1 49531.40671065509 ns/iter 49741.42344018191 ns/iter 1.00
Evaluator_Draft7_Helm_Chart_Lock_1 279.7454702956011 ns/iter 286.0729201722266 ns/iter 0.98
Evaluator_Draft7_Helm_Chart_Lock_2 279.4360897724384 ns/iter 271.79318613882435 ns/iter 1.03
Evaluator_Draft7_Jasmine_1 182.4258693374111 ns/iter 191.947451742622 ns/iter 0.95
Evaluator_Draft7_Dependabot_1 1474.2362380867473 ns/iter 1295.5048408943487 ns/iter 1.14
Evaluator_2019_09_Unevaluated_Properties 53.918525344769684 ns/iter 53.986300819708354 ns/iter 1.00
Evaluator_2019_09_OMC_JSON_V2_1 1492.9796926129263 ns/iter 1484.8181728841628 ns/iter 1.01
Evaluator_2020_12_Dynamic_Ref 575.9517642853522 ns/iter 562.6159883418449 ns/iter 1.02
Evaluator_2020_12_Dynamic_Ref_Single 10.579896775050011 ns/iter 10.583266080636609 ns/iter 1.00
Evaluator_2020_12_CQL_1 3759.6829782117143 ns/iter 3782.6280857615184 ns/iter 0.99
Evaluator_2020_12_OpenAPI 198270.6009454818 ns/iter 194039.91240673175 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 06fa129 Previous: 74e2d3c Ratio
Compiler_Draft6_AdaptiveCard 44145878667.00003 ns/iter 51670902375.000084 ns/iter 0.85
Compiler_2019_09_OMC_JSON_V2 7281132291.999938 ns/iter 8644086750.000042 ns/iter 0.84
Evaluator_Draft4_Meta_1_No_Callback 179.60149307739314 ns/iter 192.32865531007872 ns/iter 0.93
Evaluator_Draft4_Required_Properties 397.3208093973107 ns/iter 437.5538493227319 ns/iter 0.91
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 19.46713405127558 ns/iter 20.99135281198876 ns/iter 0.93
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 8.170824765153212 ns/iter 9.079410778610752 ns/iter 0.90
Evaluator_Draft4_Items_Schema 405.55414043072346 ns/iter 445.7180272651341 ns/iter 0.91
Evaluator_Draft4_Nested_Object 3.1335046104487 ns/iter 3.405789364835507 ns/iter 0.92
Evaluator_Draft4_Properties_Triad_Optional 750.7551489668415 ns/iter 803.1236690585293 ns/iter 0.93
Evaluator_Draft4_Properties_Triad_Closed 625.5661169672234 ns/iter 677.6776444543382 ns/iter 0.92
Evaluator_Draft4_Properties_Triad_Required 787.9613021105982 ns/iter 843.3070869624131 ns/iter 0.93
Evaluator_Draft4_Properties_Closed 46.27115966851096 ns/iter 49.136759759339185 ns/iter 0.94
Evaluator_Draft4_Non_Recursive_Ref 17.75106570159903 ns/iter 19.43390939315817 ns/iter 0.91
Evaluator_Draft4_Pattern_Properties_True 174.1233666898839 ns/iter 189.0989508689647 ns/iter 0.92
Evaluator_Draft4_Ref_To_Single_Property 8.197987126532347 ns/iter 8.74256621370683 ns/iter 0.94
Evaluator_Draft4_Additional_Properties_Type 31.66912205235227 ns/iter 34.68590945833796 ns/iter 0.91
Evaluator_Draft4_Nested_Oneof 50.32792079999808 ns/iter 52.732688182354536 ns/iter 0.95
Evaluator_Draft4_Short_Enum 8.914064940121044 ns/iter 9.520706202100948 ns/iter 0.94
Evaluator_Draft4_Long_Enum 26.626385562069714 ns/iter 28.32769143951226 ns/iter 0.94
Evaluator_Draft4_Long_Enum_Short_Strings 10.361742284259277 ns/iter 11.087897957757793 ns/iter 0.93
Evaluator_Draft4_Type_Object 5.98856834803635 ns/iter 6.414875405245204 ns/iter 0.93
Evaluator_Draft6_Property_Names 95.04399928007308 ns/iter 109.71784145920172 ns/iter 0.87
Evaluator_Draft7_If_Then_Else 27.51786315802671 ns/iter 31.271905971172163 ns/iter 0.88
Evaluator_Draft7_Vercel_1 35881.35519097615 ns/iter 38478.35533855294 ns/iter 0.93
Evaluator_Draft7_Helm_Chart_Lock_1 153.68892669901396 ns/iter 164.6931509229538 ns/iter 0.93
Evaluator_Draft7_Helm_Chart_Lock_2 154.55481577303675 ns/iter 164.7888772659188 ns/iter 0.94
Evaluator_Draft7_Jasmine_1 120.06912698609223 ns/iter 127.0387502563726 ns/iter 0.95
Evaluator_Draft7_Dependabot_1 769.1589488417195 ns/iter 830.4523401633588 ns/iter 0.93
Evaluator_2019_09_Unevaluated_Properties 37.77948749301291 ns/iter 41.319469598868366 ns/iter 0.91
Evaluator_2019_09_OMC_JSON_V2_1 950.9594119855752 ns/iter 1023.9955302592897 ns/iter 0.93
Evaluator_2020_12_Dynamic_Ref 393.2632191330793 ns/iter 425.3172839392732 ns/iter 0.92
Evaluator_2020_12_Dynamic_Ref_Single 5.9852416574634875 ns/iter 6.440110003557075 ns/iter 0.93
Evaluator_2020_12_CQL_1 2318.061764042826 ns/iter 8001.515779704409 ns/iter 0.29
Evaluator_2020_12_OpenAPI 152541.83868865587 ns/iter 188412.61232351075 ns/iter 0.81

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Details
Benchmark suite Current: 06fa129 Previous: 74e2d3c Ratio
Compiler_Draft6_AdaptiveCard 55349218845.36743 ns/iter 56407300949.09668 ns/iter 0.98
Compiler_2019_09_OMC_JSON_V2 7288573265.075684 ns/iter 8060357809.066772 ns/iter 0.90
Evaluator_Draft4_Meta_1_No_Callback 159.29632355758653 ns/iter 166.24247894265477 ns/iter 0.96
Evaluator_Draft4_Required_Properties 321.12280953429655 ns/iter 347.8869175390119 ns/iter 0.92
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 18.07719759878677 ns/iter 19.251042423040875 ns/iter 0.94
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 6.966723757090366 ns/iter 7.855938662637617 ns/iter 0.89
Evaluator_Draft4_Items_Schema 433.0017180591606 ns/iter 471.18240431685695 ns/iter 0.92
Evaluator_Draft4_Nested_Object 2.1138371855522378 ns/iter 2.1071354937933 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 852.2485628494316 ns/iter 852.9592132701843 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Closed 653.4125307493706 ns/iter 662.6060216378792 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 802.7505729357413 ns/iter 821.6620331948487 ns/iter 0.98
Evaluator_Draft4_Properties_Closed 67.47811152440597 ns/iter 63.8945563305326 ns/iter 1.06
Evaluator_Draft4_Non_Recursive_Ref 12.907960498688425 ns/iter 13.41052750572629 ns/iter 0.96
Evaluator_Draft4_Pattern_Properties_True 178.87550935673275 ns/iter 180.60273277015486 ns/iter 0.99
Evaluator_Draft4_Ref_To_Single_Property 6.899713191714072 ns/iter 7.000702688693451 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 24.807936072239105 ns/iter 24.861245366565527 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 57.2239363733538 ns/iter 57.527683059865886 ns/iter 0.99
Evaluator_Draft4_Short_Enum 7.869480013648517 ns/iter 7.864503112011019 ns/iter 1.00
Evaluator_Draft4_Long_Enum 8.784295537739327 ns/iter 8.856909564424619 ns/iter 0.99
Evaluator_Draft4_Long_Enum_Short_Strings 8.31060070169416 ns/iter 8.179876521690764 ns/iter 1.02
Evaluator_Draft4_Type_Object 4.543220463200028 ns/iter 4.543330996872339 ns/iter 1.00
Evaluator_Draft6_Property_Names 109.83487520986597 ns/iter 109.86041847961769 ns/iter 1.00
Evaluator_Draft7_If_Then_Else 24.67097629181042 ns/iter 24.96979519185023 ns/iter 0.99
Evaluator_Draft7_Vercel_1 38059.95914404676 ns/iter 38337.036028731425 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_1 164.67731810112903 ns/iter 165.58203412283763 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_2 156.95439839729693 ns/iter 158.1131903895102 ns/iter 0.99
Evaluator_Draft7_Jasmine_1 123.74196136023032 ns/iter 124.35115955085568 ns/iter 1.00
Evaluator_Draft7_Dependabot_1 941.3942035549135 ns/iter 869.1406039740907 ns/iter 1.08
Evaluator_2019_09_Unevaluated_Properties 32.95059472672379 ns/iter 33.26706455324909 ns/iter 0.99
Evaluator_2019_09_OMC_JSON_V2_1 1049.433246430384 ns/iter 1127.2151764942873 ns/iter 0.93
Evaluator_2020_12_Dynamic_Ref 449.28329718830696 ns/iter 467.54581900844386 ns/iter 0.96
Evaluator_2020_12_Dynamic_Ref_Single 4.560041695652956 ns/iter 4.965311409495073 ns/iter 0.92
Evaluator_2020_12_CQL_1 2564.6222717147907 ns/iter 2487.470423859159 ns/iter 1.03
Evaluator_2020_12_OpenAPI 163763.44898146534 ns/iter 174002.12729543264 ns/iter 0.94

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 06fa129 Previous: 74e2d3c Ratio
Evaluator_2020_12_Dynamic_Ref 644.7347046052582 ns/iter 669.527594113883 ns/iter 0.96
Evaluator_2020_12_Dynamic_Ref_Single 9.687695922580641 ns/iter 9.689766952594306 ns/iter 1.00
Evaluator_2020_12_CQL_1 4047.1772619908747 ns/iter 3922.318810854594 ns/iter 1.03
Evaluator_2020_12_OpenAPI 230233.00954890906 ns/iter 229411.96792327365 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 53.25428736934727 ns/iter 53.377214689337414 ns/iter 1.00
Evaluator_2019_09_OMC_JSON_V2_1 1449.0342710925775 ns/iter 1453.414700051158 ns/iter 1.00
Evaluator_Draft7_If_Then_Else 44.97680989837523 ns/iter 45.003608460226964 ns/iter 1.00
Evaluator_Draft7_Vercel_1 46209.46469510652 ns/iter 47016.76985094643 ns/iter 0.98
Evaluator_Draft7_Helm_Chart_Lock_1 128.99229948021645 ns/iter 131.63041641072184 ns/iter 0.98
Evaluator_Draft7_Helm_Chart_Lock_2 124.896264133755 ns/iter 128.4126321946048 ns/iter 0.97
Evaluator_Draft7_Jasmine_1 154.2609718840494 ns/iter 155.10498505797298 ns/iter 0.99
Evaluator_Draft7_Dependabot_1 950.4435155693642 ns/iter 937.5692852719865 ns/iter 1.01
Evaluator_Draft6_Property_Names 164.81173873322194 ns/iter 164.75589378780802 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 250.7012878930822 ns/iter 251.59211346217526 ns/iter 1.00
Evaluator_Draft4_Required_Properties 557.1295539585867 ns/iter 554.468941509843 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 29.38008884764014 ns/iter 29.222695810220138 ns/iter 1.01
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 12.464212255522446 ns/iter 12.45198525224149 ns/iter 1.00
Evaluator_Draft4_Items_Schema 503.551728015738 ns/iter 501.87568654141785 ns/iter 1.00
Evaluator_Draft4_Nested_Object 3.8460916788235933 ns/iter 3.869157553322151 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Optional 1037.4948700292614 ns/iter 1045.7586802513454 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Closed 833.3666144605079 ns/iter 842.8437711610057 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 1059.1864826535616 ns/iter 1060.9840457312728 ns/iter 1.00
Evaluator_Draft4_Properties_Closed 75.36870779952676 ns/iter 75.24590679073903 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 12.455947975906147 ns/iter 12.447469363097637 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 244.64710894726713 ns/iter 242.72519530710773 ns/iter 1.01
Evaluator_Draft4_Ref_To_Single_Property 12.457993653699607 ns/iter 12.454005961467576 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 14.925643812026063 ns/iter 14.941325602922714 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 110.47794168738469 ns/iter 110.5871707929539 ns/iter 1.00
Evaluator_Draft4_Short_Enum 17.735267629144627 ns/iter 17.746679466343156 ns/iter 1.00
Evaluator_Draft4_Long_Enum 22.95137686257437 ns/iter 22.855852588196328 ns/iter 1.00
Evaluator_Draft4_Long_Enum_Short_Strings 17.732720658634165 ns/iter 17.735771301486785 ns/iter 1.00
Evaluator_Draft4_Type_Object 9.681961246717455 ns/iter 9.684253880748205 ns/iter 1.00
Compiler_2019_09_OMC_JSON_V2 10021235021.000166 ns/iter 9973833357.999979 ns/iter 1.00
Compiler_Draft6_AdaptiveCard 64706058012.99985 ns/iter 65060145411.00001 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 06fa129 Previous: 74e2d3c Ratio
Compiler_Draft6_AdaptiveCard 215614974600.0001 ns/iter 216552838499.9998 ns/iter 1.00
Compiler_2019_09_OMC_JSON_V2 27072076700.000027 ns/iter 27356184399.999847 ns/iter 0.99
Evaluator_Draft4_Meta_1_No_Callback 364.3733064451661 ns/iter 364.80845825044554 ns/iter 1.00
Evaluator_Draft4_Required_Properties 840.9505580357595 ns/iter 842.1344454756548 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 36.962292197095266 ns/iter 36.89635648399753 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 15.797290178574436 ns/iter 15.802022885256052 ns/iter 1.00
Evaluator_Draft4_Items_Schema 654.9579464287295 ns/iter 665.0952008929575 ns/iter 0.98
Evaluator_Draft4_Nested_Object 6.511854464284689 ns/iter 6.497469642856199 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1551.570312499909 ns/iter 1602.3044642860132 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Closed 1259.4355315021037 ns/iter 1286.6994642860975 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Required 1612.7725446425854 ns/iter 1641.4743303571859 ns/iter 0.98
Evaluator_Draft4_Properties_Closed 89.48782636214682 ns/iter 89.25094690844186 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 32.19761300309045 ns/iter 32.22604269103483 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 221.20371874997602 ns/iter 221.09081250000884 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 16.186200338040642 ns/iter 15.893486607139502 ns/iter 1.02
Evaluator_Draft4_Additional_Properties_Type 57.23242999999912 ns/iter 58.2671339285566 ns/iter 0.98
Evaluator_Draft4_Nested_Oneof 101.36401562501618 ns/iter 101.20510262476911 ns/iter 1.00
Evaluator_Draft4_Short_Enum 24.31006428571436 ns/iter 24.036203972811716 ns/iter 1.01
Evaluator_Draft4_Long_Enum 23.120919384811096 ns/iter 23.049177198114396 ns/iter 1.00
Evaluator_Draft4_Long_Enum_Short_Strings 27.566951662649597 ns/iter 27.169167735849737 ns/iter 1.01
Evaluator_Draft4_Type_Object 12.982683928571856 ns/iter 12.697959318313256 ns/iter 1.02
Evaluator_Draft6_Property_Names 165.50256696429446 ns/iter 168.55475446431814 ns/iter 0.98
Evaluator_Draft7_If_Then_Else 50.60869999999795 ns/iter 51.5265399999862 ns/iter 0.98
Evaluator_Draft7_Vercel_1 72893.78348216096 ns/iter 73261.18303573484 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_1 306.5156421299253 ns/iter 308.03958615633354 ns/iter 1.00
Evaluator_Draft7_Helm_Chart_Lock_2 271.21592505424326 ns/iter 270.72296297871424 ns/iter 1.00
Evaluator_Draft7_Jasmine_1 211.1443125000534 ns/iter 212.46971875001464 ns/iter 0.99
Evaluator_Draft7_Dependabot_1 1511.2754464285315 ns/iter 1505.6557340821696 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 72.11038392857257 ns/iter 72.05380357143147 ns/iter 1.00
Evaluator_2019_09_OMC_JSON_V2_1 1885.0736473866657 ns/iter 1882.5110558136375 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref 840.5994419644308 ns/iter 857.6973403136536 ns/iter 0.98
Evaluator_2020_12_Dynamic_Ref_Single 13.276008422873224 ns/iter 13.090421593345642 ns/iter 1.01
Evaluator_2020_12_CQL_1 4916.543496913199 ns/iter 4930.400786071277 ns/iter 1.00
Evaluator_2020_12_OpenAPI 275630.13282734406 ns/iter 280279.1080755448 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 2f8a1e8 into main Apr 25, 2025
13 checks passed
@jviotti jviotti deleted the prefixitems-annotations-empty-array branch April 25, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant