Implement `rereference` for `type_array_to_any_of` by jviotti · Pull Request #702 · sourcemeta/blaze

jviotti · 2026-04-10T18:31:24Z

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai

1 issue found across 4 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/alterschema/canonicalizer/type_array_to_any_of.h">

<violation number="1" location="src/alterschema/canonicalizer/type_array_to_any_of.h:112">
P2: rereference always rebases to /anyOf/... but transform nests the new anyOf under /allOf/... when the original schema already had anyOf (or allOf). In those cases this pointer will be wrong and references won’t resolve to the moved keyword.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/alterschema/canonicalizer/type_array_to_any_of.h

augmentcode · 2026-04-10T18:36:42Z

🤖 Augment PR Summary

Summary: This PR adds reference-rewriting support for the type_array_to_any_of canonicalization rule so that $ref targets remain valid after multi-type schemas are rewritten into anyOf/allOf structures.

Changes:

Track, during TypeArrayToAnyOf::transform, which anyOf branch each moved keyword ends up in and what prefix path (anyOf vs allOf/.../anyOf) holds the generated disjunctors
Implement TypeArrayToAnyOf::rereference to rebase broken pointers from the old keyword location into the new disjunctor branch location
Update SchemaTransformer rereference plumbing to distinguish document-root-relative fragments (e.g. #/$defs/...) from resource-relative fragments (e.g. https://id#/items) when rebuilding the URI fragment
Add canonicalization tests covering refs into subschemas, pre-existing anyOf/allOf wrappers, nested subschemas within a resource, and absolute-URI refs
Add a transformer-level regression test ensuring rereference works when transforming a subschema that declares its own $id

Technical Notes: The rereference callback now operates in resource-relative pointer space and only prepends the sliced-off resource prefix when the original fragment matched the full document pointer.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-04-10T18:36:43Z

src/alterschema/canonicalizer/type_array_to_any_of.h

+                                              current);
+    }
+
+    static const std::string anyof_keyword{"anyOf"};


src/alterschema/canonicalizer/type_array_to_any_of.h:109: rereference() always rebases into anyOf/..., but transform() can wrap the generated disjunctors under an allOf branch when the input schema already defines anyOf (or appends to an existing allOf). In those cases, the returned pointer may not match the actual post-transform location and references can remain broken.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

src/alterschema/canonicalizer/type_array_to_any_of.h

src/alterschema/transformer.cc

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti · 2026-04-10T18:42:11Z

test/alterschema/alterschema_canonicalize_2020_12_test.cc

+  CANONICALIZE(document, result, traces);
+
+  EXPECT_TRUE(result.first);
+  EXPECT_TRUE(document.defines("$ref"));


Loose tests

cubic-dev-ai

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="test/alterschema/alterschema_canonicalize_2020_12_test.cc">

<violation number="1" location="test/alterschema/alterschema_canonicalize_2020_12_test.cc:1441">
P3: These tests don’t assert the rewritten reference path, so they can pass even if `rereference` is broken. Compare the full canonicalized document instead of only checking `$ref`/`$defs` presence.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

test/alterschema/alterschema_canonicalize_2020_12_test.cc

github-actions

Benchmark (linux/llvm)

Details

Benchmark suite	Current: `7774e6b`	Previous: `45d3228`	Ratio
`E2E_Compiler_adaptivecard`	`61858704.600001596` ns/iter	`61700465.1000002` ns/iter	`1.00`
`E2E_Compiler_ansible_meta`	`29058965.041665867` ns/iter	`28985323.874998417` ns/iter	`1.00`
`E2E_Compiler_aws_cdk`	`380929.6471227007` ns/iter	`373587.5525894111` ns/iter	`1.02`
`E2E_Compiler_babelrc`	`2607732.0892192707` ns/iter	`2569519.2234432218` ns/iter	`1.01`
`E2E_Compiler_clang_format`	`18440944.868420895` ns/iter	`18285218.23684145` ns/iter	`1.01`
`E2E_Compiler_cmake_presets`	`25920622.666666936` ns/iter	`25809405.074074607` ns/iter	`1.00`
`E2E_Compiler_code_climate`	`2602177.190298599` ns/iter	`2578034.782287747` ns/iter	`1.01`
`E2E_Compiler_cql2`	`12974236.018518722` ns/iter	`12857852.54545379` ns/iter	`1.01`
`E2E_Compiler_cspell`	`22801915.700000565` ns/iter	`22896194.19354949` ns/iter	`1.00`
`E2E_Compiler_cypress`	`3939036.342696807` ns/iter	`3871399.5248619625` ns/iter	`1.02`
`E2E_Compiler_deno`	`7781585.098901455` ns/iter	`7633391.5543482015` ns/iter	`1.02`
`E2E_Compiler_dependabot`	`3910247.2122905133` ns/iter	`3880283.8111109855` ns/iter	`1.01`
`E2E_Compiler_draft_04`	`2704755.297297406` ns/iter	`2661847.958174786` ns/iter	`1.02`
`E2E_Compiler_fabric_mod`	`4798530.66438359` ns/iter	`4730416.804054246` ns/iter	`1.01`
`E2E_Compiler_geojson`	`21871853.312500633` ns/iter	`21731591.468750365` ns/iter	`1.01`
`E2E_Compiler_gitpod_configuration`	`4916137.901408175` ns/iter	`4885107.9513888685` ns/iter	`1.01`
`E2E_Compiler_helm_chart_lock`	`716293.7258726743` ns/iter	`700929.8130000161` ns/iter	`1.02`
`E2E_Compiler_importmap`	`288369.02913416165` ns/iter	`283867.93376675725` ns/iter	`1.02`
`E2E_Compiler_jasmine`	`1379000.1237721243` ns/iter	`1361584.9825581415` ns/iter	`1.01`
`E2E_Compiler_jshintrc`	`4367405.587500173` ns/iter	`4322038.679012261` ns/iter	`1.01`
`E2E_Compiler_jsconfig`	`21636607.843749546` ns/iter	`21524324.062498935` ns/iter	`1.01`
`E2E_Compiler_krakend`	`136681716.99998766` ns/iter	`135923545.3999986` ns/iter	`1.01`
`E2E_Compiler_lazygit`	`33372536.809522334` ns/iter	`33031348.285714474` ns/iter	`1.01`
`E2E_Compiler_lerna`	`1608577.2500000822` ns/iter	`1584511.9999999383` ns/iter	`1.02`
`E2E_Compiler_nest_cli`	`7466758.265957438` ns/iter	`7371685.915789409` ns/iter	`1.01`
`E2E_Compiler_omc`	`149814145.20000273` ns/iter	`147747673.9999929` ns/iter	`1.01`
`E2E_Compiler_omnisharp`	`6741495.711538575` ns/iter	`6667403.314285518` ns/iter	`1.01`
`E2E_Compiler_openapi`	`24935436.96428446` ns/iter	`24740159.392858833` ns/iter	`1.01`
`E2E_Compiler_pre_commit_hooks`	`5337690.832061005` ns/iter	`5294486.930232543` ns/iter	`1.01`
`E2E_Compiler_pulumi`	`4074632.122092622` ns/iter	`4014052.5402297047` ns/iter	`1.02`
`E2E_Compiler_semantic_release`	`1608255.6796338593` ns/iter	`1577991.0520361622` ns/iter	`1.02`
`E2E_Compiler_stale`	`1572357.8089888035` ns/iter	`1547940.146017768` ns/iter	`1.02`
`E2E_Compiler_stylecop`	`6187092.389380075` ns/iter	`6150657.324561256` ns/iter	`1.01`
`E2E_Compiler_tmuxinator`	`1944748.8384400122` ns/iter	`1925999.8296703415` ns/iter	`1.01`
`E2E_Compiler_ui5`	`46898855.866667576` ns/iter	`46529901.13333241` ns/iter	`1.01`
`E2E_Compiler_ui5_manifest`	`303820301.9999628` ns/iter	`306756366.9999913` ns/iter	`0.99`
`E2E_Compiler_unreal_engine_uproject`	`4631874.098683697` ns/iter	`4571663.424836542` ns/iter	`1.01`
`E2E_Compiler_vercel`	`12412114.642856408` ns/iter	`12358630.315789374` ns/iter	`1.00`
`E2E_Compiler_yamllint`	`349913.48374187044` ns/iter	`345536.6582716124` ns/iter	`1.01`
`E2E_Evaluator_adaptivecard`	`24972.71007176419` ns/iter	`24978.232568088853` ns/iter	`1.00`
`E2E_Evaluator_ansible_meta`	`226266.279806147` ns/iter	`228729.59890286182` ns/iter	`0.99`
`E2E_Evaluator_aws_cdk`	`50307.767754038316` ns/iter	`50488.597722823295` ns/iter	`1.00`
`E2E_Evaluator_babelrc`	`111697.16210227717` ns/iter	`111137.43500948865` ns/iter	`1.01`
`E2E_Evaluator_cerebrum_criminal_case`	`1210968.795180751` ns/iter	`1193336.7680411686` ns/iter	`1.01`
`E2E_Evaluator_clang_format`	`125127.4885455679` ns/iter	`124335.40931632977` ns/iter	`1.01`
`E2E_Evaluator_cmake_presets`	`4248854.915662848` ns/iter	`4240088.636363521` ns/iter	`1.00`
`E2E_Evaluator_code_climate`	`174937.53788633936` ns/iter	`176268.59053135067` ns/iter	`0.99`
`E2E_Evaluator_cql2`	`230785.31916308205` ns/iter	`208961.45863569246` ns/iter	`1.10`
`E2E_Evaluator_cspell`	`562192.4932271155` ns/iter	`561896.8933440311` ns/iter	`1.00`
`E2E_Evaluator_cypress`	`190728.3188405828` ns/iter	`191879.1753282187` ns/iter	`0.99`
`E2E_Evaluator_deno`	`314205.97155556607` ns/iter	`315629.6554698078` ns/iter	`1.00`
`E2E_Evaluator_dependabot`	`415443.2195266253` ns/iter	`420614.3647836464` ns/iter	`0.99`
`E2E_Evaluator_draft_04`	`6844903.020201727` ns/iter	`6890097.051020385` ns/iter	`0.99`
`E2E_Evaluator_fabric_mod`	`759806.2370689227` ns/iter	`715695.4212679124` ns/iter	`1.06`
`E2E_Evaluator_geojson`	`15467971.5111115` ns/iter	`15529767.733332595` ns/iter	`1.00`
`E2E_Evaluator_gitpod_configuration`	`228112.84045678173` ns/iter	`237548.39161554285` ns/iter	`0.96`
`E2E_Evaluator_helm_chart_lock`	`355842.4236427803` ns/iter	`356718.90918420715` ns/iter	`1.00`
`E2E_Evaluator_importmap`	`47686.10105844707` ns/iter	`47944.447854489525` ns/iter	`0.99`
`E2E_Evaluator_jasmine`	`122297.39731053081` ns/iter	`122397.75806733416` ns/iter	`1.00`
`E2E_Evaluator_jshintrc`	`1201110.859589084` ns/iter	`1198783.8610108297` ns/iter	`1.00`
`E2E_Evaluator_jsconfig`	`425671.05416925927` ns/iter	`426538.7812309212` ns/iter	`1.00`
`E2E_Evaluator_krakend`	`202178.99591716242` ns/iter	`200640.72687611362` ns/iter	`1.01`
`E2E_Evaluator_lazygit`	`147244.0609115724` ns/iter	`145485.16691129978` ns/iter	`1.01`
`E2E_Evaluator_lerna`	`142987.5768611675` ns/iter	`141696.4942178845` ns/iter	`1.01`
`E2E_Evaluator_nest_cli`	`179746.75057915284` ns/iter	`179899.7571318371` ns/iter	`1.00`
`E2E_Evaluator_omc`	`19475.91056727753` ns/iter	`19857.958849123654` ns/iter	`0.98`
`E2E_Evaluator_omnisharp`	`611840.6710759009` ns/iter	`615516.3546970693` ns/iter	`0.99`
`E2E_Evaluator_openapi`	`12798643.314814247` ns/iter	`13135756.673075495` ns/iter	`0.97`
`E2E_Evaluator_pre_commit_hooks`	`468483.85876840586` ns/iter	`467193.6539746365` ns/iter	`1.00`
`E2E_Evaluator_pulumi`	`715218.0654396672` ns/iter	`709590.4694500852` ns/iter	`1.01`
`E2E_Evaluator_semantic_release`	`101037.08865451008` ns/iter	`100084.87129564537` ns/iter	`1.01`
`E2E_Evaluator_stale`	`154518.94304750263` ns/iter	`149384.47513339555` ns/iter	`1.03`
`E2E_Evaluator_stylecop`	`280814.49779206526` ns/iter	`281886.5040453171` ns/iter	`1.00`
`E2E_Evaluator_tmuxinator`	`96622.40762665607` ns/iter	`97037.13005103843` ns/iter	`1.00`
`E2E_Evaluator_ui5`	`517143.08752729994` ns/iter	`500543.26925845054` ns/iter	`1.03`
`E2E_Evaluator_ui5_manifest`	`2609830.1098903194` ns/iter	`2506863.468864393` ns/iter	`1.04`
`E2E_Evaluator_unreal_engine_uproject`	`420876.9651442141` ns/iter	`425456.2695810563` ns/iter	`0.99`
`E2E_Evaluator_vercel`	`319862.01108546666` ns/iter	`317132.3690909069` ns/iter	`1.01`
`E2E_Evaluator_yamllint`	`8764.691227940253` ns/iter	`8696.174408413377` ns/iter	`1.01`
`Micro_Draft4_Meta_1_No_Callback`	`193.6133426523814` ns/iter	`193.09816603000485` ns/iter	`1.00`
`Micro_Draft4_Required_Properties`	`795.0319169390539` ns/iter	`793.8650993452153` ns/iter	`1.00`
`Micro_Draft4_Many_Optional_Properties_Minimal_Match`	`22.727249010256738` ns/iter	`22.86378439424689` ns/iter	`0.99`
`Micro_Draft4_Few_Optional_Properties_Minimal_Match`	`10.906418452806282` ns/iter	`10.910924594671375` ns/iter	`1.00`
`Micro_Draft4_Items_Schema`	`286.7822332582547` ns/iter	`293.7297716130917` ns/iter	`0.98`
`Micro_Draft4_Nested_Object`	`1.774365884096024` ns/iter	`1.8126913673819747` ns/iter	`0.98`
`Micro_Draft4_Properties_Triad_Optional`	`318.4012167022989` ns/iter	`329.8736906219761` ns/iter	`0.97`
`Micro_Draft4_Properties_Triad_Closed`	`264.1011510448016` ns/iter	`274.60407746758216` ns/iter	`0.96`
`Micro_Draft4_Properties_Triad_Required`	`331.12066267249185` ns/iter	`329.3660679275533` ns/iter	`1.01`
`Micro_Draft4_Properties_Closed`	`54.016398949665394` ns/iter	`54.231115374823695` ns/iter	`1.00`
`Micro_Draft4_Non_Recursive_Ref`	`11.632282984083245` ns/iter	`11.794265185437224` ns/iter	`0.99`
`Micro_Draft4_Pattern_Properties_True`	`158.36568959257622` ns/iter	`158.4445599723408` ns/iter	`1.00`
`Micro_Draft4_Ref_To_Single_Property`	`10.931437255499162` ns/iter	`10.928888108712922` ns/iter	`1.00`
`Micro_Draft4_Additional_Properties_Type`	`21.928827262310445` ns/iter	`22.051614324656086` ns/iter	`0.99`
`Micro_Draft4_Nested_Oneof`	`57.35237511954682` ns/iter	`57.47331836689406` ns/iter	`1.00`
`Micro_Draft4_Short_Enum`	`14.14782676977846` ns/iter	`11.836394722358207` ns/iter	`1.20`
`Micro_Draft4_Long_Enum`	`14.034206303690008` ns/iter	`14.029685119428914` ns/iter	`1.00`
`Micro_Draft4_Long_Enum_Short_Strings`	`14.157984365963065` ns/iter	`11.831798949500735` ns/iter	`1.20`
`Micro_Draft4_Type_Object`	`3.4271580956102428` ns/iter	`3.4419468116524734` ns/iter	`1.00`
`Micro_Draft4_Ref_Single_100`	`2392538.7133103805` ns/iter	`2356311.4680135595` ns/iter	`1.02`
`Micro_Draft4_Compile_Ref_Many_Nested`	`1733813.1509899483` ns/iter	`1700387.424390245` ns/iter	`1.02`
`Micro_Draft4_Compile_Wrap`	`2384018.915254042` ns/iter	`2344032.3221474434` ns/iter	`1.02`
`Micro_Draft6_Property_Names`	`119.05051609042755` ns/iter	`119.05884825206424` ns/iter	`1.00`
`Micro_Draft6_Compile_FHIR`	`13934057483.999937` ns/iter	`13842887839.000013` ns/iter	`1.01`
`Micro_Draft7_If_Then_Else`	`22.714170916173053` ns/iter	`22.732041032737577` ns/iter	`1.00`
`Micro_2019_09_Unevaluated_Properties`	`28.857930344893738` ns/iter	`28.924327020919026` ns/iter	`1.00`
`Micro_2019_09_Compile_Wrap`	`286213353.99998313` ns/iter	`282948039.9999511` ns/iter	`1.01`
`Micro_2020_12_Dynamic_Ref`	`229.8676627741364` ns/iter	`229.49894262097567` ns/iter	`1.00`
`Micro_2020_12_Dynamic_Ref_Single`	`3.430567851808452` ns/iter	`3.423271081748109` ns/iter	`1.00`
`Micro_2020_12_Simple_Output_Mask`	`66269.94708149698` ns/iter	`65716.88213213506` ns/iter	`1.01`
`Micro_2020_12_Simple_Output_Annotations`	`101846.43836831948` ns/iter	`102490.08894406505` ns/iter	`0.99`
`Micro_2020_12_Compile_NonCircular_Shared_Refs`	`1111359.3981041713` ns/iter	`1094212.464062494` ns/iter	`1.02`
`Micro_2020_12_Exhaustive_Deep_Numeric`	`8415.867605112771` ns/iter	`8778.254677377374` ns/iter	`0.96`
`Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput`	`171236.5254321064` ns/iter	`173669.42521629715` ns/iter	`0.99`
`Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput`	`22240.022877477586` ns/iter	`22233.13704794663` ns/iter	`1.00`
`Micro_2020_12_Exhaustive_Deep_Numeric_Fail`	`139.17885874427537` ns/iter	`141.20089649760055` ns/iter	`0.99`
`Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput`	`4207.75608147372` ns/iter	`4224.2717892811415` ns/iter	`1.00`
`Alterschema_Check_Readibility_ISO_Language_Set_3`	`339174658.9999798` ns/iter	`333584276.0000105` ns/iter	`1.02`
`Alterschema_Check_Readibility_OMC`	`84306527.87500037` ns/iter	`83593067.62500297` ns/iter	`1.01`
`Alterschema_Check_Readibility_KrakenD`	`1199796197.9999444` ns/iter	`1159749540.9999964` ns/iter	`1.03`
`Alterschema_Apply_Readibility_KrakenD`	`15721430076.999922` ns/iter	`15424221582.999962` ns/iter	`1.02`
`Alterschema_Check_Invalid_External_Refs`	`307661652.5000304` ns/iter	`289901693.9999797` ns/iter	`1.06`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

JavaScript (linux/llvm)

Details

Benchmark suite	Current: `7774e6b`	Previous: `45d3228`	Ratio
`E2E_Evaluator_adaptivecard`	`118630` ns	`115621` ns	`1.03`
`E2E_Evaluator_ansible-meta`	`579210` ns	`582352` ns	`0.99`
`E2E_Evaluator_aws-cdk`	`136496` ns	`136327` ns	`1.00`
`E2E_Evaluator_babelrc`	`326862` ns	`319161` ns	`1.02`
`E2E_Evaluator_cerebrum-criminal-case`	`2620250` ns	`2613646` ns	`1.00`
`E2E_Evaluator_clang-format`	`279214` ns	`271080` ns	`1.03`
`E2E_Evaluator_cmake-presets`	`19301519` ns	`19080453` ns	`1.01`
`E2E_Evaluator_code-climate`	`431572` ns	`429541` ns	`1.00`
`E2E_Evaluator_cql2`	`1182070` ns	`1177867` ns	`1.00`
`E2E_Evaluator_cspell`	`1575367` ns	`1556521` ns	`1.01`
`E2E_Evaluator_cypress`	`853124` ns	`859579` ns	`0.99`
`E2E_Evaluator_deno`	`1092556` ns	`1099185` ns	`0.99`
`E2E_Evaluator_dependabot`	`1079737` ns	`1084894` ns	`1.00`
`E2E_Evaluator_draft-04`	`19919133` ns	`20496059` ns	`0.97`
`E2E_Evaluator_fabric-mod`	`2535426` ns	`2484372` ns	`1.02`
`E2E_Evaluator_geojson`	`20893210` ns	`23375392` ns	`0.89`
`E2E_Evaluator_gitpod-configuration`	`765198` ns	`762989` ns	`1.00`
`E2E_Evaluator_helm-chart-lock`	`993386` ns	`987050` ns	`1.01`
`E2E_Evaluator_importmap`	`272224` ns	`277707` ns	`0.98`
`E2E_Evaluator_jasmine`	`292452` ns	`301371` ns	`0.97`
`E2E_Evaluator_jsconfig`	`1360650` ns	`1309854` ns	`1.04`
`E2E_Evaluator_jshintrc`	`3166231` ns	`3124385` ns	`1.01`
`E2E_Evaluator_krakend`	`778695` ns	`771225` ns	`1.01`
`E2E_Evaluator_lazygit`	`574470` ns	`572871` ns	`1.00`
`E2E_Evaluator_lerna`	`479399` ns	`474223` ns	`1.01`
`E2E_Evaluator_nest-cli`	`631122` ns	`643369` ns	`0.98`
`E2E_Evaluator_omc`	`84299` ns	`86476` ns	`0.97`
`E2E_Evaluator_omnisharp`	`1579099` ns	`1561989` ns	`1.01`
`E2E_Evaluator_openapi`	`36981116` ns	`36378737` ns	`1.02`
`E2E_Evaluator_pre-commit-hooks`	`2004489` ns	`1973031` ns	`1.02`
`E2E_Evaluator_pulumi`	`2004765` ns	`1954698` ns	`1.03`
`E2E_Evaluator_semantic-release`	`260408` ns	`259352` ns	`1.00`
`E2E_Evaluator_stale`	`433319` ns	`433425` ns	`1.00`
`E2E_Evaluator_stylecop`	`1225391` ns	`1246964` ns	`0.98`
`E2E_Evaluator_tmuxinator`	`221645` ns	`221113` ns	`1.00`
`E2E_Evaluator_ui5`	`2205858` ns	`2223723` ns	`0.99`
`E2E_Evaluator_ui5-manifest`	`11078297` ns	`11165641` ns	`0.99`
`E2E_Evaluator_unreal-engine-uproject`	`1526290` ns	`1478874` ns	`1.03`
`E2E_Evaluator_vercel`	`1065761` ns	`1057434` ns	`1.01`
`E2E_Evaluator_yamllint`	`24859` ns	`24607` ns	`1.01`

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti · 2026-04-10T18:48:31Z

augment review

jviotti · 2026-04-10T18:48:37Z

@cubic-dev-ai review

cubic-dev-ai · 2026-04-10T18:48:49Z

@cubic-dev-ai review

@jviotti I have started the AI code review. It will take a few minutes to complete.

github-actions

Benchmark (linux/gcc)

Details

Benchmark suite	Current: `7774e6b`	Previous: `45d3228`	Ratio
`Alterschema_Check_Readibility_ISO_Language_Set_3`	`346927374.50001234` ns/iter	`356463224.00003785` ns/iter	`0.97`
`Alterschema_Check_Readibility_OMC`	`95468886.57142258` ns/iter	`97028191.00000072` ns/iter	`0.98`
`Alterschema_Check_Readibility_KrakenD`	`1335124644.000075` ns/iter	`1354711880.9999573` ns/iter	`0.99`
`Alterschema_Apply_Readibility_KrakenD`	`17803046112.00006` ns/iter	`17963797666.999996` ns/iter	`0.99`
`Alterschema_Check_Invalid_External_Refs`	`346378939.0000329` ns/iter	`355911851.99996287` ns/iter	`0.97`
`Micro_2020_12_Dynamic_Ref`	`264.9055634676708` ns/iter	`258.4088165909309` ns/iter	`1.03`
`Micro_2020_12_Dynamic_Ref_Single`	`4.980976481799629` ns/iter	`4.980816948341322` ns/iter	`1.00`
`Micro_2020_12_Simple_Output_Mask`	`74354.04583289174` ns/iter	`74236.99820561282` ns/iter	`1.00`
`Micro_2020_12_Simple_Output_Annotations`	`112047.08988585095` ns/iter	`110813.96270433384` ns/iter	`1.01`
`Micro_2020_12_Compile_NonCircular_Shared_Refs`	`1223734.6451050437` ns/iter	`1206508.7979095087` ns/iter	`1.01`
`Micro_2020_12_Exhaustive_Deep_Numeric`	`8606.089594412937` ns/iter	`8530.266167639948` ns/iter	`1.01`
`Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput`	`168913.0881787609` ns/iter	`164129.7474770983` ns/iter	`1.03`
`Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput`	`25979.652198275486` ns/iter	`25787.358837201402` ns/iter	`1.01`
`Micro_2020_12_Exhaustive_Deep_Numeric_Fail`	`130.0366811429826` ns/iter	`130.2136912664216` ns/iter	`1.00`
`Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput`	`4678.801695886604` ns/iter	`4675.517229002163` ns/iter	`1.00`
`Micro_2019_09_Unevaluated_Properties`	`29.93458811165234` ns/iter	`28.68371240064528` ns/iter	`1.04`
`Micro_2019_09_Compile_Wrap`	`313236600.9999714` ns/iter	`346031834.5000246` ns/iter	`0.91`
`Micro_Draft7_If_Then_Else`	`24.64036677479305` ns/iter	`24.59719620869449` ns/iter	`1.00`
`Micro_Draft6_Property_Names`	`142.23079501463536` ns/iter	`142.70947803108038` ns/iter	`1.00`
`Micro_Draft6_Compile_FHIR`	`14727427339.999964` ns/iter	`15029305662.00007` ns/iter	`0.98`
`Micro_Draft4_Meta_1_No_Callback`	`167.83750196551` ns/iter	`168.81445629956053` ns/iter	`0.99`
`Micro_Draft4_Required_Properties`	`796.1986019880908` ns/iter	`825.4155930816062` ns/iter	`0.96`
`Micro_Draft4_Many_Optional_Properties_Minimal_Match`	`21.213404333638337` ns/iter	`20.29140142935498` ns/iter	`1.05`
`Micro_Draft4_Few_Optional_Properties_Minimal_Match`	`13.71108717675602` ns/iter	`13.088708767420426` ns/iter	`1.05`
`Micro_Draft4_Items_Schema`	`354.9154950756113` ns/iter	`325.0562439474466` ns/iter	`1.09`
`Micro_Draft4_Nested_Object`	`1.8748457507940215` ns/iter	`1.8691322185496275` ns/iter	`1.00`
`Micro_Draft4_Properties_Triad_Optional`	`409.72228703275` ns/iter	`372.59253801353185` ns/iter	`1.10`
`Micro_Draft4_Properties_Triad_Closed`	`369.5124345659915` ns/iter	`319.1242850059191` ns/iter	`1.16`
`Micro_Draft4_Properties_Triad_Required`	`455.88715345928745` ns/iter	`422.90516861312466` ns/iter	`1.08`
`Micro_Draft4_Properties_Closed`	`63.89013370061172` ns/iter	`62.65630308828547` ns/iter	`1.02`
`Micro_Draft4_Non_Recursive_Ref`	`10.295636350084985` ns/iter	`9.66295761459903` ns/iter	`1.07`
`Micro_Draft4_Pattern_Properties_True`	`225.85725767431907` ns/iter	`203.39228963889596` ns/iter	`1.11`
`Micro_Draft4_Ref_To_Single_Property`	`13.709584225117942` ns/iter	`12.78308459540379` ns/iter	`1.07`
`Micro_Draft4_Additional_Properties_Type`	`14.946048847572392` ns/iter	`15.272443958038657` ns/iter	`0.98`
`Micro_Draft4_Nested_Oneof`	`65.68270123719515` ns/iter	`64.79683916430069` ns/iter	`1.01`
`Micro_Draft4_Short_Enum`	`14.668769342973063` ns/iter	`14.653893028013464` ns/iter	`1.00`
`Micro_Draft4_Long_Enum`	`14.679941916801804` ns/iter	`13.718745083286368` ns/iter	`1.07`
`Micro_Draft4_Long_Enum_Short_Strings`	`14.707642519562294` ns/iter	`14.641687374178645` ns/iter	`1.00`
`Micro_Draft4_Type_Object`	`4.980838779191096` ns/iter	`5.006360070001392` ns/iter	`0.99`
`Micro_Draft4_Ref_Single_100`	`2528940.6137183206` ns/iter	`2542276.7689526766` ns/iter	`0.99`
`Micro_Draft4_Compile_Ref_Many_Nested`	`1829980.2114881468` ns/iter	`1838971.7289473515` ns/iter	`1.00`
`Micro_Draft4_Compile_Wrap`	`2620043.650557612` ns/iter	`2610242.197025809` ns/iter	`1.00`
`E2E_Compiler_adaptivecard`	`66428733.99999871` ns/iter	`70360564.70001313` ns/iter	`0.94`
`E2E_Compiler_ansible_meta`	`30770135.826089796` ns/iter	`30761269.999995578` ns/iter	`1.00`
`E2E_Compiler_aws_cdk`	`416859.0655542394` ns/iter	`420645.98021589546` ns/iter	`0.99`
`E2E_Compiler_babelrc`	`2806232.959999761` ns/iter	`2798945.6400000565` ns/iter	`1.00`
`E2E_Compiler_clang_format`	`19916049.48571616` ns/iter	`19753115.027773067` ns/iter	`1.01`
`E2E_Compiler_cmake_presets`	`27459746.23076983` ns/iter	`28115476.240000132` ns/iter	`0.98`
`E2E_Compiler_code_climate`	`2826452.1895164857` ns/iter	`2802356.236000378` ns/iter	`1.01`
`E2E_Compiler_cql2`	`14201013.571427934` ns/iter	`14348293.166667266` ns/iter	`0.99`
`E2E_Compiler_cspell`	`24285269.034478538` ns/iter	`24488093.571424734` ns/iter	`0.99`
`E2E_Compiler_cypress`	`4238837.715150691` ns/iter	`4279954.25766898` ns/iter	`0.99`
`E2E_Compiler_deno`	`8314207.166666253` ns/iter	`8203346.395348913` ns/iter	`1.01`
`E2E_Compiler_dependabot`	`4230509.952095869` ns/iter	`4190836.500000327` ns/iter	`1.01`
`E2E_Compiler_draft_04`	`2973083.6228815736` ns/iter	`2933821.5439333697` ns/iter	`1.01`
`E2E_Compiler_fabric_mod`	`5209306.444444169` ns/iter	`5149684.022057954` ns/iter	`1.01`
`E2E_Compiler_geojson`	`24055020.034477916` ns/iter	`24366269.827584706` ns/iter	`0.99`
`E2E_Compiler_gitpod_configuration`	`5367982.651515982` ns/iter	`5287696.954545055` ns/iter	`1.02`
`E2E_Compiler_helm_chart_lock`	`759792.3033586454` ns/iter	`750778.753747206` ns/iter	`1.01`
`E2E_Compiler_importmap`	`312660.8438894147` ns/iter	`316308.5031475338` ns/iter	`0.99`
`E2E_Compiler_jasmine`	`1483140.6271187623` ns/iter	`1487327.0680849834` ns/iter	`1.00`
`E2E_Compiler_jshintrc`	`4709721.348993927` ns/iter	`4745480.648649404` ns/iter	`0.99`
`E2E_Compiler_jsconfig`	`23314005.633331664` ns/iter	`23877587.233331118` ns/iter	`0.98`
`E2E_Compiler_krakend`	`143570131.39997435` ns/iter	`156538034.2499907` ns/iter	`0.92`
`E2E_Compiler_lazygit`	`35476039.15000082` ns/iter	`36487232.52631738` ns/iter	`0.97`
`E2E_Compiler_lerna`	`1755849.9975125617` ns/iter	`1757806.7783375601` ns/iter	`1.00`
`E2E_Compiler_nest_cli`	`8247748.579544184` ns/iter	`8061223.655172869` ns/iter	`1.02`
`E2E_Compiler_omc`	`164621250.24997932` ns/iter	`172695687.2499841` ns/iter	`0.95`
`E2E_Compiler_omnisharp`	`7284469.4693871215` ns/iter	`7225833.649483282` ns/iter	`1.01`
`E2E_Compiler_openapi`	`28470528.653848793` ns/iter	`27177421.19230374` ns/iter	`1.05`
`E2E_Compiler_pre_commit_hooks`	`5876324.4016395` ns/iter	`5766681.795082194` ns/iter	`1.02`
`E2E_Compiler_pulumi`	`4394830.835443642` ns/iter	`4399083.496855955` ns/iter	`1.00`
`E2E_Compiler_semantic_release`	`1708282.334962873` ns/iter	`1710331.7843136399` ns/iter	`1.00`
`E2E_Compiler_stale`	`1679931.8653845864` ns/iter	`1698037.186892824` ns/iter	`0.99`
`E2E_Compiler_stylecop`	`6395403.394496056` ns/iter	`6421385.545453714` ns/iter	`1.00`
`E2E_Compiler_tmuxinator`	`2118605.347432039` ns/iter	`2110755.801801794` ns/iter	`1.00`
`E2E_Compiler_ui5`	`48909983.64284574` ns/iter	`50848861.785701565` ns/iter	`0.96`
`E2E_Compiler_ui5_manifest`	`336171852.0000068` ns/iter	`343024942.0000564` ns/iter	`0.98`
`E2E_Compiler_unreal_engine_uproject`	`4948863.099290511` ns/iter	`4984658.148935439` ns/iter	`0.99`
`E2E_Compiler_vercel`	`13518557.886793545` ns/iter	`13335904.615381913` ns/iter	`1.01`
`E2E_Compiler_yamllint`	`387145.21833324194` ns/iter	`385975.0842510826` ns/iter	`1.00`
`E2E_Evaluator_adaptivecard`	`23122.79846397115` ns/iter	`23228.629233867076` ns/iter	`1.00`
`E2E_Evaluator_ansible_meta`	`251651.29070602843` ns/iter	`243972.61522415624` ns/iter	`1.03`
`E2E_Evaluator_aws_cdk`	`52012.621633850926` ns/iter	`52757.65900007941` ns/iter	`0.99`
`E2E_Evaluator_babelrc`	`106120.55531850664` ns/iter	`106210.567746797` ns/iter	`1.00`
`E2E_Evaluator_cerebrum_criminal_case`	`1331104.7790055347` ns/iter	`1248861.740601429` ns/iter	`1.07`
`E2E_Evaluator_clang_format`	`107831.48750573986` ns/iter	`106723.79851425794` ns/iter	`1.01`
`E2E_Evaluator_cmake_presets`	`4381251.187500368` ns/iter	`4667767.143836475` ns/iter	`0.94`
`E2E_Evaluator_code_climate`	`187025.66657634653` ns/iter	`183045.48661419697` ns/iter	`1.02`
`E2E_Evaluator_cql2`	`219640.87142857764` ns/iter	`212852.12733853987` ns/iter	`1.03`
`E2E_Evaluator_cspell`	`555441.256552777` ns/iter	`535646.7740682546` ns/iter	`1.04`
`E2E_Evaluator_cypress`	`176433.065590303` ns/iter	`181046.6947177322` ns/iter	`0.97`
`E2E_Evaluator_deno`	`337240.0517657872` ns/iter	`338788.0857558265` ns/iter	`1.00`
`E2E_Evaluator_dependabot`	`461575.7623436476` ns/iter	`466025.62747676694` ns/iter	`0.99`
`E2E_Evaluator_draft_04`	`6593882.304761272` ns/iter	`8102168.684783721` ns/iter	`0.81`
`E2E_Evaluator_fabric_mod`	`732882.5047022189` ns/iter	`742999.5638297423` ns/iter	`0.99`
`E2E_Evaluator_geojson`	`15971614.488371203` ns/iter	`17052771.000002004` ns/iter	`0.94`
`E2E_Evaluator_gitpod_configuration`	`254973.65762463296` ns/iter	`256898.89988876856` ns/iter	`0.99`
`E2E_Evaluator_helm_chart_lock`	`323160.9250229774` ns/iter	`319522.7309090983` ns/iter	`1.01`
`E2E_Evaluator_importmap`	`48814.893428568335` ns/iter	`48801.988144542454` ns/iter	`1.00`
`E2E_Evaluator_jasmine`	`119064.7716350196` ns/iter	`117810.75649566503` ns/iter	`1.01`
`E2E_Evaluator_jshintrc`	`1034602.4720966656` ns/iter	`1055086.6912650971` ns/iter	`0.98`
`E2E_Evaluator_jsconfig`	`417867.3040791276` ns/iter	`424577.5051547145` ns/iter	`0.98`
`E2E_Evaluator_krakend`	`214341.84151176797` ns/iter	`207036.54946358543` ns/iter	`1.04`
`E2E_Evaluator_lazygit`	`142353.40364584714` ns/iter	`135440.16350028155` ns/iter	`1.05`
`E2E_Evaluator_lerna`	`155540.83073144496` ns/iter	`159283.4740259543` ns/iter	`0.98`
`E2E_Evaluator_nest_cli`	`198256.3917233398` ns/iter	`194780.6425120569` ns/iter	`1.02`
`E2E_Evaluator_omc`	`19741.917223522803` ns/iter	`19032.689856799985` ns/iter	`1.04`
`E2E_Evaluator_omnisharp`	`578066.7896890288` ns/iter	`572782.7214651932` ns/iter	`1.01`
`E2E_Evaluator_openapi`	`13656357.235290403` ns/iter	`15984508.340910576` ns/iter	`0.85`
`E2E_Evaluator_pre_commit_hooks`	`516775.3908555253` ns/iter	`514565.39389196795` ns/iter	`1.00`
`E2E_Evaluator_pulumi`	`708871.4580776076` ns/iter	`724987.5095340994` ns/iter	`0.98`
`E2E_Evaluator_semantic_release`	`101982.4768211937` ns/iter	`101214.9609272602` ns/iter	`1.01`
`E2E_Evaluator_stale`	`155041.54273787214` ns/iter	`156780.6562429667` ns/iter	`0.99`
`E2E_Evaluator_stylecop`	`312673.25271244417` ns/iter	`319776.91670439707` ns/iter	`0.98`
`E2E_Evaluator_tmuxinator`	`106432.65962945737` ns/iter	`98796.49851632511` ns/iter	`1.08`
`E2E_Evaluator_ui5`	`539890.7644341406` ns/iter	`525839.9204893037` ns/iter	`1.03`
`E2E_Evaluator_ui5_manifest`	`2794627.630952806` ns/iter	`2789166.6745094256` ns/iter	`1.00`
`E2E_Evaluator_unreal_engine_uproject`	`461225.5274151168` ns/iter	`454822.1871727792` ns/iter	`1.01`
`E2E_Evaluator_vercel`	`316544.71128016734` ns/iter	`312928.4425934532` ns/iter	`1.01`
`E2E_Evaluator_yamllint`	`11267.558557388376` ns/iter	`10542.191764040781` ns/iter	`1.07`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

JavaScript (linux/gcc)

Details

Benchmark suite	Current: `7774e6b`	Previous: `45d3228`	Ratio
`E2E_Evaluator_adaptivecard`	`115890` ns	`116798` ns	`0.99`
`E2E_Evaluator_ansible-meta`	`599984` ns	`598869` ns	`1.00`
`E2E_Evaluator_aws-cdk`	`138016` ns	`139201` ns	`0.99`
`E2E_Evaluator_babelrc`	`326707` ns	`343376` ns	`0.95`
`E2E_Evaluator_cerebrum-criminal-case`	`2612503` ns	`2702386` ns	`0.97`
`E2E_Evaluator_clang-format`	`292261` ns	`325742` ns	`0.90`
`E2E_Evaluator_cmake-presets`	`20064359` ns	`21808778` ns	`0.92`
`E2E_Evaluator_code-climate`	`433903` ns	`438127` ns	`0.99`
`E2E_Evaluator_cql2`	`1178586` ns	`1184045` ns	`1.00`
`E2E_Evaluator_cspell`	`1626964` ns	`1630778` ns	`1.00`
`E2E_Evaluator_cypress`	`875293` ns	`901202` ns	`0.97`
`E2E_Evaluator_deno`	`1097132` ns	`1139446` ns	`0.96`
`E2E_Evaluator_dependabot`	`1086346` ns	`1156716` ns	`0.94`
`E2E_Evaluator_draft-04`	`20055385` ns	`24136838` ns	`0.83`
`E2E_Evaluator_fabric-mod`	`2531649` ns	`2608924` ns	`0.97`
`E2E_Evaluator_geojson`	`20207986` ns	`21390102` ns	`0.94`
`E2E_Evaluator_gitpod-configuration`	`762583` ns	`770170` ns	`0.99`
`E2E_Evaluator_helm-chart-lock`	`1069595` ns	`1027544` ns	`1.04`
`E2E_Evaluator_importmap`	`280431` ns	`283892` ns	`0.99`
`E2E_Evaluator_jasmine`	`294686` ns	`293523` ns	`1.00`
`E2E_Evaluator_jsconfig`	`1382885` ns	`1404336` ns	`0.98`
`E2E_Evaluator_jshintrc`	`3299942` ns	`3263973` ns	`1.01`
`E2E_Evaluator_krakend`	`779234` ns	`779099` ns	`1.00`
`E2E_Evaluator_lazygit`	`589214` ns	`580414` ns	`1.02`
`E2E_Evaluator_lerna`	`468309` ns	`483492` ns	`0.97`
`E2E_Evaluator_nest-cli`	`632566` ns	`649243` ns	`0.97`
`E2E_Evaluator_omc`	`87164` ns	`85555` ns	`1.02`
`E2E_Evaluator_omnisharp`	`1590775` ns	`1604271` ns	`0.99`
`E2E_Evaluator_openapi`	`35950119` ns	`40311632` ns	`0.89`
`E2E_Evaluator_pre-commit-hooks`	`2065580` ns	`2094223` ns	`0.99`
`E2E_Evaluator_pulumi`	`1993699` ns	`2025143` ns	`0.98`
`E2E_Evaluator_semantic-release`	`272075` ns	`269444` ns	`1.01`
`E2E_Evaluator_stale`	`436780` ns	`434041` ns	`1.01`
`E2E_Evaluator_stylecop`	`1240259` ns	`1230645` ns	`1.01`
`E2E_Evaluator_tmuxinator`	`230508` ns	`229766` ns	`1.00`
`E2E_Evaluator_ui5`	`2258490` ns	`2220658` ns	`1.02`
`E2E_Evaluator_ui5-manifest`	`11272752` ns	`12184265` ns	`0.93`
`E2E_Evaluator_unreal-engine-uproject`	`1528088` ns	`1521855` ns	`1.00`
`E2E_Evaluator_vercel`	`1064785` ns	`1088580` ns	`0.98`
`E2E_Evaluator_yamllint`	`25353` ns	`24845` ns	`1.02`

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

augmentcode

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

cubic-dev-ai

No issues found across 4 files

github-actions

Benchmark (macos/llvm)

Details

Benchmark suite	Current: `7774e6b`	Previous: `45d3228`	Ratio
`E2E_Compiler_adaptivecard`	`104199999.99999164` ns/iter	`53067480.76922163` ns/iter	`1.96`
`E2E_Compiler_ansible_meta`	`31859206.249998808` ns/iter	`22106608.093743317` ns/iter	`1.44`
`E2E_Compiler_aws_cdk`	`410608.40517242544` ns/iter	`254068.92185238824` ns/iter	`1.62`
`E2E_Compiler_babelrc`	`2709571.3238436817` ns/iter	`1945718.9265533427` ns/iter	`1.39`
`E2E_Compiler_clang_format`	`22805569.452381343` ns/iter	`13473607.365382962` ns/iter	`1.69`
`E2E_Compiler_cmake_presets`	`48166817.307691626` ns/iter	`22289395.16128541` ns/iter	`2.16`
`E2E_Compiler_code_climate`	`3593624.788659772` ns/iter	`1963870.9044942658` ns/iter	`1.83`
`E2E_Compiler_cql2`	`18522592.468748655` ns/iter	`10240552.088235103` ns/iter	`1.81`
`E2E_Compiler_cspell`	`27151448.360000357` ns/iter	`17353315.625001643` ns/iter	`1.56`
`E2E_Compiler_cypress`	`5383499.169998913` ns/iter	`3621741.999999624` ns/iter	`1.49`
`E2E_Compiler_deno`	`12330007.97058741` ns/iter	`5989694.078948559` ns/iter	`2.06`
`E2E_Compiler_dependabot`	`4907142.066265378` ns/iter	`3661111.6898149657` ns/iter	`1.34`
`E2E_Compiler_draft_04`	`3316121.530303056` ns/iter	`1886082.8363094535` ns/iter	`1.76`
`E2E_Compiler_fabric_mod`	`5380445.829999872` ns/iter	`3740707.5074619865` ns/iter	`1.44`
`E2E_Compiler_geojson`	`30014109.37499808` ns/iter	`20548666.685713865` ns/iter	`1.46`
`E2E_Compiler_gitpod_configuration`	`5877390.839999634` ns/iter	`3688700.873684818` ns/iter	`1.59`
`E2E_Compiler_helm_chart_lock`	`743949.4317376305` ns/iter	`484502.330832143` ns/iter	`1.54`
`E2E_Compiler_importmap`	`364915.57462970883` ns/iter	`189888.45471701914` ns/iter	`1.92`
`E2E_Compiler_jasmine`	`1294935.861423117` ns/iter	`982829.493810038` ns/iter	`1.32`
`E2E_Compiler_jshintrc`	`4212298.870370124` ns/iter	`2902965.425532107` ns/iter	`1.45`
`E2E_Compiler_jsconfig`	`25595005.354841392` ns/iter	`19876057.000003226` ns/iter	`1.29`
`E2E_Compiler_krakend`	`186455979.24998468` ns/iter	`114609149.9999784` ns/iter	`1.63`
`E2E_Compiler_lazygit`	`44502186.2941196` ns/iter	`30109628.818184897` ns/iter	`1.48`
`E2E_Compiler_lerna`	`1699558.7729356696` ns/iter	`1199966.869791464` ns/iter	`1.42`
`E2E_Compiler_nest_cli`	`7814861.559139783` ns/iter	`5596167.999998216` ns/iter	`1.40`
`E2E_Compiler_omc`	`248436180.6666584` ns/iter	`151078683.40001005` ns/iter	`1.64`
`E2E_Compiler_omnisharp`	`7886043.032966642` ns/iter	`5710244.918699522` ns/iter	`1.38`
`E2E_Compiler_openapi`	`34889632.70370749` ns/iter	`19173261.91428401` ns/iter	`1.82`
`E2E_Compiler_pre_commit_hooks`	`5744874.159998971` ns/iter	`3757611.5591396196` ns/iter	`1.53`
`E2E_Compiler_pulumi`	`5021534.937888861` ns/iter	`2965385.151260269` ns/iter	`1.69`
`E2E_Compiler_semantic_release`	`1506970.6325302704` ns/iter	`1109117.1426308143` ns/iter	`1.36`
`E2E_Compiler_stale`	`1364098.4149908114` ns/iter	`1129411.4760382252` ns/iter	`1.21`
`E2E_Compiler_stylecop`	`6856445.000000349` ns/iter	`5190842.500001054` ns/iter	`1.32`
`E2E_Compiler_tmuxinator`	`1751879.9583332418` ns/iter	`1559932.0090907232` ns/iter	`1.12`
`E2E_Compiler_ui5`	`78353391.69999997` ns/iter	`53487158.40000296` ns/iter	`1.46`
`E2E_Compiler_ui5_manifest`	`385581687.49995047` ns/iter	`267846221.99996495` ns/iter	`1.44`
`E2E_Compiler_unreal_engine_uproject`	`4731761.236842515` ns/iter	`3346477.859903806` ns/iter	`1.41`
`E2E_Compiler_vercel`	`18252277.454546507` ns/iter	`10615876.312503047` ns/iter	`1.72`
`E2E_Compiler_yamllint`	`273882.7947200982` ns/iter	`228793.96112729647` ns/iter	`1.20`
`E2E_Evaluator_adaptivecard`	`20626.614088469723` ns/iter	`16990.686914170652` ns/iter	`1.21`
`E2E_Evaluator_ansible_meta`	`207293.41509435352` ns/iter	`148278.00084531392` ns/iter	`1.40`
`E2E_Evaluator_aws_cdk`	`45340.58748527723` ns/iter	`34146.84123484852` ns/iter	`1.33`
`E2E_Evaluator_babelrc`	`98882.32989159081` ns/iter	`76241.60642866146` ns/iter	`1.30`
`E2E_Evaluator_cerebrum_criminal_case`	`1161308.6268656598` ns/iter	`781838.6225166066` ns/iter	`1.49`
`E2E_Evaluator_clang_format`	`112107.7241131791` ns/iter	`91769.89288447263` ns/iter	`1.22`
`E2E_Evaluator_cmake_presets`	`3792495.7282053255` ns/iter	`2902048.1729957233` ns/iter	`1.31`
`E2E_Evaluator_code_climate`	`231282.29827049354` ns/iter	`109671.3880131285` ns/iter	`2.11`
`E2E_Evaluator_cql2`	`233724.62667112818` ns/iter	`131161.42322096255` ns/iter	`1.78`
`E2E_Evaluator_cspell`	`592808.6335160576` ns/iter	`346476.7221939773` ns/iter	`1.71`
`E2E_Evaluator_cypress`	`184478.2527597151` ns/iter	`125059.44212592235` ns/iter	`1.48`
`E2E_Evaluator_deno`	`318065.889673101` ns/iter	`196140.29105733917` ns/iter	`1.62`
`E2E_Evaluator_dependabot`	`332848.28610500705` ns/iter	`289488.4731488824` ns/iter	`1.15`
`E2E_Evaluator_draft_04`	`5934606.634407642` ns/iter	`4825299.1654679645` ns/iter	`1.23`
`E2E_Evaluator_fabric_mod`	`589900.8894009243` ns/iter	`445236.51748248603` ns/iter	`1.32`
`E2E_Evaluator_geojson`	`19513574.764707357` ns/iter	`10380705.645161469` ns/iter	`1.88`
`E2E_Evaluator_gitpod_configuration`	`182606.59231948457` ns/iter	`152383.25214768064` ns/iter	`1.20`
`E2E_Evaluator_helm_chart_lock`	`255238.06456407267` ns/iter	`184150.14722913646` ns/iter	`1.39`
`E2E_Evaluator_importmap`	`36618.035812072114` ns/iter	`28240.594042622874` ns/iter	`1.30`
`E2E_Evaluator_jasmine`	`92913.3667883255` ns/iter	`73020.37757866483` ns/iter	`1.27`
`E2E_Evaluator_jshintrc`	`1145923.2300887732` ns/iter	`842301.4705881559` ns/iter	`1.36`
`E2E_Evaluator_jsconfig`	`315110.96352578246` ns/iter	`275277.2858360899` ns/iter	`1.14`
`E2E_Evaluator_krakend`	`185827.33139052597` ns/iter	`115959.86295681441` ns/iter	`1.60`
`E2E_Evaluator_lazygit`	`128860.46005281502` ns/iter	`84833.28145201529` ns/iter	`1.52`
`E2E_Evaluator_lerna`	`131038.21437297962` ns/iter	`102217.02920356604` ns/iter	`1.28`
`E2E_Evaluator_nest_cli`	`127486.49424446277` ns/iter	`121914.30569865048` ns/iter	`1.05`
`E2E_Evaluator_omc`	`15521.488653343657` ns/iter	`13206.227981598615` ns/iter	`1.18`
`E2E_Evaluator_omnisharp`	`426039.5705173055` ns/iter	`389885.76621922053` ns/iter	`1.09`
`E2E_Evaluator_openapi`	`8573891.06024228` ns/iter	`7176227.311111284` ns/iter	`1.19`
`E2E_Evaluator_pre_commit_hooks`	`339824.5043145396` ns/iter	`309017.0389036391` ns/iter	`1.10`
`E2E_Evaluator_pulumi`	`534252.278890606` ns/iter	`464253.1676412944` ns/iter	`1.15`
`E2E_Evaluator_semantic_release`	`80327.79935019213` ns/iter	`64744.581192737576` ns/iter	`1.24`
`E2E_Evaluator_stale`	`109347.61587848267` ns/iter	`103141.39388673783` ns/iter	`1.06`
`E2E_Evaluator_stylecop`	`183176.29434645266` ns/iter	`167526.5989785913` ns/iter	`1.09`
`E2E_Evaluator_tmuxinator`	`69195.02131245118` ns/iter	`64566.405978959214` ns/iter	`1.07`
`E2E_Evaluator_ui5`	`327608.3374060832` ns/iter	`301373.11665947526` ns/iter	`1.09`
`E2E_Evaluator_ui5_manifest`	`1605955.337078505` ns/iter	`1866724.6883633484` ns/iter	`0.86`
`E2E_Evaluator_unreal_engine_uproject`	`310676.0355731168` ns/iter	`322398.3570377564` ns/iter	`0.96`
`E2E_Evaluator_vercel`	`223152.23628551885` ns/iter	`221798.240787159` ns/iter	`1.01`
`E2E_Evaluator_yamllint`	`5629.231611692922` ns/iter	`7118.374985058163` ns/iter	`0.79`
`Micro_Draft4_Meta_1_No_Callback`	`131.0409266646186` ns/iter	`173.16917366760083` ns/iter	`0.76`
`Micro_Draft4_Required_Properties`	`610.1404949383358` ns/iter	`671.2502974559584` ns/iter	`0.91`
`Micro_Draft4_Many_Optional_Properties_Minimal_Match`	`15.632946733210991` ns/iter	`16.63478213426328` ns/iter	`0.94`
`Micro_Draft4_Few_Optional_Properties_Minimal_Match`	`6.935311377956692` ns/iter	`7.548474156798089` ns/iter	`0.92`
`Micro_Draft4_Items_Schema`	`249.7112186267121` ns/iter	`280.78674740643316` ns/iter	`0.89`
`Micro_Draft4_Nested_Object`	`0.6819037188597789` ns/iter	`0.6983652118835404` ns/iter	`0.98`
`Micro_Draft4_Properties_Triad_Optional`	`202.33979039868666` ns/iter	`197.60499785391232` ns/iter	`1.02`
`Micro_Draft4_Properties_Triad_Closed`	`161.19557739722495` ns/iter	`160.03867980891107` ns/iter	`1.01`
`Micro_Draft4_Properties_Triad_Required`	`214.862677306883` ns/iter	`204.88300275179208` ns/iter	`1.05`
`Micro_Draft4_Properties_Closed`	`40.85364635801521` ns/iter	`35.89519512323078` ns/iter	`1.14`
`Micro_Draft4_Non_Recursive_Ref`	`13.633786590572559` ns/iter	`12.877321506185485` ns/iter	`1.06`
`Micro_Draft4_Pattern_Properties_True`	`139.40234855659597` ns/iter	`144.81005882342004` ns/iter	`0.96`
`Micro_Draft4_Ref_To_Single_Property`	`7.3706469828247885` ns/iter	`7.261963438659872` ns/iter	`1.01`
`Micro_Draft4_Additional_Properties_Type`	`24.986767043744337` ns/iter	`30.735459709417437` ns/iter	`0.81`
`Micro_Draft4_Nested_Oneof`	`39.338586007199936` ns/iter	`41.831780343309504` ns/iter	`0.94`
`Micro_Draft4_Short_Enum`	`5.618470298969779` ns/iter	`4.924862936185266` ns/iter	`1.14`
`Micro_Draft4_Long_Enum`	`12.411700107824467` ns/iter	`10.720115104132026` ns/iter	`1.16`
`Micro_Draft4_Long_Enum_Short_Strings`	`7.427505198414299` ns/iter	`6.224003711357756` ns/iter	`1.19`
`Micro_Draft4_Type_Object`	`2.345495539435968` ns/iter	`2.03361294138991` ns/iter	`1.15`
`Micro_Draft4_Ref_Single_100`	`1867374.2150539393` ns/iter	`1644189.8034399387` ns/iter	`1.14`
`Micro_Draft4_Compile_Ref_Many_Nested`	`1605840.6103648446` ns/iter	`1256128.3475410254` ns/iter	`1.28`
`Micro_Draft4_Compile_Wrap`	`2617947.6851851814` ns/iter	`2004871.9028571732` ns/iter	`1.31`
`Micro_Draft6_Property_Names`	`107.11672467611429` ns/iter	`95.22944248146726` ns/iter	`1.12`
`Micro_Draft6_Compile_FHIR`	`10604128917.000025` ns/iter	`11653961250.000065` ns/iter	`0.91`
`Micro_Draft7_If_Then_Else`	`19.13242002493625` ns/iter	`17.538872926841115` ns/iter	`1.09`
`Micro_2019_09_Unevaluated_Properties`	`26.384346346383094` ns/iter	`26.517486244318967` ns/iter	`0.99`
`Micro_2019_09_Compile_Wrap`	`488846021.0000858` ns/iter	`358943208.5000226` ns/iter	`1.36`
`Micro_2020_12_Dynamic_Ref`	`253.6321420083444` ns/iter	`189.4264964500563` ns/iter	`1.34`
`Micro_2020_12_Dynamic_Ref_Single`	`2.546930614749938` ns/iter	`2.2500709527658658` ns/iter	`1.13`
`Micro_2020_12_Simple_Output_Mask`	`61894.45621595347` ns/iter	`75577.56996967587` ns/iter	`0.82`
`Micro_2020_12_Simple_Output_Annotations`	`81467.1957598945` ns/iter	`96146.29032258043` ns/iter	`0.85`
`Micro_2020_12_Compile_NonCircular_Shared_Refs`	`785404.6788793311` ns/iter	`812691.1942097548` ns/iter	`0.97`
`Micro_2020_12_Exhaustive_Deep_Numeric`	`4935.231046724967` ns/iter	`5243.7520762466565` ns/iter	`0.94`
`Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput`	`112810.57199014879` ns/iter	`112749.97884223393` ns/iter	`1.00`
`Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput`	`14108.64940858106` ns/iter	`15284.72035343633` ns/iter	`0.92`
`Micro_2020_12_Exhaustive_Deep_Numeric_Fail`	`92.47465941473227` ns/iter	`90.58714868353236` ns/iter	`1.02`
`Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput`	`5143.453874135905` ns/iter	`4507.061619439635` ns/iter	`1.14`
`Alterschema_Check_Readibility_ISO_Language_Set_3`	`250295610.9999559` ns/iter	`234960458.3332621` ns/iter	`1.07`
`Alterschema_Check_Readibility_OMC`	`65267491.7000013` ns/iter	`54140825.81817389` ns/iter	`1.21`
`Alterschema_Check_Readibility_KrakenD`	`731210667.0001413` ns/iter	`547893250.0000155` ns/iter	`1.33`
`Alterschema_Apply_Readibility_KrakenD`	`11371425793.0003` ns/iter	`8061487667.000165` ns/iter	`1.41`
`Alterschema_Check_Invalid_External_Refs`	`193249833.33338726` ns/iter	`168837562.50001624` ns/iter	`1.14`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

JavaScript (macos/llvm)

Details

Benchmark suite	Current: `7774e6b`	Previous: `45d3228`	Ratio
`E2E_Evaluator_adaptivecard`	`98188` ns	`105089` ns	`0.93`
`E2E_Evaluator_ansible-meta`	`477723` ns	`410207` ns	`1.16`
`E2E_Evaluator_aws-cdk`	`114163` ns	`119680` ns	`0.95`
`E2E_Evaluator_babelrc`	`313555` ns	`328134` ns	`0.96`
`E2E_Evaluator_cerebrum-criminal-case`	`1898802` ns	`2253641` ns	`0.84`
`E2E_Evaluator_clang-format`	`267598` ns	`237503` ns	`1.13`
`E2E_Evaluator_cmake-presets`	`13857821` ns	`13311953` ns	`1.04`
`E2E_Evaluator_code-climate`	`393610` ns	`384346` ns	`1.02`
`E2E_Evaluator_cql2`	`907073` ns	`892371` ns	`1.02`
`E2E_Evaluator_cspell`	`1446964` ns	`1497679` ns	`0.97`
`E2E_Evaluator_cypress`	`864305` ns	`690378` ns	`1.25`
`E2E_Evaluator_deno`	`746969` ns	`1039798` ns	`0.72`
`E2E_Evaluator_dependabot`	`812146` ns	`980867` ns	`0.83`
`E2E_Evaluator_draft-04`	`14386865` ns	`14830435` ns	`0.97`
`E2E_Evaluator_fabric-mod`	`1810547` ns	`1692486` ns	`1.07`
`E2E_Evaluator_geojson`	`22450433` ns	`21584414` ns	`1.04`
`E2E_Evaluator_gitpod-configuration`	`699148` ns	`679690` ns	`1.03`
`E2E_Evaluator_helm-chart-lock`	`1063625` ns	`1044941` ns	`1.02`
`E2E_Evaluator_importmap`	`223423` ns	`239815` ns	`0.93`
`E2E_Evaluator_jasmine`	`267346` ns	`312570` ns	`0.86`
`E2E_Evaluator_jsconfig`	`1244682` ns	`1400978` ns	`0.89`
`E2E_Evaluator_jshintrc`	`2659880` ns	`2404108` ns	`1.11`
`E2E_Evaluator_krakend`	`476068` ns	`452852` ns	`1.05`
`E2E_Evaluator_lazygit`	`363923` ns	`348504` ns	`1.04`
`E2E_Evaluator_lerna`	`374120` ns	`397991` ns	`0.94`
`E2E_Evaluator_nest-cli`	`612012` ns	`545687` ns	`1.12`
`E2E_Evaluator_omc`	`69506` ns	`79604` ns	`0.87`
`E2E_Evaluator_omnisharp`	`1345180` ns	`1323885` ns	`1.02`
`E2E_Evaluator_openapi`	`28181167` ns	`24751475` ns	`1.14`
`E2E_Evaluator_pre-commit-hooks`	`1680931` ns	`1547546` ns	`1.09`
`E2E_Evaluator_pulumi`	`2001408` ns	`1743869` ns	`1.15`
`E2E_Evaluator_semantic-release`	`255973` ns	`291471` ns	`0.88`
`E2E_Evaluator_stale`	`480095` ns	`400155` ns	`1.20`
`E2E_Evaluator_stylecop`	`937519` ns	`953413` ns	`0.98`
`E2E_Evaluator_tmuxinator`	`254225` ns	`208252` ns	`1.22`
`E2E_Evaluator_ui5`	`1926943` ns	`1731165` ns	`1.11`
`E2E_Evaluator_ui5-manifest`	`9498046` ns	`7389136` ns	`1.29`
`E2E_Evaluator_unreal-engine-uproject`	`1754689` ns	`1408562` ns	`1.25`
`E2E_Evaluator_vercel`	`1021021` ns	`919868` ns	`1.11`
`E2E_Evaluator_yamllint`	`30350` ns	`27501` ns	`1.10`

This comment was automatically generated by workflow using github-action-benchmark.

Implement rereference for type_array_to_any_of

35497e6

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai bot reviewed Apr 10, 2026

View reviewed changes

src/alterschema/canonicalizer/type_array_to_any_of.h Outdated Show resolved Hide resolved

augmentcode bot reviewed Apr 10, 2026

View reviewed changes

More

88f9067

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti commented Apr 10, 2026

View reviewed changes

cubic-dev-ai bot reviewed Apr 10, 2026

View reviewed changes

test/alterschema/alterschema_canonicalize_2020_12_test.cc Show resolved Hide resolved

github-actions bot reviewed Apr 10, 2026

View reviewed changes

jviotti added 2 commits April 10, 2026 14:45

Better

65bb522

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

More

80fcce4

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

github-actions bot reviewed Apr 10, 2026

View reviewed changes

Simple

7774e6b

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

augmentcode bot reviewed Apr 10, 2026

View reviewed changes

cubic-dev-ai bot reviewed Apr 10, 2026

View reviewed changes

github-actions bot reviewed Apr 10, 2026

View reviewed changes

jviotti merged commit 4de41bc into main Apr 10, 2026
14 checks passed

jviotti deleted the fix-bug-3 branch April 10, 2026 18:59

Uh oh!

Conversation

jviotti commented Apr 10, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

augmentcode bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jviotti Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark (linux/llvm)

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

JavaScript (linux/llvm)

Uh oh!

jviotti commented Apr 10, 2026

Uh oh!

jviotti commented Apr 10, 2026

Uh oh!

cubic-dev-ai bot commented Apr 10, 2026

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark (linux/gcc)

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

JavaScript (linux/gcc)

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark (macos/llvm)

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

JavaScript (macos/llvm)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

augmentcode bot commented Apr 10, 2026 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading