Fix a few canonicalizer Draft 4 bugs

[jviotti]

No description provided.

[cubic-dev-ai]

2 issues found across 9 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/alterschema/canonicalizer/next/exclusive_minimum_boolean_integer_fold.h">

<violation number="1" location="src/alterschema/canonicalizer/next/exclusive_minimum_boolean_integer_fold.h:39">
P2: Use floor(minimum) + 1 for the non-integer path; ceil keeps integral reals (e.g., 1.0) at the same value, so exclusiveMinimum can be violated.</violation>
</file>

<file name="src/alterschema/canonicalizer/next/exclusive_maximum_boolean_integer_fold.h">

<violation number="1" location="src/alterschema/canonicalizer/next/exclusive_maximum_boolean_integer_fold.h:34">
P2: Use `is_integral()` here so real/decimal values like `5.0` are treated as integral and decremented. Otherwise `exclusiveMaximum` with `maximum: 5.0` keeps `maximum` at 5 and allows the value 5.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[augmentcode]

🤖 Augment PR Summary

Summary: This PR fixes several Draft-04 canonicalizer issues around numeric bounds, dependency normalization, and reference rebasing.

Changes:

• Adds a new “next” Draft-04 rule (UnsatisfiableExclusiveEqualBounds) to collapse schemas to false when minimum == maximum and either boolean exclusivity flag is true
• Extends ExclusiveBoundsFalseDrop to also drop boolean exclusivity flags set to false for type: "number"
• Improves Draft-04 integer folding for boolean exclusiveMinimum/exclusiveMaximum when bounds are expressed as integers, decimals, or reals (including exponential inputs)
• Adjusts DependenciesToAnyOf to emit dependency constraints as allOf of per-entry anyOf wrappers, avoiding incorrect interaction with pre-existing anyOf
• Fixes TypeWithApplicatorToAllOf reference rebasing by computing the correct typed-branch index via std::popcount
• Prevents EqualNumericBoundsToEnum from firing when exclusivity would make equal bounds unsatisfiable
• Adds extensive Draft-04 tests covering the above cases (non-integral bounds, integral reals like 10.0, exponential notation, dependencies with existing applicators, and satisfiable-via-non-numbers edge cases)

Technical Notes: The “next” canonicalizer pipeline now has broader numeric normalization coverage and more targeted unsatisfiability detection while preserving correct semantics when type is not explicitly numeric.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[github-actions]

Benchmark (linux/llvm)

Details

Benchmark suite	Current: f929ed5	Previous: bc102d2	Ratio
E2E_Compiler_adaptivecard	70469693.5555565 ns/iter	63880972.11111522 ns/iter	1.10
E2E_Compiler_ansible_meta	29591131.181818627 ns/iter	29652922.695652746 ns/iter	1.00
E2E_Compiler_aws_cdk	379210.02336954966 ns/iter	361759.65051546245 ns/iter	1.05
E2E_Compiler_babelrc	2590463.6148147294 ns/iter	2546085.1163635114 ns/iter	1.02
E2E_Compiler_clang_format	19005889.39473604 ns/iter	18331724.36842215 ns/iter	1.04
E2E_Compiler_cmake_presets	27681253.8750022 ns/iter	25899340.703703005 ns/iter	1.07
E2E_Compiler_code_climate	2590833.0294117914 ns/iter	2595709.197026181 ns/iter	1.00
E2E_Compiler_cql2	13001531.055554895 ns/iter	12990364.851851331 ns/iter	1.00
E2E_Compiler_cspell	23133377.466666616 ns/iter	22816886.48387107 ns/iter	1.01
E2E_Compiler_cypress	3929593.6853931653 ns/iter	3886166.1722219447 ns/iter	1.01
E2E_Compiler_deno	7724538.48351658 ns/iter	7719404.846153753 ns/iter	1.00
E2E_Compiler_dependabot	3934396.5786518594 ns/iter	3898149.8379885713 ns/iter	1.01
E2E_Compiler_draft_04	2687777.459769935 ns/iter	2648559.366037879 ns/iter	1.01
E2E_Compiler_fabric_mod	4769464.054794681 ns/iter	4739885.425675692 ns/iter	1.01
E2E_Compiler_geojson	22353979.51612904 ns/iter	22334051.00000049 ns/iter	1.00
E2E_Compiler_gitpod_configuration	4909587.8601398235 ns/iter	4904827.433566421 ns/iter	1.00
E2E_Compiler_helm_chart_lock	711895.6321138318 ns/iter	676473.9873294171 ns/iter	1.05
E2E_Compiler_importmap	287640.35670102417 ns/iter	272709.2177136262 ns/iter	1.05
E2E_Compiler_jasmine	1365616.8320312912 ns/iter	1337159.562977026 ns/iter	1.02
E2E_Compiler_jshintrc	4345480.843749883 ns/iter	4305872.184048883 ns/iter	1.01
E2E_Compiler_jsconfig	21990703.718749672 ns/iter	21729080.81249858 ns/iter	1.01
E2E_Compiler_krakend	151768003.40000227 ns/iter	136596252.39999968 ns/iter	1.11
E2E_Compiler_lazygit	34645153.20000032 ns/iter	33725159.23809618 ns/iter	1.03
E2E_Compiler_lerna	1602035.1552510958 ns/iter	1557906.7866667628 ns/iter	1.03
E2E_Compiler_nest_cli	7487946.840425825 ns/iter	7635249.117021565 ns/iter	0.98
E2E_Compiler_omc	171926348.24999687 ns/iter	160069928.75000492 ns/iter	1.07
E2E_Compiler_omnisharp	6764946.634615509 ns/iter	6661567.009523748 ns/iter	1.02
E2E_Compiler_openapi	25294580.32142884 ns/iter	25002411.178572208 ns/iter	1.01
E2E_Compiler_pre_commit_hooks	5327370.992366461 ns/iter	5391603.348484889 ns/iter	0.99
E2E_Compiler_pulumi	4054171.0595237967 ns/iter	4006517.8971430473 ns/iter	1.01
E2E_Compiler_semantic_release	1593137.7882883002 ns/iter	1555629.9466666386 ns/iter	1.02
E2E_Compiler_stale	1555566.2276785907 ns/iter	1531181.2592592672 ns/iter	1.02
E2E_Compiler_stylecop	6199830.087719024 ns/iter	6244048.678571598 ns/iter	0.99
E2E_Compiler_tmuxinator	1937285.1333332935 ns/iter	1898674.970189664 ns/iter	1.02
E2E_Compiler_ui5	50277543.35714413 ns/iter	53800241.42857158 ns/iter	0.93
E2E_Compiler_ui5_manifest	349934110.00002086 ns/iter	318395605.0000063 ns/iter	1.10
E2E_Compiler_unreal_engine_uproject	4637304.443708552 ns/iter	4567088.019607775 ns/iter	1.02
E2E_Compiler_vercel	12567398.76785673 ns/iter	12492535.43859627 ns/iter	1.01
E2E_Compiler_yamllint	352327.53222557995 ns/iter	332584.9947693744 ns/iter	1.06
E2E_Evaluator_adaptivecard	24787.922719473303 ns/iter	24181.166182773683 ns/iter	1.03
E2E_Evaluator_ansible_meta	232156.29983361845 ns/iter	202788.75050360628 ns/iter	1.14
E2E_Evaluator_aws_cdk	51354.13654993958 ns/iter	42418.51655916807 ns/iter	1.21
E2E_Evaluator_babelrc	116111.51845017822 ns/iter	84613.48354862654 ns/iter	1.37
E2E_Evaluator_cerebrum_criminal_case	1252746.307692251 ns/iter	1287148.2446042786 ns/iter	0.97
E2E_Evaluator_clang_format	124084.27629485328 ns/iter	121323.9112284894 ns/iter	1.02
E2E_Evaluator_cmake_presets	5231266.402984656 ns/iter	4189956.6011905232 ns/iter	1.25
E2E_Evaluator_code_climate	177791.9319041514 ns/iter	147391.3768919169 ns/iter	1.21
E2E_Evaluator_cql2	207747.99550496225 ns/iter	183211.30059448164 ns/iter	1.13
E2E_Evaluator_cspell	563020.8541329321 ns/iter	558392.2982157964 ns/iter	1.01
E2E_Evaluator_cypress	192625.37053204002 ns/iter	164926.56685499565 ns/iter	1.17
E2E_Evaluator_deno	314086.6887298555 ns/iter	254796.06301175323 ns/iter	1.23
E2E_Evaluator_dependabot	421593.10944978474 ns/iter	399562.0205128125 ns/iter	1.06
E2E_Evaluator_draft_04	8972549.670885844 ns/iter	6939955.31313166 ns/iter	1.29
E2E_Evaluator_fabric_mod	721361.4509202498 ns/iter	661807.7029328089 ns/iter	1.09
E2E_Evaluator_geojson	16404383.363635588 ns/iter	15167251.32608683 ns/iter	1.08
E2E_Evaluator_gitpod_configuration	230285.57867188728 ns/iter	203242.67448513032 ns/iter	1.13
E2E_Evaluator_helm_chart_lock	369955.07084914256 ns/iter	244094.55225988108 ns/iter	1.52
E2E_Evaluator_importmap	48616.08369895152 ns/iter	43378.77246093566 ns/iter	1.12
E2E_Evaluator_jasmine	123920.87810383136 ns/iter	103706.29776606403 ns/iter	1.19
E2E_Evaluator_jshintrc	1204211.5215146495 ns/iter	1159962.5498338672 ns/iter	1.04
E2E_Evaluator_jsconfig	435700.8359326534 ns/iter	403447.9632183966 ns/iter	1.08
E2E_Evaluator_krakend	211693.8328411385 ns/iter	178481.33027523136 ns/iter	1.19
E2E_Evaluator_lazygit	149106.48041499316 ns/iter	122116.05015784272 ns/iter	1.22
E2E_Evaluator_lerna	145945.47391303838 ns/iter	111513.02335252344 ns/iter	1.31
E2E_Evaluator_nest_cli	184207.00715609762 ns/iter	183625.4196878652 ns/iter	1.00
E2E_Evaluator_omc	19966.882411600942 ns/iter	18488.443139123065 ns/iter	1.08
E2E_Evaluator_omnisharp	612356.1755320013 ns/iter	561279.863379157 ns/iter	1.09
E2E_Evaluator_openapi	15946546.909090517 ns/iter	13736709.260000452 ns/iter	1.16
E2E_Evaluator_pre_commit_hooks	474530.63887019735 ns/iter	468716.5220883579 ns/iter	1.01
E2E_Evaluator_pulumi	717835.3212810486 ns/iter	690657.1923077038 ns/iter	1.04
E2E_Evaluator_semantic_release	103261.37533934484 ns/iter	79429.96520750683 ns/iter	1.30
E2E_Evaluator_stale	150774.70061925103 ns/iter	144360.207624514 ns/iter	1.04
E2E_Evaluator_stylecop	285556.0696435908 ns/iter	259638.40817077772 ns/iter	1.10
E2E_Evaluator_tmuxinator	98811.16908483367 ns/iter	81978.77486971888 ns/iter	1.21
E2E_Evaluator_ui5	508490.50739645184 ns/iter	461126.70808281284 ns/iter	1.10
E2E_Evaluator_ui5_manifest	3035467.9919675076 ns/iter	2348334.4478113055 ns/iter	1.29
E2E_Evaluator_unreal_engine_uproject	431634.683180467 ns/iter	411612.44067797926 ns/iter	1.05
E2E_Evaluator_vercel	324205.774770606 ns/iter	250712.1588107325 ns/iter	1.29
E2E_Evaluator_yamllint	9026.055376095503 ns/iter	8113.938438839465 ns/iter	1.11
Micro_Draft4_Meta_1_No_Callback	197.21370071995398 ns/iter	195.62587322043487 ns/iter	1.01
Micro_Draft4_Required_Properties	798.4762999017405 ns/iter	863.2287909126907 ns/iter	0.92
Micro_Draft4_Many_Optional_Properties_Minimal_Match	22.74352779570511 ns/iter	23.840161697698267 ns/iter	0.95
Micro_Draft4_Few_Optional_Properties_Minimal_Match	10.909900414925524 ns/iter	10.641540136182764 ns/iter	1.03
Micro_Draft4_Items_Schema	287.4414911556292 ns/iter	282.6496187244844 ns/iter	1.02
Micro_Draft4_Nested_Object	1.775585294883237 ns/iter	1.4109634186316728 ns/iter	1.26
Micro_Draft4_Properties_Triad_Optional	326.974518652332 ns/iter	318.59460222772015 ns/iter	1.03
Micro_Draft4_Properties_Triad_Closed	269.758870902763 ns/iter	262.3067420455038 ns/iter	1.03
Micro_Draft4_Properties_Triad_Required	337.61738462221894 ns/iter	331.3471353273347 ns/iter	1.02
Micro_Draft4_Properties_Closed	54.102092537653675 ns/iter	59.84790272012286 ns/iter	0.90
Micro_Draft4_Non_Recursive_Ref	11.695411760009852 ns/iter	12.294552906135161 ns/iter	0.95
Micro_Draft4_Pattern_Properties_True	162.41679502196186 ns/iter	151.6250607814036 ns/iter	1.07
Micro_Draft4_Ref_To_Single_Property	10.913257419281644 ns/iter	10.636819346752075 ns/iter	1.03
Micro_Draft4_Additional_Properties_Type	21.657001895595872 ns/iter	23.728865653606036 ns/iter	0.91
Micro_Draft4_Nested_Oneof	57.44665756857533 ns/iter	54.265674875100785 ns/iter	1.06
Micro_Draft4_Short_Enum	14.298130839672018 ns/iter	13.710197179097445 ns/iter	1.04
Micro_Draft4_Long_Enum	14.03295404809082 ns/iter	14.071779396301523 ns/iter	1.00
Micro_Draft4_Long_Enum_Short_Strings	14.10354194713937 ns/iter	13.712459035761183 ns/iter	1.03
Micro_Draft4_Type_Object	3.4269806659709188 ns/iter	3.519999272560783 ns/iter	0.97
Micro_Draft4_Ref_Single_100	2407405.9484539554 ns/iter	2317740.9042904004 ns/iter	1.04
Micro_Draft4_Compile_Ref_Many_Nested	1733016.4197531946 ns/iter	1694683.883777303 ns/iter	1.02
Micro_Draft4_Compile_Wrap	2446118.397959448 ns/iter	2358305.084174861 ns/iter	1.04
Micro_Draft6_Property_Names	119.00022276501615 ns/iter	114.74497565793357 ns/iter	1.04
Micro_Draft6_Compile_FHIR	16492857565.999998 ns/iter	15632526020.99999 ns/iter	1.06
Micro_Draft7_If_Then_Else	22.822931899859256 ns/iter	23.638623220337386 ns/iter	0.97
Micro_2019_09_Unevaluated_Properties	28.915729278163457 ns/iter	25.817000719727265 ns/iter	1.12
Micro_2019_09_Compile_Wrap	326241785.99996865 ns/iter	293242601.0000313 ns/iter	1.11
Micro_2020_12_Dynamic_Ref	233.53539417330163 ns/iter	235.33268348061443 ns/iter	0.99
Micro_2020_12_Dynamic_Ref_Single	3.4294687411920006 ns/iter	3.5166695879186407 ns/iter	0.98
Micro_2020_12_Simple_Output_Mask	66359.87946386043 ns/iter	63595.86632274905 ns/iter	1.04
Micro_2020_12_Simple_Output_Annotations	102931.18375884216 ns/iter	96501.02053107257 ns/iter	1.07
Micro_2020_12_Compile_NonCircular_Shared_Refs	1097902.3777430297 ns/iter	1071070.5494672295 ns/iter	1.03
Micro_2020_12_Exhaustive_Deep_Numeric	7980.365215985873 ns/iter	8433.377867713501 ns/iter	0.95
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput	175413.202419153 ns/iter	175318.490129172 ns/iter	1.00
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput	22269.6175127078 ns/iter	22906.576429980087 ns/iter	0.97
Micro_2020_12_Exhaustive_Deep_Numeric_Fail	141.6112292763729 ns/iter	185.83250869871125 ns/iter	0.76
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput	4162.816214091138 ns/iter	4011.9989590940427 ns/iter	1.04
Alterschema_Check_Readibility_ISO_Language_Set_3	369637491.49998647 ns/iter	317667629.50002205 ns/iter	1.16
Alterschema_Check_Readibility_OMC	88466247.62499289 ns/iter	88472053.25000118 ns/iter	1.00
Alterschema_Check_Readibility_KrakenD	1228389233.0000298 ns/iter	1299686029.9999752 ns/iter	0.95
Alterschema_Apply_Readibility_KrakenD	124410545558.00008 ns/iter	127612241921.99995 ns/iter	0.97
Alterschema_Check_Invalid_External_Refs	300478236.4999983 ns/iter	275017822.9999847 ns/iter	1.09

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

JavaScript (linux/llvm)

Details

Benchmark suite	Current: f929ed5	Previous: bc102d2	Ratio
E2E_Evaluator_adaptivecard	116985 ns	115911 ns	1.01
E2E_Evaluator_ansible-meta	623221 ns	585223 ns	1.06
E2E_Evaluator_aws-cdk	140976 ns	133292 ns	1.06
E2E_Evaluator_babelrc	349951 ns	306850 ns	1.14
E2E_Evaluator_cerebrum-criminal-case	2951863 ns	2863319 ns	1.03
E2E_Evaluator_clang-format	328767 ns	263039 ns	1.25
E2E_Evaluator_cmake-presets	22420641 ns	18896228 ns	1.19
E2E_Evaluator_code-climate	451405 ns	431375 ns	1.05
E2E_Evaluator_cql2	1198976 ns	1228928 ns	0.98
E2E_Evaluator_cspell	1701073 ns	1621172 ns	1.05
E2E_Evaluator_cypress	941637 ns	872275 ns	1.08
E2E_Evaluator_deno	1205882 ns	1147863 ns	1.05
E2E_Evaluator_dependabot	1187659 ns	1076097 ns	1.10
E2E_Evaluator_draft-04	24205737 ns	20857832 ns	1.16
E2E_Evaluator_fabric-mod	2703973 ns	2605366 ns	1.04
E2E_Evaluator_geojson	21552408 ns	22115716 ns	0.97
E2E_Evaluator_gitpod-configuration	797396 ns	785726 ns	1.01
E2E_Evaluator_helm-chart-lock	1011577 ns	1047959 ns	0.97
E2E_Evaluator_importmap	295968 ns	282576 ns	1.05
E2E_Evaluator_jasmine	315918 ns	293137 ns	1.08
E2E_Evaluator_jsconfig	1519192 ns	1421273 ns	1.07
E2E_Evaluator_jshintrc	3399188 ns	3227761 ns	1.05
E2E_Evaluator_krakend	794032 ns	713399 ns	1.11
E2E_Evaluator_lazygit	618976 ns	462907 ns	1.34
E2E_Evaluator_lerna	505749 ns	441459 ns	1.15
E2E_Evaluator_nest-cli	668077 ns	652700 ns	1.02
E2E_Evaluator_omc	87138 ns	87704 ns	0.99
E2E_Evaluator_omnisharp	1699078 ns	1571064 ns	1.08
E2E_Evaluator_openapi	41851808 ns	36789490 ns	1.14
E2E_Evaluator_pre-commit-hooks	2191114 ns	2022397 ns	1.08
E2E_Evaluator_pulumi	2085346 ns	2122746 ns	0.98
E2E_Evaluator_semantic-release	274062 ns	244101 ns	1.12
E2E_Evaluator_stale	451506 ns	430076 ns	1.05
E2E_Evaluator_stylecop	1320663 ns	1237753 ns	1.07
E2E_Evaluator_tmuxinator	239270 ns	228653 ns	1.05
E2E_Evaluator_ui5	2270062 ns	2266505 ns	1.00
E2E_Evaluator_ui5-manifest	13388776 ns	10032776 ns	1.33
E2E_Evaluator_unreal-engine-uproject	1611139 ns	1572233 ns	1.02
E2E_Evaluator_vercel	1147789 ns	1067424 ns	1.08
E2E_Evaluator_yamllint	25319 ns	23517 ns	1.08

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Benchmark (macos/llvm)

Details

Benchmark suite	Current: f929ed5	Previous: bc102d2	Ratio
E2E_Compiler_adaptivecard	61793541.636368655 ns/iter	68890416.62500972 ns/iter	0.90
E2E_Compiler_ansible_meta	25591695.41379545 ns/iter	28423027.77777503 ns/iter	0.90
E2E_Compiler_aws_cdk	290273.51488210104 ns/iter	306405.2973513185 ns/iter	0.95
E2E_Compiler_babelrc	2194629.5736676794 ns/iter	2246269.3145694295 ns/iter	0.98
E2E_Compiler_clang_format	15566888.020832911 ns/iter	16858396.795454796 ns/iter	0.92
E2E_Compiler_cmake_presets	26623668.269232545 ns/iter	31858608.35000085 ns/iter	0.84
E2E_Compiler_code_climate	2353086.841750807 ns/iter	2634665.454545277 ns/iter	0.89
E2E_Compiler_cql2	12057157.935483672 ns/iter	14877038.636363564 ns/iter	0.81
E2E_Compiler_cspell	20469608.34285788 ns/iter	24674300.78124977 ns/iter	0.83
E2E_Compiler_cypress	3677678.4793815264 ns/iter	3785535.7796605583 ns/iter	0.97
E2E_Compiler_deno	7418090.280702129 ns/iter	7161536.764705685 ns/iter	1.04
E2E_Compiler_dependabot	4154537.159793436 ns/iter	3978154.6529411566 ns/iter	1.04
E2E_Compiler_draft_04	2051559.642857228 ns/iter	2230087.7259035506 ns/iter	0.92
E2E_Compiler_fabric_mod	3873067.706521738 ns/iter	4902870.239999564 ns/iter	0.79
E2E_Compiler_geojson	22967148.437501807 ns/iter	27365926.57142756 ns/iter	0.84
E2E_Compiler_gitpod_configuration	4160973.579268457 ns/iter	5348820.512820481 ns/iter	0.78
E2E_Compiler_helm_chart_lock	526649.7500000468 ns/iter	833023.2260764738 ns/iter	0.63
E2E_Compiler_importmap	218883.6897067821 ns/iter	269451.11686496664 ns/iter	0.81
E2E_Compiler_jasmine	1102718.8856729749 ns/iter	1488968.3931484127 ns/iter	0.74
E2E_Compiler_jshintrc	3594938.7581399074 ns/iter	4518552.837988579 ns/iter	0.80
E2E_Compiler_jsconfig	20725106.972973492 ns/iter	25051221.055554785 ns/iter	0.83
E2E_Compiler_krakend	132972368.16667162 ns/iter	175804437.5000054 ns/iter	0.76
E2E_Compiler_lazygit	36422356.090905726 ns/iter	40365499.999995194 ns/iter	0.90
E2E_Compiler_lerna	1349935.922348562 ns/iter	1461141.713493539 ns/iter	0.92
E2E_Compiler_nest_cli	6766782.157894756 ns/iter	7408240.69642798 ns/iter	0.91
E2E_Compiler_omc	169524260.25000024 ns/iter	248550416.75002098 ns/iter	0.68
E2E_Compiler_omnisharp	6454616.169491092 ns/iter	7886654.172727958 ns/iter	0.82
E2E_Compiler_openapi	22508702.03030183 ns/iter	28643455.259258293 ns/iter	0.79
E2E_Compiler_pre_commit_hooks	4568686.098159672 ns/iter	5370756.249999431 ns/iter	0.85
E2E_Compiler_pulumi	3414440.032710441 ns/iter	5122433.229813701 ns/iter	0.67
E2E_Compiler_semantic_release	1313090.2541528323 ns/iter	2155264.4173028613 ns/iter	0.61
E2E_Compiler_stale	1312392.3436960594 ns/iter	1799903.9532294183 ns/iter	0.73
E2E_Compiler_stylecop	5667710.97619079 ns/iter	7931524.396396141 ns/iter	0.71
E2E_Compiler_tmuxinator	1602594.3227846196 ns/iter	2274030.80909088 ns/iter	0.70
E2E_Compiler_ui5	58460833.33332786 ns/iter	91803500.00000317 ns/iter	0.64
E2E_Compiler_ui5_manifest	310290021.00001436 ns/iter	459385729.5000134 ns/iter	0.68
E2E_Compiler_unreal_engine_uproject	3791908.192090368 ns/iter	5280728.750000208 ns/iter	0.72
E2E_Compiler_vercel	11928362.225806987 ns/iter	15081069.438595382 ns/iter	0.79
E2E_Compiler_yamllint	261383.55571796387 ns/iter	377710.83916081564 ns/iter	0.69
E2E_Evaluator_adaptivecard	19388.40115603479 ns/iter	23864.282162675492 ns/iter	0.81
E2E_Evaluator_ansible_meta	159803.68762908495 ns/iter	203056.2937949725 ns/iter	0.79
E2E_Evaluator_aws_cdk	34225.51079595865 ns/iter	42436.10220488099 ns/iter	0.81
E2E_Evaluator_babelrc	80645.77397651112 ns/iter	90661.01140782592 ns/iter	0.89
E2E_Evaluator_cerebrum_criminal_case	879368.8602014512 ns/iter	1030392.029972778 ns/iter	0.85
E2E_Evaluator_clang_format	96938.03448759414 ns/iter	114266.49978074121 ns/iter	0.85
E2E_Evaluator_cmake_presets	3266761.441176525 ns/iter	3947840.533834452 ns/iter	0.83
E2E_Evaluator_code_climate	122660.95580872038 ns/iter	175892.23845107487 ns/iter	0.70
E2E_Evaluator_cql2	145643.3819188094 ns/iter	197594.63077936156 ns/iter	0.74
E2E_Evaluator_cspell	396004.1827410996 ns/iter	521625.89838338323 ns/iter	0.76
E2E_Evaluator_cypress	137309.66633425074 ns/iter	166538.8254071753 ns/iter	0.82
E2E_Evaluator_deno	249939.11938337452 ns/iter	328875.3407320791 ns/iter	0.76
E2E_Evaluator_dependabot	321711.6999076874 ns/iter	383993.19168588886 ns/iter	0.84
E2E_Evaluator_draft_04	5349676.333333963 ns/iter	5828527.131783165 ns/iter	0.92
E2E_Evaluator_fabric_mod	530128.5907894962 ns/iter	603304.826862542 ns/iter	0.88
E2E_Evaluator_geojson	11043112.288136354 ns/iter	15127150.46296383 ns/iter	0.73
E2E_Evaluator_gitpod_configuration	158258.77653370626 ns/iter	201623.53801167506 ns/iter	0.78
E2E_Evaluator_helm_chart_lock	190744.540555852 ns/iter	271952.8555038524 ns/iter	0.70
E2E_Evaluator_importmap	30189.16763341296 ns/iter	32396.263991119496 ns/iter	0.93
E2E_Evaluator_jasmine	74060.98736282275 ns/iter	93264.6732026055 ns/iter	0.79
E2E_Evaluator_jshintrc	874779.7105912118 ns/iter	950333.6113902604 ns/iter	0.92
E2E_Evaluator_jsconfig	278555.14128729235 ns/iter	346634.4144055223 ns/iter	0.80
E2E_Evaluator_krakend	120533.23935715707 ns/iter	175097.66259425384 ns/iter	0.69
E2E_Evaluator_lazygit	105512.99869468405 ns/iter	123039.13827375341 ns/iter	0.86
E2E_Evaluator_lerna	122911.41865395462 ns/iter	145215.5262464748 ns/iter	0.85
E2E_Evaluator_nest_cli	121566.48842916024 ns/iter	156591.98160577336 ns/iter	0.78
E2E_Evaluator_omc	13899.78260334103 ns/iter	16414.67856827133 ns/iter	0.85
E2E_Evaluator_omnisharp	444335.9003932152 ns/iter	513961.1443884303 ns/iter	0.86
E2E_Evaluator_openapi	7428699.826530702 ns/iter	8059332.089552205 ns/iter	0.92
E2E_Evaluator_pre_commit_hooks	327965.82303761767 ns/iter	337833.9730016292 ns/iter	0.97
E2E_Evaluator_pulumi	467454.0892857425 ns/iter	461725.087673009 ns/iter	1.01
E2E_Evaluator_semantic_release	63784.103410337164 ns/iter	63127.201344164394 ns/iter	1.01
E2E_Evaluator_stale	102032.4947760139 ns/iter	104086.37539521599 ns/iter	0.98
E2E_Evaluator_stylecop	171158.48339768138 ns/iter	169098.22014563094 ns/iter	1.01
E2E_Evaluator_tmuxinator	64367.513710645966 ns/iter	63801.81775956422 ns/iter	1.01
E2E_Evaluator_ui5	306050.0435161033 ns/iter	316575.44123979483 ns/iter	0.97
E2E_Evaluator_ui5_manifest	1405952.4426232604 ns/iter	1442521.8139054882 ns/iter	0.97
E2E_Evaluator_unreal_engine_uproject	295549.7642475996 ns/iter	285275.76219512336 ns/iter	1.04
E2E_Evaluator_vercel	209463.72352586337 ns/iter	206829.6496156516 ns/iter	1.01
E2E_Evaluator_yamllint	5312.861153003209 ns/iter	5522.5648110327575 ns/iter	0.96
Micro_Draft4_Meta_1_No_Callback	118.57711550968965 ns/iter	117.25365603073573 ns/iter	1.01
Micro_Draft4_Required_Properties	580.1741354178598 ns/iter	575.2229763620368 ns/iter	1.01
Micro_Draft4_Many_Optional_Properties_Minimal_Match	15.311764157650282 ns/iter	14.381104835144455 ns/iter	1.06
Micro_Draft4_Few_Optional_Properties_Minimal_Match	6.7956488465009 ns/iter	6.4890573623153065 ns/iter	1.05
Micro_Draft4_Items_Schema	238.42181038747842 ns/iter	248.0612340638441 ns/iter	0.96
Micro_Draft4_Nested_Object	0.6525111382759501 ns/iter	0.6610109217207416 ns/iter	0.99
Micro_Draft4_Properties_Triad_Optional	185.2308145021903 ns/iter	193.76497932281487 ns/iter	0.96
Micro_Draft4_Properties_Triad_Closed	154.0252386379102 ns/iter	154.42212777081056 ns/iter	1.00
Micro_Draft4_Properties_Triad_Required	198.99263161857692 ns/iter	195.66242915794092 ns/iter	1.02
Micro_Draft4_Properties_Closed	35.95531085714075 ns/iter	35.872608923871205 ns/iter	1.00
Micro_Draft4_Non_Recursive_Ref	11.73134507225502 ns/iter	11.768632180774562 ns/iter	1.00
Micro_Draft4_Pattern_Properties_True	136.35161509465794 ns/iter	140.72208485728837 ns/iter	0.97
Micro_Draft4_Ref_To_Single_Property	6.534578144792146 ns/iter	6.791057496987737 ns/iter	0.96
Micro_Draft4_Additional_Properties_Type	23.59838778276051 ns/iter	25.246273026281646 ns/iter	0.93
Micro_Draft4_Nested_Oneof	38.25355674632809 ns/iter	42.02946476293307 ns/iter	0.91
Micro_Draft4_Short_Enum	4.520106324013633 ns/iter	4.553117392737819 ns/iter	0.99
Micro_Draft4_Long_Enum	9.483529087785728 ns/iter	9.104276710548055 ns/iter	1.04
Micro_Draft4_Long_Enum_Short_Strings	5.737794025232707 ns/iter	5.681751335865052 ns/iter	1.01
Micro_Draft4_Type_Object	2.028902420564967 ns/iter	2.005137340753378 ns/iter	1.01
Micro_Draft4_Ref_Single_100	1560485.3104215644 ns/iter	1536890.4301550817 ns/iter	1.02
Micro_Draft4_Compile_Ref_Many_Nested	1145465.218588656 ns/iter	1251027.8454105747 ns/iter	0.92
Micro_Draft4_Compile_Wrap	1853243.7664044593 ns/iter	1923104.2857148037 ns/iter	0.96
Micro_Draft6_Property_Names	88.05961445403999 ns/iter	92.45673497911109 ns/iter	0.95
Micro_Draft6_Compile_FHIR	6967121709.000139 ns/iter	7605264082.999838 ns/iter	0.92
Micro_Draft7_If_Then_Else	16.314654753175525 ns/iter	16.196861743141056 ns/iter	1.01
Micro_2019_09_Unevaluated_Properties	24.71131960568049 ns/iter	25.039747071239333 ns/iter	0.99
Micro_2019_09_Compile_Wrap	269577625.0000108 ns/iter	279046375.00000715 ns/iter	0.97
Micro_2020_12_Dynamic_Ref	173.5371625811258 ns/iter	170.89558621801748 ns/iter	1.02
Micro_2020_12_Dynamic_Ref_Single	2.030058060731334 ns/iter	1.9997688719049722 ns/iter	1.02
Micro_2020_12_Simple_Output_Mask	56855.238617272626 ns/iter	56373.07720706721 ns/iter	1.01
Micro_2020_12_Simple_Output_Annotations	81988.32446091405 ns/iter	79423.8574504077 ns/iter	1.03
Micro_2020_12_Compile_NonCircular_Shared_Refs	769085.4257641435 ns/iter	768468.0524554669 ns/iter	1.00
Micro_2020_12_Exhaustive_Deep_Numeric	5436.40485962258 ns/iter	4858.139640173931 ns/iter	1.12
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput	111754.57436783797 ns/iter	106707.33693830087 ns/iter	1.05
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput	13376.930102770666 ns/iter	13248.158820642484 ns/iter	1.01
Micro_2020_12_Exhaustive_Deep_Numeric_Fail	87.67745469429669 ns/iter	85.67754426744801 ns/iter	1.02
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput	4474.952972167946 ns/iter	4540.120483170527 ns/iter	0.99
Alterschema_Check_Readibility_ISO_Language_Set_3	223591028.000025 ns/iter	215212486.00000337 ns/iter	1.04
Alterschema_Check_Readibility_OMC	54346846.15383608 ns/iter	51116824.42856948 ns/iter	1.06
Alterschema_Check_Readibility_KrakenD	565210290.9998575 ns/iter	551236124.9998322 ns/iter	1.03
Alterschema_Apply_Readibility_KrakenD	59769987541.999855 ns/iter	60992388124.99993 ns/iter	0.98
Alterschema_Check_Invalid_External_Refs	147642366.7999825 ns/iter	151045608.2000019 ns/iter	0.98

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

JavaScript (macos/llvm)

Details

Benchmark suite	Current: f929ed5	Previous: bc102d2	Ratio
E2E_Evaluator_adaptivecard	85030 ns	84192 ns	1.01
E2E_Evaluator_ansible-meta	420567 ns	379388 ns	1.11
E2E_Evaluator_aws-cdk	110501 ns	112507 ns	0.98
E2E_Evaluator_babelrc	309084 ns	318063 ns	0.97
E2E_Evaluator_cerebrum-criminal-case	1911181 ns	1868183 ns	1.02
E2E_Evaluator_clang-format	214896 ns	210451 ns	1.02
E2E_Evaluator_cmake-presets	12576928 ns	11517258 ns	1.09
E2E_Evaluator_code-climate	360315 ns	345360 ns	1.04
E2E_Evaluator_cql2	872041 ns	835241 ns	1.04
E2E_Evaluator_cspell	1209432 ns	1287687 ns	0.94
E2E_Evaluator_cypress	704454 ns	746442 ns	0.94
E2E_Evaluator_deno	752724 ns	769835 ns	0.98
E2E_Evaluator_dependabot	841427 ns	820440 ns	1.03
E2E_Evaluator_draft-04	15049380 ns	14665071 ns	1.03
E2E_Evaluator_fabric-mod	1726790 ns	1668856 ns	1.03
E2E_Evaluator_geojson	22369191 ns	19367448 ns	1.15
E2E_Evaluator_gitpod-configuration	619688 ns	651564 ns	0.95
E2E_Evaluator_helm-chart-lock	1036990 ns	998600 ns	1.04
E2E_Evaluator_importmap	213335 ns	219640 ns	0.97
E2E_Evaluator_jasmine	261182 ns	254925 ns	1.02
E2E_Evaluator_jsconfig	1270821 ns	1246839 ns	1.02
E2E_Evaluator_jshintrc	2404819 ns	2379780 ns	1.01
E2E_Evaluator_krakend	462170 ns	438000 ns	1.06
E2E_Evaluator_lazygit	338151 ns	342743 ns	0.99
E2E_Evaluator_lerna	370992 ns	392518 ns	0.95
E2E_Evaluator_nest-cli	544816 ns	532059 ns	1.02
E2E_Evaluator_omc	66692 ns	65523 ns	1.02
E2E_Evaluator_omnisharp	1267669 ns	1199887 ns	1.06
E2E_Evaluator_openapi	23528652 ns	23441714 ns	1.00
E2E_Evaluator_pre-commit-hooks	1626366 ns	1506793 ns	1.08
E2E_Evaluator_pulumi	1704417 ns	1681983 ns	1.01
E2E_Evaluator_semantic-release	219174 ns	229285 ns	0.96
E2E_Evaluator_stale	351047 ns	345921 ns	1.01
E2E_Evaluator_stylecop	815108 ns	800975 ns	1.02
E2E_Evaluator_tmuxinator	220665 ns	199718 ns	1.10
E2E_Evaluator_ui5	1470705 ns	1437274 ns	1.02
E2E_Evaluator_ui5-manifest	8012754 ns	7576293 ns	1.06
E2E_Evaluator_unreal-engine-uproject	1341754 ns	1322610 ns	1.01
E2E_Evaluator_vercel	851407 ns	889779 ns	0.96
E2E_Evaluator_yamllint	30088 ns	27217 ns	1.11

This comment was automatically generated by workflow using github-action-benchmark.

[jviotti]

augment review

[github-actions]

Benchmark (linux/gcc)

Details

Benchmark suite	Current: f929ed5	Previous: bc102d2	Ratio
Alterschema_Check_Readibility_ISO_Language_Set_3	350872621.50000244 ns/iter	349455152.00001866 ns/iter	1.00
Alterschema_Check_Readibility_OMC	99528877.1428672 ns/iter	96887358.71428175 ns/iter	1.03
Alterschema_Check_Readibility_KrakenD	1418632551.9999628 ns/iter	1330478490.9998944 ns/iter	1.07
Alterschema_Apply_Readibility_KrakenD	132814551458.00009 ns/iter	123370990435.00006 ns/iter	1.08
Alterschema_Check_Invalid_External_Refs	305136236.4999477 ns/iter	339194163.0000019 ns/iter	0.90
Micro_2020_12_Dynamic_Ref	260.6554555150938 ns/iter	268.2799168046429 ns/iter	0.97
Micro_2020_12_Dynamic_Ref_Single	4.630487130629956 ns/iter	4.984200769633955 ns/iter	0.93
Micro_2020_12_Simple_Output_Mask	71296.98809766008 ns/iter	73417.713165324 ns/iter	0.97
Micro_2020_12_Simple_Output_Annotations	103563.71471559985 ns/iter	114166.7109671271 ns/iter	0.91
Micro_2020_12_Compile_NonCircular_Shared_Refs	1178358.8989901515 ns/iter	1199298.1965813357 ns/iter	0.98
Micro_2020_12_Exhaustive_Deep_Numeric	7850.837292780633 ns/iter	8269.133925721379 ns/iter	0.95
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput	167381.05204371538 ns/iter	166160.81018629452 ns/iter	1.01
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput	26221.763996579542 ns/iter	25284.92574738561 ns/iter	1.04
Micro_2020_12_Exhaustive_Deep_Numeric_Fail	131.37396768903187 ns/iter	129.40834920666356 ns/iter	1.02
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput	4463.577089458018 ns/iter	4659.620624433933 ns/iter	0.96
Micro_2019_09_Unevaluated_Properties	29.20372405275079 ns/iter	29.928001177829447 ns/iter	0.98
Micro_2019_09_Compile_Wrap	330280104.00005317 ns/iter	305982503.49999034 ns/iter	1.08
Micro_Draft7_If_Then_Else	25.200279885803617 ns/iter	24.598743180746055 ns/iter	1.02
Micro_Draft6_Property_Names	142.64041437833066 ns/iter	142.5352703494647 ns/iter	1.00
Micro_Draft6_Compile_FHIR	15376519085.999916 ns/iter	13372853572.000168 ns/iter	1.15
Micro_Draft4_Meta_1_No_Callback	174.44308585688415 ns/iter	166.09429273868872 ns/iter	1.05
Micro_Draft4_Required_Properties	817.9207637315194 ns/iter	800.9754411612776 ns/iter	1.02
Micro_Draft4_Many_Optional_Properties_Minimal_Match	21.840568153753406 ns/iter	21.195864493834154 ns/iter	1.03
Micro_Draft4_Few_Optional_Properties_Minimal_Match	13.371734213973665 ns/iter	13.718546998826284 ns/iter	0.97
Micro_Draft4_Items_Schema	315.4193461132619 ns/iter	354.3103539017007 ns/iter	0.89
Micro_Draft4_Nested_Object	2.471245738131074 ns/iter	1.868315794001353 ns/iter	1.32
Micro_Draft4_Properties_Triad_Optional	426.14495552413285 ns/iter	414.3049174686248 ns/iter	1.03
Micro_Draft4_Properties_Triad_Closed	362.85507034938036 ns/iter	317.28778917564364 ns/iter	1.14
Micro_Draft4_Properties_Triad_Required	460.72353635237204 ns/iter	421.6431773009335 ns/iter	1.09
Micro_Draft4_Properties_Closed	64.22361144282755 ns/iter	63.85748001232711 ns/iter	1.01
Micro_Draft4_Non_Recursive_Ref	8.85226817556905 ns/iter	10.269967968049553 ns/iter	0.86
Micro_Draft4_Pattern_Properties_True	191.00779219295862 ns/iter	226.75326954690684 ns/iter	0.84
Micro_Draft4_Ref_To_Single_Property	13.079788248323386 ns/iter	13.706068863986285 ns/iter	0.95
Micro_Draft4_Additional_Properties_Type	14.48387662071728 ns/iter	14.944992788569024 ns/iter	0.97
Micro_Draft4_Nested_Oneof	66.52868827790573 ns/iter	65.72703950220128 ns/iter	1.01
Micro_Draft4_Short_Enum	14.768888595427018 ns/iter	14.666098158400134 ns/iter	1.01
Micro_Draft4_Long_Enum	14.083596002981725 ns/iter	15.271644034943158 ns/iter	0.92
Micro_Draft4_Long_Enum_Short_Strings	14.787781516855215 ns/iter	14.740972164135176 ns/iter	1.00
Micro_Draft4_Type_Object	4.574710817681471 ns/iter	5.13394099000152 ns/iter	0.89
Micro_Draft4_Ref_Single_100	2547445.9490909465 ns/iter	2524918.9749997314 ns/iter	1.01
Micro_Draft4_Compile_Ref_Many_Nested	1844101.4578947467 ns/iter	1820848.836363935 ns/iter	1.01
Micro_Draft4_Compile_Wrap	2593155.1970256213 ns/iter	2562555.4014599086 ns/iter	1.01
E2E_Compiler_adaptivecard	66532412.900005504 ns/iter	64654065.45453334 ns/iter	1.03
E2E_Compiler_ansible_meta	30632234.043472953 ns/iter	29936389.26086137 ns/iter	1.02
E2E_Compiler_aws_cdk	398134.9465302256 ns/iter	410932.4064515571 ns/iter	0.97
E2E_Compiler_babelrc	2780572.8167336327 ns/iter	2759052.5217396417 ns/iter	1.01
E2E_Compiler_clang_format	19740963.083336283 ns/iter	19406313.583336517 ns/iter	1.02
E2E_Compiler_cmake_presets	27898325.480000496 ns/iter	27053242.73076188 ns/iter	1.03
E2E_Compiler_code_climate	2818229.8461534567 ns/iter	2785634.9087304776 ns/iter	1.01
E2E_Compiler_cql2	14178095.836731866 ns/iter	13939921.97999978 ns/iter	1.02
E2E_Compiler_cspell	24576636.03448462 ns/iter	23874003.689656846 ns/iter	1.03
E2E_Compiler_cypress	4250980.078787699 ns/iter	4245855.30000005 ns/iter	1.00
E2E_Compiler_deno	8319616.464285945 ns/iter	8176360.604651097 ns/iter	1.02
E2E_Compiler_dependabot	4239983.20605995 ns/iter	4139875.177514964 ns/iter	1.02
E2E_Compiler_draft_04	2920967.958332691 ns/iter	2922778.2208333034 ns/iter	1.00
E2E_Compiler_fabric_mod	5152388.735293766 ns/iter	5139475.963503579 ns/iter	1.00
E2E_Compiler_geojson	24439841.827580526 ns/iter	23731785.399998747 ns/iter	1.03
E2E_Compiler_gitpod_configuration	5311887.3106058985 ns/iter	5247132.723879918 ns/iter	1.01
E2E_Compiler_helm_chart_lock	720874.1752577028 ns/iter	743459.5791710018 ns/iter	0.97
E2E_Compiler_importmap	294784.4186733973 ns/iter	306806.7662108675 ns/iter	0.96
E2E_Compiler_jasmine	1452961.9710145115 ns/iter	1464214.4083334568 ns/iter	0.99
E2E_Compiler_jshintrc	4648701.026665852 ns/iter	4652784.854304338 ns/iter	1.00
E2E_Compiler_jsconfig	23341468.9666688 ns/iter	23098392.733337883 ns/iter	1.01
E2E_Compiler_krakend	143018233.59996888 ns/iter	144383962.60002264 ns/iter	0.99
E2E_Compiler_lazygit	36148885.3684238 ns/iter	35232218.599992394 ns/iter	1.03
E2E_Compiler_lerna	1722619.8596057512 ns/iter	1716211.9388753069 ns/iter	1.00
E2E_Compiler_nest_cli	8052577.1379310675 ns/iter	7910093.681818931 ns/iter	1.02
E2E_Compiler_omc	170115971.24997026 ns/iter	166340484.9999779 ns/iter	1.02
E2E_Compiler_omnisharp	7251470.052085078 ns/iter	7097701.909090417 ns/iter	1.02
E2E_Compiler_openapi	27075631.692311548 ns/iter	26761717.99999758 ns/iter	1.01
E2E_Compiler_pre_commit_hooks	5730921.552845403 ns/iter	5903840.62096775 ns/iter	0.97
E2E_Compiler_pulumi	4362702.981366083 ns/iter	4325379.614906609 ns/iter	1.01
E2E_Compiler_semantic_release	1686630.5395682375 ns/iter	1691362.2120485464 ns/iter	1.00
E2E_Compiler_stale	1656903.011847876 ns/iter	1651577.547169969 ns/iter	1.00
E2E_Compiler_stylecop	6467860.0366974985 ns/iter	6792033.718180723 ns/iter	0.95
E2E_Compiler_tmuxinator	2079275.035948086 ns/iter	2075440.1899110514 ns/iter	1.00
E2E_Compiler_ui5	50887969.857139334 ns/iter	48763587.99999382 ns/iter	1.04
E2E_Compiler_ui5_manifest	320592534.0000704 ns/iter	322472230.0000167 ns/iter	0.99
E2E_Compiler_unreal_engine_uproject	5001864.780140762 ns/iter	4897549.74125924 ns/iter	1.02
E2E_Compiler_vercel	13407904.326920917 ns/iter	13172276.603774732 ns/iter	1.02
E2E_Compiler_yamllint	364094.2061266124 ns/iter	376484.1035599121 ns/iter	0.97
E2E_Evaluator_adaptivecard	23133.43164275907 ns/iter	23140.330157385415 ns/iter	1.00
E2E_Evaluator_ansible_meta	335844.62674367387 ns/iter	249621.33910275326 ns/iter	1.35
E2E_Evaluator_aws_cdk	44162.71770722923 ns/iter	52779.37052382507 ns/iter	0.84
E2E_Evaluator_babelrc	85003.34530351432 ns/iter	106808.85285650098 ns/iter	0.80
E2E_Evaluator_cerebrum_criminal_case	1324346.5103575995 ns/iter	1274270.797101307 ns/iter	1.04
E2E_Evaluator_clang_format	95193.76240700587 ns/iter	107525.55840978277 ns/iter	0.89
E2E_Evaluator_cmake_presets	4560244.9738572175 ns/iter	4644651.859872532 ns/iter	0.98
E2E_Evaluator_code_climate	159638.93272101166 ns/iter	188045.5172137306 ns/iter	0.85
E2E_Evaluator_cql2	203396.6099793072 ns/iter	208657.83748127468 ns/iter	0.97
E2E_Evaluator_cspell	519643.94519511226 ns/iter	546842.7713178822 ns/iter	0.95
E2E_Evaluator_cypress	136932.9339752435 ns/iter	177272.6401610462 ns/iter	0.77
E2E_Evaluator_deno	282846.3528201744 ns/iter	332656.05493488774 ns/iter	0.85
E2E_Evaluator_dependabot	445731.1368554121 ns/iter	462165.77886502264 ns/iter	0.96
E2E_Evaluator_draft_04	7899290.678573207 ns/iter	6273814.020834342 ns/iter	1.26
E2E_Evaluator_fabric_mod	713732.336809103 ns/iter	725437.1652892162 ns/iter	0.98
E2E_Evaluator_geojson	17921068.21053015 ns/iter	16439777.488368807 ns/iter	1.09
E2E_Evaluator_gitpod_configuration	224829.41567617658 ns/iter	259106.18701582326 ns/iter	0.87
E2E_Evaluator_helm_chart_lock	218160.13383838686 ns/iter	322401.5642329223 ns/iter	0.68
E2E_Evaluator_importmap	41993.995784906445 ns/iter	50585.35223211037 ns/iter	0.83
E2E_Evaluator_jasmine	101517.07034443144 ns/iter	118756.95823431414 ns/iter	0.85
E2E_Evaluator_jshintrc	985951.977337188 ns/iter	1044968.1564826017 ns/iter	0.94
E2E_Evaluator_jsconfig	373634.19210244867 ns/iter	404675.5963091426 ns/iter	0.92
E2E_Evaluator_krakend	184899.97914996112 ns/iter	205670.17260515338 ns/iter	0.90
E2E_Evaluator_lazygit	124302.25698621922 ns/iter	134912.53211359 ns/iter	0.92
E2E_Evaluator_lerna	117787.40927904904 ns/iter	155541.87743794007 ns/iter	0.76
E2E_Evaluator_nest_cli	178354.47146145668 ns/iter	200849.40501393023 ns/iter	0.89
E2E_Evaluator_omc	18891.267406253017 ns/iter	19856.59054508327 ns/iter	0.95
E2E_Evaluator_omnisharp	508601.403745307 ns/iter	583186.431631018 ns/iter	0.87
E2E_Evaluator_openapi	13189927.000002382 ns/iter	12743363.92452824 ns/iter	1.04
E2E_Evaluator_pre_commit_hooks	472803.74965888483 ns/iter	515222.7282051571 ns/iter	0.92
E2E_Evaluator_pulumi	720931.9205019512 ns/iter	728187.6101871335 ns/iter	0.99
E2E_Evaluator_semantic_release	86051.84958352876 ns/iter	102399.43556513888 ns/iter	0.84
E2E_Evaluator_stale	147788.26680763665 ns/iter	156525.9193121762 ns/iter	0.94
E2E_Evaluator_stylecop	288986.7358985872 ns/iter	305122.73010383424 ns/iter	0.95
E2E_Evaluator_tmuxinator	86656.37365625078 ns/iter	101637.241877264 ns/iter	0.85
E2E_Evaluator_ui5	523941.05614560226 ns/iter	532094.1489362101 ns/iter	0.98
E2E_Evaluator_ui5_manifest	2695732.7566546528 ns/iter	2748852.895753444 ns/iter	0.98
E2E_Evaluator_unreal_engine_uproject	436307.1952588437 ns/iter	459058.61709062976 ns/iter	0.95
E2E_Evaluator_vercel	262339.85143286944 ns/iter	318036.5577797326 ns/iter	0.82
E2E_Evaluator_yamllint	9298.411008223575 ns/iter	11165.20337602726 ns/iter	0.83

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

JavaScript (linux/gcc)

Details

Benchmark suite	Current: f929ed5	Previous: bc102d2	Ratio
E2E_Evaluator_adaptivecard	142603 ns	116054 ns	1.23
E2E_Evaluator_ansible-meta	616989 ns	585684 ns	1.05
E2E_Evaluator_aws-cdk	131332 ns	138046 ns	0.95
E2E_Evaluator_babelrc	317424 ns	320941 ns	0.99
E2E_Evaluator_cerebrum-criminal-case	2990574 ns	2612950 ns	1.14
E2E_Evaluator_clang-format	276689 ns	281899 ns	0.98
E2E_Evaluator_cmake-presets	21746131 ns	18906790 ns	1.15
E2E_Evaluator_code-climate	432830 ns	431971 ns	1.00
E2E_Evaluator_cql2	1283707 ns	1189168 ns	1.08
E2E_Evaluator_cspell	1693258 ns	1542826 ns	1.10
E2E_Evaluator_cypress	938512 ns	865166 ns	1.08
E2E_Evaluator_deno	1130720 ns	1091563 ns	1.04
E2E_Evaluator_dependabot	1106343 ns	1095325 ns	1.01
E2E_Evaluator_draft-04	23738879 ns	20135931 ns	1.18
E2E_Evaluator_fabric-mod	2800380 ns	2495823 ns	1.12
E2E_Evaluator_geojson	22051282 ns	20754227 ns	1.06
E2E_Evaluator_gitpod-configuration	788525 ns	776435 ns	1.02
E2E_Evaluator_helm-chart-lock	1037953 ns	1014711 ns	1.02
E2E_Evaluator_importmap	296157 ns	285054 ns	1.04
E2E_Evaluator_jasmine	320902 ns	300708 ns	1.07
E2E_Evaluator_jsconfig	1537542 ns	1365115 ns	1.13
E2E_Evaluator_jshintrc	3341810 ns	3396941 ns	0.98
E2E_Evaluator_krakend	771252 ns	767381 ns	1.01
E2E_Evaluator_lazygit	546599 ns	586677 ns	0.93
E2E_Evaluator_lerna	473729 ns	487061 ns	0.97
E2E_Evaluator_nest-cli	671385 ns	633377 ns	1.06
E2E_Evaluator_omc	94343 ns	85589 ns	1.10
E2E_Evaluator_omnisharp	1713539 ns	1602583 ns	1.07
E2E_Evaluator_openapi	38285751 ns	37840420 ns	1.01
E2E_Evaluator_pre-commit-hooks	2207034 ns	2088569 ns	1.06
E2E_Evaluator_pulumi	2215402 ns	2004066 ns	1.11
E2E_Evaluator_semantic-release	256486 ns	262897 ns	0.98
E2E_Evaluator_stale	438283 ns	436970 ns	1.00
E2E_Evaluator_stylecop	1257162 ns	1224517 ns	1.03
E2E_Evaluator_tmuxinator	240004 ns	225055 ns	1.07
E2E_Evaluator_ui5	2345258 ns	2257009 ns	1.04
E2E_Evaluator_ui5-manifest	10904475 ns	11032004 ns	0.99
E2E_Evaluator_unreal-engine-uproject	1614366 ns	1530966 ns	1.05
E2E_Evaluator_vercel	1081751 ns	1071074 ns	1.01
E2E_Evaluator_yamllint	23817 ns	25089 ns	0.95

This comment was automatically generated by workflow using github-action-benchmark.

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

src/alterschema/canonicalizer/next/exclusive_minimum_boolean_integer_fold.h:56: static_cast<std::int64_t>(std::ceil(value)) is undefined behavior if value is NaN/Inf or outside the int64_t range, and the subsequent ceiled += 1 can also overflow. That can silently corrupt the rewritten minimum and change schema semantics for extreme/invalid numeric bounds.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}