Implement SHA-256 in src/core/crypto
#2238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/core/crypto/crypto_sha256.cc">
<violation number="1" location="src/core/crypto/crypto_sha256.cc:175">
P2: Stream formatting state is not fully saved/restored. `setfill('0')` permanently modifies the stream's fill character, and `unsetf(hex)` unconditionally clears hex mode rather than restoring the original flags. Use RAII or manually save/restore both `flags()` and `fill()`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
🤖 Augment PR SummarySummary: Adds SHA-256 hashing support to Changes:
Technical Notes: The implementation produces a lowercase hex digest to an output stream and the test suite validates correctness against both simple known values and vendored reference vectors. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 3adb407 | Previous: 1bc3407 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
3.1090978631117934 ns/iter |
3.122828147552097 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.1825554848465942 ns/iter |
3.1069410322871076 ns/iter |
1.02 |
Regex_Period_Asterisk |
3.1087950067220724 ns/iter |
3.106605651754015 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
3.1099646806459647 ns/iter |
3.107470671083056 ns/iter |
1.00 |
Regex_Period_Plus |
3.1102016789027873 ns/iter |
3.0063067803911245 ns/iter |
1.03 |
Regex_Period |
3.1255488323674876 ns/iter |
3.108056802749006 ns/iter |
1.01 |
Regex_Caret_Period_Plus_Dollar |
3.1872435795986656 ns/iter |
3.1149085767276263 ns/iter |
1.02 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.1124946334122785 ns/iter |
3.107382462458728 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
3.1090446428747387 ns/iter |
3.107712927055048 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.108515617465751 ns/iter |
3.1071198761633356 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
10.714140430992138 ns/iter |
13.054540359457146 ns/iter |
0.82 |
Regex_Period_Md_Dollar |
27.24569848557566 ns/iter |
27.178697023424686 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.072625048434555 ns/iter |
6.100716360821611 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
3.1111675154744916 ns/iter |
3.1108973886371993 ns/iter |
1.00 |
Regex_Nested_Backtrack |
48.88795486865483 ns/iter |
48.890342696173605 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
441.3984508056197 ns/iter |
440.80476769162266 ns/iter |
1.00 |
JSON_Parse_1 |
29420.43675730757 ns/iter |
29097.2472917457 ns/iter |
1.01 |
JSON_Parse_Real |
38445.939794663835 ns/iter |
38322.50497866184 ns/iter |
1.00 |
JSON_Parse_Decimal |
134791.8240375754 ns/iter |
130269.21339068672 ns/iter |
1.03 |
JSON_Parse_Schema_ISO_Language |
22244677.25806511 ns/iter |
22103806.906251576 ns/iter |
1.01 |
JSON_Fast_Hash_Helm_Chart_Lock |
62.46316870906788 ns/iter |
62.24132188555966 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
165.62216241315147 ns/iter |
168.09886786573892 ns/iter |
0.99 |
JSON_String_Equal/10 |
6.87042786921716 ns/iter |
7.962683892458461 ns/iter |
0.86 |
JSON_String_Equal/100 |
7.469599337969278 ns/iter |
8.401824488403793 ns/iter |
0.89 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9382065271932726 ns/iter |
0.9374417900261547 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
10.260436372007648 ns/iter |
14.667853916282313 ns/iter |
0.70 |
JSON_String_Fast_Hash/10 |
2.48757306235431 ns/iter |
2.494268858238807 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.490155161077175 ns/iter |
2.492751236728168 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.4933612551870152 ns/iter |
2.7062561755316086 ns/iter |
0.92 |
JSON_String_Key_Hash/100 |
6.527149878408668 ns/iter |
9.015467507058938 ns/iter |
0.72 |
JSON_Object_Defines_Miss_Same_Length |
3.733510191985757 ns/iter |
3.734605837522291 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7325764113306015 ns/iter |
3.7366531088431914 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.7480842920459745 ns/iter |
3.734217451231265 ns/iter |
1.00 |
Pointer_Object_Traverse |
43.97091891899524 ns/iter |
45.432976876161604 ns/iter |
0.97 |
Pointer_Object_Try_Traverse |
55.17567417433215 ns/iter |
53.21398772105944 ns/iter |
1.04 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
285.0413074807888 ns/iter |
298.06339558372275 ns/iter |
0.96 |
Pointer_Walker_Schema_ISO_Language |
3179383.100000037 ns/iter |
3114970.2088891394 ns/iter |
1.02 |
Schema_Frame_WoT_References |
4894600.4755246965 ns/iter |
4829251.234482085 ns/iter |
1.01 |
Schema_Frame_OMC_References |
20616340.30302905 ns/iter |
20851242.54285802 ns/iter |
0.99 |
Schema_Frame_OMC_Locations |
18874447.48648692 ns/iter |
19091624.944444954 ns/iter |
0.99 |
Schema_Frame_ISO_Language_Locations |
102499999.8333366 ns/iter |
101849514.99998836 ns/iter |
1.01 |
Schema_Frame_KrakenD_References |
40361150.41176746 ns/iter |
40424051.23529052 ns/iter |
1.00 |
Schema_Frame_KrakenD_Reachable |
933311342.0000246 ns/iter |
909859246.9999858 ns/iter |
1.03 |
Schema_Iterator_ISO_Language |
2363600.214046857 ns/iter |
2335937.871621554 ns/iter |
1.01 |
Schema_Frame_ISO_Language_Locations_To_JSON |
138825724.00001436 ns/iter |
132852242.25001003 ns/iter |
1.04 |
Schema_Tracker_ISO_Language |
49350382.42856698 ns/iter |
47326048.733331546 ns/iter |
1.04 |
Schema_Tracker_ISO_Language_To_JSON |
26107001.703706004 ns/iter |
23374285.499998376 ns/iter |
1.12 |
Schema_Format_ISO_Language_To_JSON |
106029742.66663523 ns/iter |
106284876.66667752 ns/iter |
1.00 |
Schema_Bundle_Meta_2020_12 |
2046165.9444454627 ns/iter |
2041644.7088243384 ns/iter |
1.00 |
Schema_Frame_Many_Resources_References |
368888120.500003 ns/iter |
358693026.50002056 ns/iter |
1.03 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
212146384.33332312 ns/iter |
214714070.66667327 ns/iter |
0.99 |
Alterschema_Check_Readibility_OMC |
30638076.47826074 ns/iter |
31092119.60869466 ns/iter |
0.99 |
Alterschema_Apply_Readibility_KrakenD |
572287975.9999841 ns/iter |
586134466.0000895 ns/iter |
0.98 |
EditorSchema_ForEditor_EmbeddedResources |
13370995.269236974 ns/iter |
13235073.528298842 ns/iter |
1.01 |
URITemplateRouter_Create |
17544.119717957165 ns/iter |
17406.769251736652 ns/iter |
1.01 |
URITemplateRouter_Match |
175.37821540109798 ns/iter |
175.78776508640127 ns/iter |
1.00 |
URITemplateRouterView_Restore |
8352.809338434285 ns/iter |
8150.01422046542 ns/iter |
1.02 |
URITemplateRouterView_Match |
140.97989391398457 ns/iter |
137.65754632396752 ns/iter |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 3adb407 | Previous: 1bc3407 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.2446649816169 ns/iter |
1.8770954387222658 ns/iter |
1.20 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.344290924183849 ns/iter |
2.0747037324339144 ns/iter |
1.13 |
Regex_Period_Asterisk |
2.0995217854828088 ns/iter |
2.110707637890013 ns/iter |
0.99 |
Regex_Group_Period_Asterisk_Group |
2.1082272552075367 ns/iter |
1.723001741125648 ns/iter |
1.22 |
Regex_Period_Plus |
2.420159087505808 ns/iter |
2.1523344605062915 ns/iter |
1.12 |
Regex_Period |
2.595985591417839 ns/iter |
2.1786777024403583 ns/iter |
1.19 |
Regex_Caret_Period_Plus_Dollar |
2.8365800080827532 ns/iter |
2.2097972838830433 ns/iter |
1.28 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.015404570567774 ns/iter |
2.221931899095062 ns/iter |
1.36 |
Regex_Caret_Period_Asterisk_Dollar |
2.6984769287243826 ns/iter |
1.973120834763165 ns/iter |
1.37 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.311758415004231 ns/iter |
1.9709094309427235 ns/iter |
1.17 |
Regex_Caret_X_Hyphen |
7.460919849444468 ns/iter |
6.585684239239405 ns/iter |
1.13 |
Regex_Period_Md_Dollar |
25.341284967226823 ns/iter |
26.282176660999554 ns/iter |
0.96 |
Regex_Caret_Slash_Period_Asterisk |
6.784376168991835 ns/iter |
5.6357289177545296 ns/iter |
1.20 |
Regex_Caret_Period_Range_Dollar |
2.6201929706080973 ns/iter |
1.8652861639298726 ns/iter |
1.40 |
Regex_Nested_Backtrack |
33.055260766423494 ns/iter |
37.09008857067053 ns/iter |
0.89 |
JSON_Array_Of_Objects_Unique |
468.068061887943 ns/iter |
366.27054418983744 ns/iter |
1.28 |
JSON_Parse_1 |
29796.41124386038 ns/iter |
23386.054929092355 ns/iter |
1.27 |
JSON_Parse_Real |
36925.340848574306 ns/iter |
31084.38411437665 ns/iter |
1.19 |
JSON_Parse_Decimal |
378161.6825762629 ns/iter |
329402.3113598419 ns/iter |
1.15 |
JSON_Parse_Schema_ISO_Language |
28281515.44443884 ns/iter |
22148903.2258051 ns/iter |
1.28 |
JSON_Fast_Hash_Helm_Chart_Lock |
93.0410833337313 ns/iter |
75.88529678534513 ns/iter |
1.23 |
JSON_Equality_Helm_Chart_Lock |
237.90231154259055 ns/iter |
166.6377686645471 ns/iter |
1.43 |
JSON_String_Equal/10 |
10.416529806039998 ns/iter |
8.959071188060426 ns/iter |
1.16 |
JSON_String_Equal/100 |
10.429723992664849 ns/iter |
9.031086101976765 ns/iter |
1.15 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.47116810807932336 ns/iter |
0.37759429101688824 ns/iter |
1.25 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
5.4090406753454765 ns/iter |
4.746172812505044 ns/iter |
1.14 |
JSON_String_Fast_Hash/10 |
3.158101367679373 ns/iter |
2.9989639487949558 ns/iter |
1.05 |
JSON_String_Fast_Hash/100 |
2.5193889141915387 ns/iter |
2.3944265650725614 ns/iter |
1.05 |
JSON_String_Key_Hash/10 |
1.6352907360225555 ns/iter |
1.7024334869632545 ns/iter |
0.96 |
JSON_String_Key_Hash/100 |
2.4819899649952126 ns/iter |
2.877116247643305 ns/iter |
0.86 |
JSON_Object_Defines_Miss_Same_Length |
3.8942515649344407 ns/iter |
3.2232921697787997 ns/iter |
1.21 |
JSON_Object_Defines_Miss_Too_Small |
3.422148821293074 ns/iter |
3.429015477482925 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.0716247404913464 ns/iter |
3.2889266596015885 ns/iter |
0.93 |
Pointer_Object_Traverse |
16.932453745677364 ns/iter |
18.345189369243286 ns/iter |
0.92 |
Pointer_Object_Try_Traverse |
22.38155045887073 ns/iter |
27.77515911273894 ns/iter |
0.81 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
162.48523415585282 ns/iter |
190.16445305183052 ns/iter |
0.85 |
Pointer_Walker_Schema_ISO_Language |
5028649.436090384 ns/iter |
4858501.374999347 ns/iter |
1.04 |
Schema_Frame_WoT_References |
5247864.169998593 ns/iter |
6150913.246268482 ns/iter |
0.85 |
Schema_Frame_OMC_References |
28154209.999993328 ns/iter |
35823454.333332114 ns/iter |
0.79 |
Schema_Frame_OMC_Locations |
26096554.99999462 ns/iter |
26577496.541667264 ns/iter |
0.98 |
Schema_Frame_ISO_Language_Locations |
89357386.99999872 ns/iter |
85717032.4444496 ns/iter |
1.04 |
Schema_Frame_KrakenD_References |
56143413.46154106 ns/iter |
50244062.500001155 ns/iter |
1.12 |
Schema_Frame_KrakenD_Reachable |
619728937.4999855 ns/iter |
578650457.5000322 ns/iter |
1.07 |
Schema_Iterator_ISO_Language |
2560549.1354583926 ns/iter |
3094826.530612402 ns/iter |
0.83 |
Schema_Frame_ISO_Language_Locations_To_JSON |
108758798.66667522 ns/iter |
107624479.16666436 ns/iter |
1.01 |
Schema_Tracker_ISO_Language |
52860820.46152912 ns/iter |
46474499.99999936 ns/iter |
1.14 |
Schema_Tracker_ISO_Language_To_JSON |
21856237.903230358 ns/iter |
16338847.214285579 ns/iter |
1.34 |
Schema_Format_ISO_Language_To_JSON |
112965673.66662203 ns/iter |
82903694.44443968 ns/iter |
1.36 |
Schema_Bundle_Meta_2020_12 |
1927537.0814358606 ns/iter |
2287886.581265369 ns/iter |
0.84 |
Schema_Frame_Many_Resources_References |
393597916.9999655 ns/iter |
692982833.999963 ns/iter |
0.57 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
210980416.66671935 ns/iter |
213349999.99999127 ns/iter |
0.99 |
Alterschema_Check_Readibility_OMC |
42668511.61111794 ns/iter |
42987548.611114964 ns/iter |
0.99 |
Alterschema_Apply_Readibility_KrakenD |
672404166.9999678 ns/iter |
625072541.0000086 ns/iter |
1.08 |
EditorSchema_ForEditor_EmbeddedResources |
14266016.86536672 ns/iter |
11438828.781811852 ns/iter |
1.25 |
URITemplateRouter_Create |
18708.898147095573 ns/iter |
17560.35361100003 ns/iter |
1.07 |
URITemplateRouter_Match |
204.89773907071176 ns/iter |
187.92079602078434 ns/iter |
1.09 |
URITemplateRouterView_Restore |
14542.760949681693 ns/iter |
11277.089355709946 ns/iter |
1.29 |
URITemplateRouterView_Match |
155.91419507630397 ns/iter |
128.71894403947323 ns/iter |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
Details
| Benchmark suite | Current: 3adb407 | Previous: 1bc3407 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
4.740865189155103 ns/iter |
4.77244169749295 ns/iter |
0.99 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
4.397986249998098 ns/iter |
4.6346581250006125 ns/iter |
0.95 |
Regex_Period_Asterisk |
4.0896099330340565 ns/iter |
4.165782386533598 ns/iter |
0.98 |
Regex_Group_Period_Asterisk_Group |
4.089428578730697 ns/iter |
4.280272500000137 ns/iter |
0.96 |
Regex_Period_Plus |
4.408353426677558 ns/iter |
4.588410412841248 ns/iter |
0.96 |
Regex_Period |
4.404180000000224 ns/iter |
4.515534385078789 ns/iter |
0.98 |
Regex_Caret_Period_Plus_Dollar |
4.401548435533522 ns/iter |
4.486776249999025 ns/iter |
0.98 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
4.414640625000743 ns/iter |
4.459645992097922 ns/iter |
0.99 |
Regex_Caret_Period_Asterisk_Dollar |
4.087617284084757 ns/iter |
4.222126874999788 ns/iter |
0.97 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.086528534084771 ns/iter |
4.153349114558732 ns/iter |
0.98 |
Regex_Caret_X_Hyphen |
7.54182924106926 ns/iter |
8.032893973215494 ns/iter |
0.94 |
Regex_Period_Md_Dollar |
35.143851520419766 ns/iter |
37.10488836760305 ns/iter |
0.95 |
Regex_Caret_Slash_Period_Asterisk |
7.217895535713329 ns/iter |
7.505757812500085 ns/iter |
0.96 |
Regex_Caret_Period_Range_Dollar |
4.724373014447586 ns/iter |
4.983636999997998 ns/iter |
0.95 |
Regex_Nested_Backtrack |
98.02784830233045 ns/iter |
101.89233027267815 ns/iter |
0.96 |
JSON_Array_Of_Objects_Unique |
503.9011607140407 ns/iter |
530.8061999999154 ns/iter |
0.95 |
JSON_Parse_1 |
73577.39955356887 ns/iter |
76489.91071427247 ns/iter |
0.96 |
JSON_Parse_Real |
93737.21708849887 ns/iter |
94858.7652337047 ns/iter |
0.99 |
JSON_Parse_Decimal |
326814.63654230203 ns/iter |
344126.2320328537 ns/iter |
0.95 |
JSON_Parse_Schema_ISO_Language |
57033140.000021376 ns/iter |
59190354.54545255 ns/iter |
0.96 |
JSON_Fast_Hash_Helm_Chart_Lock |
70.02494642859703 ns/iter |
71.77777678569846 ns/iter |
0.98 |
JSON_Equality_Helm_Chart_Lock |
293.33625967240823 ns/iter |
308.16083837489316 ns/iter |
0.95 |
JSON_String_Equal/10 |
13.17033878048968 ns/iter |
13.411092857142291 ns/iter |
0.98 |
JSON_String_Equal/100 |
14.514810267860817 ns/iter |
14.883812210340507 ns/iter |
0.98 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
2.1981366270113645 ns/iter |
2.384175312499792 ns/iter |
0.92 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
12.83155357142667 ns/iter |
12.622955970430183 ns/iter |
1.02 |
JSON_String_Fast_Hash/10 |
4.076840632277779 ns/iter |
4.086614529425895 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
4.1012656249986685 ns/iter |
4.13457688238343 ns/iter |
0.99 |
JSON_String_Key_Hash/10 |
4.393278124999256 ns/iter |
4.393748125001196 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
13.739759536876253 ns/iter |
16.364881586840735 ns/iter |
0.84 |
JSON_Object_Defines_Miss_Same_Length |
3.7651885647061385 ns/iter |
3.7715282075504497 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.769021064699241 ns/iter |
3.786531957522867 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.766911957559446 ns/iter |
3.7630676718512555 ns/iter |
1.00 |
Pointer_Object_Traverse |
50.63924107141864 ns/iter |
51.55056999999488 ns/iter |
0.98 |
Pointer_Object_Try_Traverse |
75.28781249998165 ns/iter |
75.27653571427452 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
150.6410088999473 ns/iter |
171.54670568388636 ns/iter |
0.88 |
Pointer_Walker_Schema_ISO_Language |
10766780.357146543 ns/iter |
9683996.875001099 ns/iter |
1.11 |
Schema_Frame_WoT_References |
9543382.812495338 ns/iter |
9628652.000001239 ns/iter |
0.99 |
Schema_Frame_OMC_References |
42734306.24999719 ns/iter |
43061423.52941285 ns/iter |
0.99 |
Schema_Frame_OMC_Locations |
40392015.789477326 ns/iter |
38722050.00000879 ns/iter |
1.04 |
Schema_Frame_ISO_Language_Locations |
197203933.33333656 ns/iter |
191384274.9999617 ns/iter |
1.03 |
Schema_Frame_KrakenD_References |
93806914.28571352 ns/iter |
89882528.57144679 ns/iter |
1.04 |
Schema_Frame_KrakenD_Reachable |
650166200.0000578 ns/iter |
694985900.0001197 ns/iter |
0.94 |
Schema_Iterator_ISO_Language |
4378713.855422542 ns/iter |
4543969.127516659 ns/iter |
0.96 |
Schema_Frame_ISO_Language_Locations_To_JSON |
261708666.6667395 ns/iter |
262520649.99994218 ns/iter |
1.00 |
Schema_Tracker_ISO_Language |
100846742.85716185 ns/iter |
116070333.33333069 ns/iter |
0.87 |
Schema_Tracker_ISO_Language_To_JSON |
53652727.27274053 ns/iter |
58012669.230772816 ns/iter |
0.92 |
Schema_Format_ISO_Language_To_JSON |
201214866.66675994 ns/iter |
201934499.99995515 ns/iter |
1.00 |
Schema_Bundle_Meta_2020_12 |
3943381.0055843983 ns/iter |
4207169.277109018 ns/iter |
0.94 |
Schema_Frame_Many_Resources_References |
1481757399.9998786 ns/iter |
1581003799.9999623 ns/iter |
0.94 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
331587050.00005287 ns/iter |
353084149.9999724 ns/iter |
0.94 |
Alterschema_Check_Readibility_OMC |
57311381.81818096 ns/iter |
61863629.999993466 ns/iter |
0.93 |
Alterschema_Apply_Readibility_KrakenD |
959043699.9997109 ns/iter |
1015589600.000112 ns/iter |
0.94 |
EditorSchema_ForEditor_EmbeddedResources |
27342987.49995408 ns/iter |
29975720.833363086 ns/iter |
0.91 |
URITemplateRouter_Create |
22447.554156748487 ns/iter |
22692.16874999813 ns/iter |
0.99 |
URITemplateRouter_Match |
211.0354325431005 ns/iter |
212.9479994219585 ns/iter |
0.99 |
URITemplateRouterView_Restore |
31825.017578411258 ns/iter |
32654.01490647453 ns/iter |
0.97 |
URITemplateRouterView_Match |
140.73190889589648 ns/iter |
145.96038634104028 ns/iter |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 3adb407 | Previous: 1bc3407 | Ratio |
|---|---|---|---|
URITemplateRouter_Create |
14935.296335168181 ns/iter |
15244.15827444735 ns/iter |
0.98 |
URITemplateRouter_Match |
178.5811335205358 ns/iter |
173.45036080896128 ns/iter |
1.03 |
URITemplateRouterView_Restore |
8207.933216633812 ns/iter |
8212.757910260802 ns/iter |
1.00 |
URITemplateRouterView_Match |
117.53090796430644 ns/iter |
115.17279628835465 ns/iter |
1.02 |
EditorSchema_ForEditor_EmbeddedResources |
14124560.660034148 ns/iter |
14208351.43998829 ns/iter |
0.99 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
213745105.66662744 ns/iter |
213754856.33332875 ns/iter |
1.00 |
Alterschema_Check_Readibility_OMC |
33657866.857148685 ns/iter |
34450128.52381253 ns/iter |
0.98 |
Alterschema_Apply_Readibility_KrakenD |
595639417.0002568 ns/iter |
616779556.9999726 ns/iter |
0.97 |
Schema_Frame_WoT_References |
5410276.2037031315 ns/iter |
5364794.2900760295 ns/iter |
1.01 |
Schema_Frame_OMC_References |
22429850.437497124 ns/iter |
22687756.903224 ns/iter |
0.99 |
Schema_Frame_OMC_Locations |
20856839.171424974 ns/iter |
20577800.314289823 ns/iter |
1.01 |
Schema_Frame_ISO_Language_Locations |
105403185.99998955 ns/iter |
105616424.14284375 ns/iter |
1.00 |
Schema_Frame_KrakenD_References |
40279116.999994695 ns/iter |
42451280.52941576 ns/iter |
0.95 |
Schema_Frame_KrakenD_Reachable |
826098439.000134 ns/iter |
859669511.9999822 ns/iter |
0.96 |
Schema_Iterator_ISO_Language |
2802144.6507936493 ns/iter |
2767009.090551642 ns/iter |
1.01 |
Schema_Frame_ISO_Language_Locations_To_JSON |
309234431.9999256 ns/iter |
311891473.49994075 ns/iter |
0.99 |
Schema_Tracker_ISO_Language |
47381719.46666323 ns/iter |
50383563.428584106 ns/iter |
0.94 |
Schema_Tracker_ISO_Language_To_JSON |
32391431.499997284 ns/iter |
34460252.200005926 ns/iter |
0.94 |
Schema_Format_ISO_Language_To_JSON |
111149242.83333494 ns/iter |
115154239.0000865 ns/iter |
0.97 |
Schema_Bundle_Meta_2020_12 |
2272440.1753202393 ns/iter |
2274635.314934101 ns/iter |
1.00 |
Schema_Frame_Many_Resources_References |
381219343.99998736 ns/iter |
397121193.5000838 ns/iter |
0.96 |
Pointer_Object_Traverse |
51.44495444109233 ns/iter |
51.54459459081578 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
28.155443869010547 ns/iter |
28.136099798919076 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
160.83295644324903 ns/iter |
161.1794461499312 ns/iter |
1.00 |
Pointer_Walker_Schema_ISO_Language |
3484147.901478084 ns/iter |
3567661.87562257 ns/iter |
0.98 |
JSON_Array_Of_Objects_Unique |
428.44914137391135 ns/iter |
416.9641795236369 ns/iter |
1.03 |
JSON_Parse_1 |
33157.51676245433 ns/iter |
33172.45597109915 ns/iter |
1.00 |
JSON_Parse_Real |
44835.30037876986 ns/iter |
46103.74233331018 ns/iter |
0.97 |
JSON_Parse_Decimal |
157982.9925507979 ns/iter |
157746.8348706094 ns/iter |
1.00 |
JSON_Parse_Schema_ISO_Language |
22773623.032259323 ns/iter |
22742299.258065794 ns/iter |
1.00 |
JSON_Fast_Hash_Helm_Chart_Lock |
61.10935797504219 ns/iter |
61.317802701719515 ns/iter |
1.00 |
JSON_Equality_Helm_Chart_Lock |
162.48583463688144 ns/iter |
165.22494398972083 ns/iter |
0.98 |
JSON_String_Equal/10 |
7.507343696002159 ns/iter |
6.572253766220262 ns/iter |
1.14 |
JSON_String_Equal/100 |
7.2104102065791755 ns/iter |
7.212467610484883 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.636530087555014 ns/iter |
0.6223336634436244 ns/iter |
1.02 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.91433735796206 ns/iter |
14.951013019158136 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
2.252738878544926 ns/iter |
2.2525225446480652 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.2555164162777714 ns/iter |
2.2536848875894906 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
1.2493748875873345 ns/iter |
1.2452071747979747 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
12.435434116339389 ns/iter |
12.426356057641554 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
2.4884064119487337 ns/iter |
2.487557638170495 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
2.49058259578785 ns/iter |
2.489883638067586 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
2.487155578436307 ns/iter |
2.48686673161199 ns/iter |
1.00 |
Regex_Lower_S_Or_Upper_S_Asterisk |
3.4200161552013415 ns/iter |
3.41994880626423 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.4223196714045545 ns/iter |
3.420873186744974 ns/iter |
1.00 |
Regex_Period_Asterisk |
3.425546652070601 ns/iter |
3.4200430874801886 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
3.4220075493566133 ns/iter |
3.421226308651693 ns/iter |
1.00 |
Regex_Period_Plus |
3.41969014342357 ns/iter |
3.428665580191948 ns/iter |
1.00 |
Regex_Period |
3.4198510190297626 ns/iter |
3.4191388899739636 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
3.1099633194839296 ns/iter |
3.4184073544449736 ns/iter |
0.91 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.114325675239642 ns/iter |
3.4185594867772804 ns/iter |
0.91 |
Regex_Caret_Period_Asterisk_Dollar |
3.717777169639263 ns/iter |
4.663679218885883 ns/iter |
0.80 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.730465663790362 ns/iter |
4.66392136624791 ns/iter |
0.80 |
Regex_Caret_X_Hyphen |
10.26850679968391 ns/iter |
13.702898981394247 ns/iter |
0.75 |
Regex_Period_Md_Dollar |
35.899573825805184 ns/iter |
35.71179658166964 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
9.94646495345866 ns/iter |
9.95544441765426 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.659329857629634 ns/iter |
4.662418168760585 ns/iter |
1.00 |
Regex_Nested_Backtrack |
57.695612427747356 ns/iter |
57.87495581609396 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com