Skip to content

Lint wrong scheme in default dialect URIs#2334

Merged
jviotti merged 2 commits intomainfrom
schema-dialect-rules
Apr 3, 2026
Merged

Lint wrong scheme in default dialect URIs#2334
jviotti merged 2 commits intomainfrom
schema-dialect-rules

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Apr 3, 2026

See: sourcemeta/jsonschema#707
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 9ad019b Previous: 3caccc7 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 3.1134406571503646 ns/iter 2.0488173018165146 ns/iter 1.52
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.1148854913021493 ns/iter 2.018838858375731 ns/iter 1.54
Regex_Period_Asterisk 3.1191790735750375 ns/iter 2.016238986685715 ns/iter 1.55
Regex_Group_Period_Asterisk_Group 3.110435947006655 ns/iter 2.0166383842718076 ns/iter 1.54
Regex_Period_Plus 3.109428702325563 ns/iter 2.30432719702374 ns/iter 1.35
Regex_Period 2.9323102881982934 ns/iter 2.3378875478394345 ns/iter 1.25
Regex_Caret_Period_Plus_Dollar 3.1122466295866213 ns/iter 2.305042267754881 ns/iter 1.35
Regex_Caret_Group_Period_Plus_Group_Dollar 3.1091939622434603 ns/iter 2.3037140931097886 ns/iter 1.35
Regex_Caret_Period_Asterisk_Dollar 3.421597525265804 ns/iter 2.0152670017739474 ns/iter 1.70
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.422373880064328 ns/iter 2.016758908891568 ns/iter 1.70
Regex_Caret_X_Hyphen 12.45603358462513 ns/iter 8.674989707131271 ns/iter 1.44
Regex_Period_Md_Dollar 27.500750678892178 ns/iter 25.1658030484655 ns/iter 1.09
Regex_Caret_Slash_Period_Asterisk 7.178797095838162 ns/iter 8.908477937357524 ns/iter 0.81
Regex_Caret_Period_Range_Dollar 4.044669370652742 ns/iter 2.3703199734589364 ns/iter 1.71
Regex_Nested_Backtrack 67.94244813307584 ns/iter 44.440134365008056 ns/iter 1.53
JSON_Array_Of_Objects_Unique 421.1803185348149 ns/iter 344.04299640796324 ns/iter 1.22
JSON_Parse_1 6130.916322691635 ns/iter 5219.8764990240925 ns/iter 1.17
JSON_Parse_Real 11025.3435437532 ns/iter 10051.692263512066 ns/iter 1.10
JSON_Parse_Decimal 12385.076277503187 ns/iter 10234.925760378688 ns/iter 1.21
JSON_Parse_Schema_ISO_Language 3676727.0368422465 ns/iter 3176639.6100919205 ns/iter 1.16
JSON_Fast_Hash_Helm_Chart_Lock 60.36530420088033 ns/iter 49.796890930594685 ns/iter 1.21
JSON_Equality_Helm_Chart_Lock 150.77966648770078 ns/iter 127.10824724974935 ns/iter 1.19
JSON_Divisible_By_Decimal 250.9398126938658 ns/iter 249.06239919992007 ns/iter 1.01
JSON_String_Equal/10 5.925541838645838 ns/iter 4.319493541929733 ns/iter 1.37
JSON_String_Equal/100 11.299206985088162 ns/iter 5.480431966704093 ns/iter 2.06
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9361908582203262 ns/iter 0.6929219883799527 ns/iter 1.35
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.75024060138055 ns/iter 9.503466238142039 ns/iter 1.55
JSON_String_Fast_Hash/10 2.798971094056673 ns/iter 2.3197415708139877 ns/iter 1.21
JSON_String_Fast_Hash/100 2.7999700317547633 ns/iter 2.303899692002729 ns/iter 1.22
JSON_String_Key_Hash/10 2.701712825264804 ns/iter 1.7284908495645535 ns/iter 1.56
JSON_String_Key_Hash/100 9.023907056447092 ns/iter 6.621477824776353 ns/iter 1.36
JSON_Object_Defines_Miss_Same_Length 3.737969433787939 ns/iter 3.4053346681316516 ns/iter 1.10
JSON_Object_Defines_Miss_Too_Small 3.7395203889236575 ns/iter 3.5769507728302714 ns/iter 1.05
JSON_Object_Defines_Miss_Too_Large 3.7434424518473963 ns/iter 3.403746301816586 ns/iter 1.10
Pointer_Object_Traverse 24.99955051354738 ns/iter 24.258214368240257 ns/iter 1.03
Pointer_Object_Try_Traverse 27.974635677409296 ns/iter 28.39344395708532 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 227.45389469246882 ns/iter 164.32681481501592 ns/iter 1.38
Pointer_Walker_Schema_ISO_Language 2993503.1822033627 ns/iter 3013501.274677929 ns/iter 0.99
Pointer_Maybe_Tracked_Deeply_Nested/0 1408481.1656566027 ns/iter 1185234.260869552 ns/iter 1.19
Pointer_Maybe_Tracked_Deeply_Nested/1 1844837.1049866483 ns/iter 1969957.9717515954 ns/iter 0.94
Pointer_Position_Tracker_Get_Deeply_Nested 619.3632389809434 ns/iter 693.8629235705661 ns/iter 0.89
Schema_Frame_WoT_References 5165985.213235511 ns/iter 4603759.717105349 ns/iter 1.12
Schema_Frame_OMC_References 22331552.774194427 ns/iter 19074826.729728237 ns/iter 1.17
Schema_Frame_OMC_Locations 20855406.764704134 ns/iter 17582366.74999978 ns/iter 1.19
Schema_Frame_ISO_Language_Locations 105338183.1666608 ns/iter 90795567.71429713 ns/iter 1.16
Schema_Frame_KrakenD_References 42330835.88235331 ns/iter 35240280.90000115 ns/iter 1.20
Schema_Frame_KrakenD_Reachable 619636813.9999322 ns/iter 715243937.000082 ns/iter 0.87
Schema_Iterator_ISO_Language 2308056.495049527 ns/iter 2148225.7208591932 ns/iter 1.07
Schema_Frame_ISO_Language_Locations_To_JSON 112607297.80001383 ns/iter 107886265.59999557 ns/iter 1.04
Schema_Tracker_ISO_Language 5109567.103703806 ns/iter 4468184.050955885 ns/iter 1.14
Schema_Tracker_ISO_Language_To_JSON 19533727.514288202 ns/iter 19081694.324325792 ns/iter 1.02
Schema_Format_ISO_Language_To_JSON 113520168.49995531 ns/iter 96991600.42857459 ns/iter 1.17
Schema_Bundle_Meta_2020_12 1679495.778845126 ns/iter 1539628.9889849366 ns/iter 1.09
Schema_Frame_Many_Resources_References 386132755.999995 ns/iter 355311750.9999879 ns/iter 1.09
Alterschema_Check_Readibility_ISO_Language_Set_3 223252398.33332944 ns/iter 181222167.75000766 ns/iter 1.23
Alterschema_Check_Readibility_OMC 35484553.39999919 ns/iter 29975642.608692594 ns/iter 1.18
Alterschema_Apply_Readibility_KrakenD 674806893.9999712 ns/iter 496771373.0001151 ns/iter 1.36
Alterschema_Check_Invalid_External_Refs 127440712.99999858 ns/iter 90151296.49999665 ns/iter 1.41
EditorSchema_ForEditor_EmbeddedResources 14267272.459994728 ns/iter 12393821.839288373 ns/iter 1.15
URITemplateRouter_Create 16729.95621394926 ns/iter 12930.899498325116 ns/iter 1.29
URITemplateRouter_Match 171.96287653377772 ns/iter 145.62751668700687 ns/iter 1.18
URITemplateRouter_Match_BasePath 203.70626966364804 ns/iter 164.03899079344296 ns/iter 1.24
URITemplateRouterView_Restore 5027.630617099641 ns/iter 2414.221613196705 ns/iter 2.08
URITemplateRouterView_Match 148.9352993734163 ns/iter 131.08567849245992 ns/iter 1.14
URITemplateRouterView_Match_BasePath 167.77796971721907 ns/iter 148.79609584145533 ns/iter 1.13
URITemplateRouterView_Arguments 454.69372045030843 ns/iter 423.3357773784751 ns/iter 1.07
HTML_Build_Table_100000 63798949.27272289 ns/iter 68634483.40000105 ns/iter 0.93
HTML_Render_Table_100000 5508118.480619938 ns/iter 9480277.315068547 ns/iter 0.58

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 9ad019b Previous: 3caccc7 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.690460833879707 ns/iter 1.63386615168595 ns/iter 1.03
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.708662650982304 ns/iter 1.631899847466431 ns/iter 1.05
Regex_Period_Asterisk 1.689457095429475 ns/iter 1.6562696090033853 ns/iter 1.02
Regex_Group_Period_Asterisk_Group 1.6849317202091323 ns/iter 1.644751698466326 ns/iter 1.02
Regex_Period_Plus 2.017332041324997 ns/iter 1.9756728450567667 ns/iter 1.02
Regex_Period 2.033122967013598 ns/iter 1.9659764526592887 ns/iter 1.03
Regex_Caret_Period_Plus_Dollar 2.0293663004855134 ns/iter 1.9684133550678886 ns/iter 1.03
Regex_Caret_Group_Period_Plus_Group_Dollar 2.0183275374529006 ns/iter 2.065528141134522 ns/iter 0.98
Regex_Caret_Period_Asterisk_Dollar 1.6878165037567991 ns/iter 1.6375497161565913 ns/iter 1.03
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.6974088990496752 ns/iter 1.631455456342967 ns/iter 1.04
Regex_Caret_X_Hyphen 6.398061876982018 ns/iter 6.205790772443062 ns/iter 1.03
Regex_Period_Md_Dollar 20.793454965190087 ns/iter 20.048920038145702 ns/iter 1.04
Regex_Caret_Slash_Period_Asterisk 4.762239399032444 ns/iter 4.663517132756482 ns/iter 1.02
Regex_Caret_Period_Range_Dollar 1.7747774912993706 ns/iter 1.7489415388110516 ns/iter 1.01
Regex_Nested_Backtrack 25.154474918567498 ns/iter 25.232519200530415 ns/iter 1.00
JSON_Array_Of_Objects_Unique 342.47519989837605 ns/iter 334.4261073089374 ns/iter 1.02
JSON_Parse_1 3999.1647094063615 ns/iter 3923.4148961735573 ns/iter 1.02
JSON_Parse_Real 6300.341356971152 ns/iter 6162.752196453903 ns/iter 1.02
JSON_Parse_Decimal 8113.809344976464 ns/iter 8118.983429428267 ns/iter 1.00
JSON_Parse_Schema_ISO_Language 3977747.893939045 ns/iter 4640741.663999506 ns/iter 0.86
JSON_Fast_Hash_Helm_Chart_Lock 58.57445715383562 ns/iter 57.275878601885985 ns/iter 1.02
JSON_Equality_Helm_Chart_Lock 133.47278211647253 ns/iter 132.2397682036498 ns/iter 1.01
JSON_Divisible_By_Decimal 172.497222771168 ns/iter 169.52907003032956 ns/iter 1.02
JSON_String_Equal/10 6.752348543497415 ns/iter 6.574612281718893 ns/iter 1.03
JSON_String_Equal/100 6.442800424432492 ns/iter 6.204392467537861 ns/iter 1.04
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7684150058903634 ns/iter 0.7326546810194113 ns/iter 1.05
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.28322037880613 ns/iter 3.2426542123924604 ns/iter 1.01
JSON_String_Fast_Hash/10 2.380162972622881 ns/iter 2.285212528288198 ns/iter 1.04
JSON_String_Fast_Hash/100 2.0351387134002037 ns/iter 1.957967542386862 ns/iter 1.04
JSON_String_Key_Hash/10 1.3452411356906175 ns/iter 1.3085119983046063 ns/iter 1.03
JSON_String_Key_Hash/100 2.1246854273044886 ns/iter 2.3218449010540123 ns/iter 0.92
JSON_Object_Defines_Miss_Same_Length 2.3544460767653077 ns/iter 2.4116341792168132 ns/iter 0.98
JSON_Object_Defines_Miss_Too_Small 2.3516304114887654 ns/iter 2.319574213336346 ns/iter 1.01
JSON_Object_Defines_Miss_Too_Large 2.355968395025134 ns/iter 2.290481997424362 ns/iter 1.03
Pointer_Object_Traverse 14.918577703116132 ns/iter 14.419412073220583 ns/iter 1.03
Pointer_Object_Try_Traverse 20.302625177702925 ns/iter 19.551220911272893 ns/iter 1.04
Pointer_Push_Back_Pointer_To_Weak_Pointer 154.19921782209613 ns/iter 154.55486849028384 ns/iter 1.00
Pointer_Walker_Schema_ISO_Language 4216606.148810613 ns/iter 4219004.6875006715 ns/iter 1.00
Pointer_Maybe_Tracked_Deeply_Nested/0 1027456.5952715068 ns/iter 978644.7281165803 ns/iter 1.05
Pointer_Maybe_Tracked_Deeply_Nested/1 1460261.8941399704 ns/iter 1288618.7833040108 ns/iter 1.13
Pointer_Position_Tracker_Get_Deeply_Nested 361.7557326239099 ns/iter 353.0995484212998 ns/iter 1.02
Schema_Frame_WoT_References 4711825.503356168 ns/iter 4963320.866142288 ns/iter 0.95
Schema_Frame_OMC_References 25003054.620685425 ns/iter 25582919.777771503 ns/iter 0.98
Schema_Frame_OMC_Locations 26847794.354837112 ns/iter 29069556.535716858 ns/iter 0.92
Schema_Frame_ISO_Language_Locations 76236531.25000374 ns/iter 73951851.14286765 ns/iter 1.03
Schema_Frame_KrakenD_References 45893363.933328144 ns/iter 46939769.46665922 ns/iter 0.98
Schema_Frame_KrakenD_Reachable 347500583.5000502 ns/iter 366712291.4999936 ns/iter 0.95
Schema_Iterator_ISO_Language 1859851.5674302436 ns/iter 1837261.1417109442 ns/iter 1.01
Schema_Frame_ISO_Language_Locations_To_JSON 78277104.124993 ns/iter 95359173.66664155 ns/iter 0.82
Schema_Tracker_ISO_Language 8671044.83544424 ns/iter 9541632.633804062 ns/iter 0.91
Schema_Tracker_ISO_Language_To_JSON 14742730.510640305 ns/iter 13259638.358494036 ns/iter 1.11
Schema_Format_ISO_Language_To_JSON 73862777.88888644 ns/iter 72300579.19998673 ns/iter 1.02
Schema_Bundle_Meta_2020_12 1306937.5353740272 ns/iter 1231128.5124606907 ns/iter 1.06
Schema_Frame_Many_Resources_References 282680437.4999483 ns/iter 272413180.6666416 ns/iter 1.04
Alterschema_Check_Readibility_ISO_Language_Set_3 144158375.00000635 ns/iter 132729966.7999796 ns/iter 1.09
Alterschema_Check_Readibility_OMC 31788746.181818664 ns/iter 36113019.73684309 ns/iter 0.88
Alterschema_Apply_Readibility_KrakenD 472613249.9998812 ns/iter 450041312.9999288 ns/iter 1.05
Alterschema_Check_Invalid_External_Refs 66095886.36363449 ns/iter 63924359.81818132 ns/iter 1.03
EditorSchema_ForEditor_EmbeddedResources 10502320.268649293 ns/iter 9866376.763884293 ns/iter 1.06
URITemplateRouter_Create 16082.496127080209 ns/iter 16065.184494427001 ns/iter 1.00
URITemplateRouter_Match 162.82585407642716 ns/iter 159.26028457145162 ns/iter 1.02
URITemplateRouter_Match_BasePath 195.1928849749683 ns/iter 191.65848857141444 ns/iter 1.02
URITemplateRouterView_Restore 13034.28672429118 ns/iter 11984.443476198345 ns/iter 1.09
URITemplateRouterView_Match 130.00308647211207 ns/iter 130.9794907211171 ns/iter 0.99
URITemplateRouterView_Match_BasePath 150.30800520671602 ns/iter 150.03705751959794 ns/iter 1.00
URITemplateRouterView_Arguments 404.1323998254817 ns/iter 390.196004436118 ns/iter 1.04
HTML_Build_Table_100000 64421867.36363841 ns/iter 67996242.36363012 ns/iter 0.95
HTML_Render_Table_100000 3775976.8086951463 ns/iter 3503247.463878694 ns/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 9ad019b Previous: 3caccc7 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 4.275574375000701 ns/iter 4.109616301981196 ns/iter 1.04
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.9018805803563743 ns/iter 4.084799261569761 ns/iter 0.96
Regex_Period_Asterisk 3.9164314215771063 ns/iter 4.408681875000298 ns/iter 0.89
Regex_Group_Period_Asterisk_Group 3.9037667410722423 ns/iter 4.078756971569599 ns/iter 0.96
Regex_Period_Plus 4.2474256250002895 ns/iter 4.082662194790434 ns/iter 1.04
Regex_Period 4.254908904351213 ns/iter 4.086103132297326 ns/iter 1.04
Regex_Caret_Period_Plus_Dollar 4.254348413279393 ns/iter 3.7744703504024626 ns/iter 1.13
Regex_Caret_Group_Period_Plus_Group_Dollar 4.252418636494343 ns/iter 3.7727813780332258 ns/iter 1.13
Regex_Caret_Period_Asterisk_Dollar 3.9298370535715117 ns/iter 4.078636837640523 ns/iter 0.96
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.9346874999995105 ns/iter 4.083070766219231 ns/iter 0.96
Regex_Caret_X_Hyphen 6.775797321430283 ns/iter 7.5500901785708106 ns/iter 0.90
Regex_Period_Md_Dollar 34.36651981011271 ns/iter 37.653052899052334 ns/iter 0.91
Regex_Caret_Slash_Period_Asterisk 6.38875982142955 ns/iter 7.21065513392968 ns/iter 0.89
Regex_Caret_Period_Range_Dollar 3.9042684151789433 ns/iter 4.090290989447117 ns/iter 0.95
Regex_Nested_Backtrack 85.94089285714242 ns/iter 97.13834834201432 ns/iter 0.88
JSON_Array_Of_Objects_Unique 534.7058999998353 ns/iter 504.4464000000062 ns/iter 1.06
JSON_Parse_1 7825.512276788008 ns/iter 7901.479910713709 ns/iter 0.99
JSON_Parse_Real 13786.256980995186 ns/iter 15035.887339791128 ns/iter 0.92
JSON_Parse_Decimal 15022.075892855268 ns/iter 15775.63616071436 ns/iter 0.95
JSON_Parse_Schema_ISO_Language 6310316.964286601 ns/iter 6009785.714285596 ns/iter 1.05
JSON_Fast_Hash_Helm_Chart_Lock 74.5442053571464 ns/iter 69.57952678571847 ns/iter 1.07
JSON_Equality_Helm_Chart_Lock 290.9463620112706 ns/iter 260.8717661103977 ns/iter 1.12
JSON_Divisible_By_Decimal 266.75746799582686 ns/iter 252.23278571429222 ns/iter 1.06
JSON_String_Equal/10 12.436343750000134 ns/iter 12.391053571430382 ns/iter 1.00
JSON_String_Equal/100 13.846212661399461 ns/iter 13.932397705660819 ns/iter 0.99
JSON_String_Equal_Small_By_Perfect_Hash/10 1.8196269659101674 ns/iter 2.031936850410799 ns/iter 0.90
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 11.584607812501702 ns/iter 12.976055299213641 ns/iter 0.89
JSON_String_Fast_Hash/10 3.9474859891918825 ns/iter 3.904941167688131 ns/iter 1.01
JSON_String_Fast_Hash/100 3.9163437500008063 ns/iter 4.007438616071874 ns/iter 0.98
JSON_String_Key_Hash/10 3.9178755580352287 ns/iter 4.110748578769835 ns/iter 0.95
JSON_String_Key_Hash/100 17.003316964283904 ns/iter 16.608716517860145 ns/iter 1.02
JSON_Object_Defines_Miss_Same_Length 4.991829000000507 ns/iter 5.040742999999566 ns/iter 0.99
JSON_Object_Defines_Miss_Too_Small 3.945531808035189 ns/iter 3.800084263393241 ns/iter 1.04
JSON_Object_Defines_Miss_Too_Large 3.9127167787275705 ns/iter 3.8001257074999 ns/iter 1.03
Pointer_Object_Traverse 43.88836875000379 ns/iter 41.73583357344184 ns/iter 1.05
Pointer_Object_Try_Traverse 54.649749999998676 ns/iter 51.30345000000034 ns/iter 1.07
Pointer_Push_Back_Pointer_To_Weak_Pointer 159.94917410710386 ns/iter 172.82064043042848 ns/iter 0.93
Pointer_Walker_Schema_ISO_Language 13139544.642858222 ns/iter 12847383.928573208 ns/iter 1.02
Pointer_Maybe_Tracked_Deeply_Nested/0 1972290.9374998207 ns/iter 2083717.4242429186 ns/iter 0.95
Pointer_Maybe_Tracked_Deeply_Nested/1 3096735.1694916403 ns/iter 3292852.582160162 ns/iter 0.94
Pointer_Position_Tracker_Get_Deeply_Nested 649.4678571427366 ns/iter 629.8531249999684 ns/iter 1.03
Schema_Frame_WoT_References 10359489.333332023 ns/iter 9966281.333333123 ns/iter 1.04
Schema_Frame_OMC_References 46376745.45454667 ns/iter 43762906.250009336 ns/iter 1.06
Schema_Frame_OMC_Locations 43959531.25001029 ns/iter 40637088.23530439 ns/iter 1.08
Schema_Frame_ISO_Language_Locations 213977333.33333233 ns/iter 195064799.9999546 ns/iter 1.10
Schema_Frame_KrakenD_References 97470785.71428704 ns/iter 97466333.33333597 ns/iter 1.00
Schema_Frame_KrakenD_Reachable 534538499.99982595 ns/iter 541983099.9999249 ns/iter 0.99
Schema_Iterator_ISO_Language 5324655.35714266 ns/iter 5179427.678571967 ns/iter 1.03
Schema_Frame_ISO_Language_Locations_To_JSON 313988150.0000001 ns/iter 283005250.0000875 ns/iter 1.11
Schema_Tracker_ISO_Language 16393062.222222297 ns/iter 16277317.77777828 ns/iter 1.01
Schema_Tracker_ISO_Language_To_JSON 52359600.00000391 ns/iter 50134763.636378914 ns/iter 1.04
Schema_Format_ISO_Language_To_JSON 210885233.33332887 ns/iter 196579966.66675594 ns/iter 1.07
Schema_Bundle_Meta_2020_12 2953672.3214188702 ns/iter 2865743.3735084655 ns/iter 1.03
Schema_Frame_Many_Resources_References 1543130500.0001886 ns/iter 1493634299.9999397 ns/iter 1.03
Alterschema_Check_Readibility_ISO_Language_Set_3 333942050.0000188 ns/iter 343285550.0000187 ns/iter 0.97
Alterschema_Check_Readibility_OMC 64914618.181815475 ns/iter 59788036.36362913 ns/iter 1.09
Alterschema_Apply_Readibility_KrakenD 1049176399.9998511 ns/iter 1003863700.0000108 ns/iter 1.05
Alterschema_Check_Invalid_External_Refs 142642374.99997988 ns/iter 145607179.99997905 ns/iter 0.98
EditorSchema_ForEditor_EmbeddedResources 31324345.454539653 ns/iter 28646990.90907214 ns/iter 1.09
URITemplateRouter_Create 21143.82500000289 ns/iter 22952.016714064786 ns/iter 0.92
URITemplateRouter_Match 211.49643921893585 ns/iter 208.79685005374571 ns/iter 1.01
URITemplateRouter_Match_BasePath 245.37275000000136 ns/iter 244.30768478706912 ns/iter 1.00
URITemplateRouterView_Restore 24060.05959754872 ns/iter 31325.31696428893 ns/iter 0.77
URITemplateRouterView_Match 158.11020089283747 ns/iter 154.26968750002095 ns/iter 1.02
URITemplateRouterView_Match_BasePath 184.27959681071192 ns/iter 179.64092675364796 ns/iter 1.03
URITemplateRouterView_Arguments 453.04305722063964 ns/iter 452.3898124999448 ns/iter 1.00
HTML_Build_Table_100000 91823642.85714225 ns/iter 87811128.57143722 ns/iter 1.05
HTML_Render_Table_100000 7751647.77777617 ns/iter 7829542.2222229 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 9ad019b Previous: 3caccc7 Ratio
HTML_Build_Table_100000 63361271.36364667 ns/iter 70850220.80000272 ns/iter 0.89
HTML_Render_Table_100000 5569502.688000284 ns/iter 10596840.287875736 ns/iter 0.53
URITemplateRouter_Create 13947.06336488012 ns/iter 11689.300805895586 ns/iter 1.19
URITemplateRouter_Match 169.84955430716624 ns/iter 153.74334513946886 ns/iter 1.10
URITemplateRouter_Match_BasePath 199.51539054290902 ns/iter 171.6848020351052 ns/iter 1.16
URITemplateRouterView_Restore 6077.370189998419 ns/iter 2389.258785790802 ns/iter 2.54
URITemplateRouterView_Match 123.76989638112094 ns/iter 119.41059152032965 ns/iter 1.04
URITemplateRouterView_Match_BasePath 141.03137267873825 ns/iter 134.31217527662432 ns/iter 1.05
URITemplateRouterView_Arguments 489.117618344634 ns/iter 488.58322916262586 ns/iter 1.00
EditorSchema_ForEditor_EmbeddedResources 14132424.061212339 ns/iter 12980764.685191086 ns/iter 1.09
Alterschema_Check_Readibility_ISO_Language_Set_3 206660129.33331028 ns/iter 182491785.25002208 ns/iter 1.13
Alterschema_Check_Readibility_OMC 33823503.57143575 ns/iter 34445090.000006184 ns/iter 0.98
Alterschema_Apply_Readibility_KrakenD 568213228.0001042 ns/iter 541349476.9998124 ns/iter 1.05
Alterschema_Check_Invalid_External_Refs 120420958.49998683 ns/iter 95328127.87500688 ns/iter 1.26
Schema_Frame_WoT_References 5445937.751938948 ns/iter 5017915.3857145915 ns/iter 1.09
Schema_Frame_OMC_References 22064175.062503465 ns/iter 21194386.48484599 ns/iter 1.04
Schema_Frame_OMC_Locations 20436101.029411156 ns/iter 19881926.771423813 ns/iter 1.03
Schema_Frame_ISO_Language_Locations 101448987.57143243 ns/iter 97637549.28569922 ns/iter 1.04
Schema_Frame_KrakenD_References 39447613.49998771 ns/iter 39120367.166661814 ns/iter 1.01
Schema_Frame_KrakenD_Reachable 534489914.0002326 ns/iter 761721121.0001642 ns/iter 0.70
Schema_Iterator_ISO_Language 2649681.1584906336 ns/iter 2497851.4487628746 ns/iter 1.06
Schema_Frame_ISO_Language_Locations_To_JSON 219408771.33336774 ns/iter 206115631.49998346 ns/iter 1.06
Schema_Tracker_ISO_Language 4920864.499999432 ns/iter 5247070.778570365 ns/iter 0.94
Schema_Tracker_ISO_Language_To_JSON 23028178.19355046 ns/iter 24380269.862063117 ns/iter 0.94
Schema_Format_ISO_Language_To_JSON 107232254.83335833 ns/iter 101937723.57141435 ns/iter 1.05
Schema_Bundle_Meta_2020_12 1835497.4685934018 ns/iter 1709901.6536576527 ns/iter 1.07
Schema_Frame_Many_Resources_References 376884295.5000764 ns/iter 363504489.9999684 ns/iter 1.04
Pointer_Object_Traverse 28.378067625383867 ns/iter 26.610238331454106 ns/iter 1.07
Pointer_Object_Try_Traverse 30.730469770185458 ns/iter 27.48324242967526 ns/iter 1.12
Pointer_Push_Back_Pointer_To_Weak_Pointer 142.20307295987647 ns/iter 156.13158380161155 ns/iter 0.91
Pointer_Walker_Schema_ISO_Language 3421706.1990295975 ns/iter 3302473.5000006277 ns/iter 1.04
Pointer_Maybe_Tracked_Deeply_Nested/0 1572957.3542603655 ns/iter 1440552.4887061864 ns/iter 1.09
Pointer_Maybe_Tracked_Deeply_Nested/1 1849173.7639253105 ns/iter 1990864.4061627097 ns/iter 0.93
Pointer_Position_Tracker_Get_Deeply_Nested 409.7233791809375 ns/iter 420.99781623591036 ns/iter 0.97
JSON_Array_Of_Objects_Unique 405.09125591451897 ns/iter 325.4599636174965 ns/iter 1.24
JSON_Parse_1 8072.336121646933 ns/iter 6947.661308806383 ns/iter 1.16
JSON_Parse_Real 12188.80747186518 ns/iter 11315.195531801153 ns/iter 1.08
JSON_Parse_Decimal 18318.632388665977 ns/iter 15011.032020940918 ns/iter 1.22
JSON_Parse_Schema_ISO_Language 4707445.046980695 ns/iter 4273297.527607258 ns/iter 1.10
JSON_Fast_Hash_Helm_Chart_Lock 64.28412915084483 ns/iter 48.90884402462292 ns/iter 1.31
JSON_Equality_Helm_Chart_Lock 159.30818240127823 ns/iter 142.920622497329 ns/iter 1.11
JSON_Divisible_By_Decimal 239.55522387243838 ns/iter 251.8918502199737 ns/iter 0.95
JSON_String_Equal/10 6.0023606419631585 ns/iter 5.599053705976335 ns/iter 1.07
JSON_String_Equal/100 6.6244240352909936 ns/iter 6.7340989351655445 ns/iter 0.98
JSON_String_Equal_Small_By_Perfect_Hash/10 0.6237672764370156 ns/iter 0.825775112117528 ns/iter 0.76
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 19.614607714575254 ns/iter 12.971872070937254 ns/iter 1.51
JSON_String_Fast_Hash/10 1.5605455504794012 ns/iter 1.1530411566232972 ns/iter 1.35
JSON_String_Fast_Hash/100 1.557616312083879 ns/iter 1.1525397462344456 ns/iter 1.35
JSON_String_Key_Hash/10 1.2497801944284583 ns/iter 1.729413447094877 ns/iter 0.72
JSON_String_Key_Hash/100 12.446146007920197 ns/iter 11.847891463342537 ns/iter 1.05
JSON_Object_Defines_Miss_Same_Length 3.112658658764812 ns/iter 3.6417246629392923 ns/iter 0.85
JSON_Object_Defines_Miss_Too_Small 3.4276309508993643 ns/iter 3.038233588576877 ns/iter 1.13
JSON_Object_Defines_Miss_Too_Large 3.427231267223972 ns/iter 3.269723527670188 ns/iter 1.05
Regex_Lower_S_Or_Upper_S_Asterisk 1.5573796119967895 ns/iter 1.4404533744688297 ns/iter 1.08
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.556155931667733 ns/iter 1.7282097885501264 ns/iter 0.90
Regex_Period_Asterisk 1.557980983941673 ns/iter 1.740684877918951 ns/iter 0.90
Regex_Group_Period_Asterisk_Group 1.557068281130742 ns/iter 1.731299241840533 ns/iter 0.90
Regex_Period_Plus 1.5624956010137234 ns/iter 1.7294712646443577 ns/iter 0.90
Regex_Period 1.5590268215575982 ns/iter 1.7292502145387192 ns/iter 0.90
Regex_Caret_Period_Plus_Dollar 1.556288844894296 ns/iter 1.7286542122272592 ns/iter 0.90
Regex_Caret_Group_Period_Plus_Group_Dollar 1.2461607025303671 ns/iter 1.4412945040276757 ns/iter 0.86
Regex_Caret_Period_Asterisk_Dollar 1.246809982149388 ns/iter 1.4424747810587104 ns/iter 0.86
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.2449896746783868 ns/iter 1.4452338004611944 ns/iter 0.86
Regex_Caret_X_Hyphen 12.140613012008988 ns/iter 8.355923075659467 ns/iter 1.45
Regex_Period_Md_Dollar 29.825262498224802 ns/iter 24.01127708735402 ns/iter 1.24
Regex_Caret_Slash_Period_Asterisk 4.670056900005107 ns/iter 8.064489513346242 ns/iter 0.58
Regex_Caret_Period_Range_Dollar 1.5591251196913385 ns/iter 1.44084104568652 ns/iter 1.08
Regex_Nested_Backtrack 48.74255829584784 ns/iter 42.30979314679764 ns/iter 1.15

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the schema-dialect-rules branch from a537c42 to 3884230 Compare April 3, 2026 15:29
@jviotti jviotti marked this pull request as ready for review April 3, 2026 15:31
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 13 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="test/alterschema/alterschema_lint_draft7_test.cc">

<violation number="1" location="test/alterschema/alterschema_lint_draft7_test.cc:3789">
P3: This test duplicates the previous `draft_official_dialect_with_https_without_fragment` test with identical input and assertions. Remove the duplicate or change it to cover a distinct case to avoid redundant test maintenance.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread test/alterschema/alterschema_lint_draft7_test.cc
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 30f46ee into main Apr 3, 2026
13 checks passed
@jviotti jviotti deleted the schema-dialect-rules branch April 3, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant