Expose the base path, if any, on the router view#2336
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/core/uritemplate/uritemplate_router_view.cc">
<violation number="1" location="src/core/uritemplate/uritemplate_router_view.cc:639">
P1: Validate `string_table_offset` and `arguments_offset` before pointer arithmetic in `base_path()` to avoid out-of-bounds/underflow on malformed data.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 6905cd1 | Previous: 30f46ee | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.5896184995993996 ns/iter |
2.2218026720463597 ns/iter |
0.72 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.5785473805290402 ns/iter |
2.2257752643205153 ns/iter |
0.71 |
Regex_Period_Asterisk |
1.5763160196683916 ns/iter |
2.295296986387033 ns/iter |
0.69 |
Regex_Group_Period_Asterisk_Group |
1.6181942985409459 ns/iter |
2.0723630786365104 ns/iter |
0.78 |
Regex_Period_Plus |
1.9066714564825578 ns/iter |
2.325694447023069 ns/iter |
0.82 |
Regex_Period |
1.8952558957171057 ns/iter |
2.844837227501366 ns/iter |
0.67 |
Regex_Caret_Period_Plus_Dollar |
1.8906546411338947 ns/iter |
2.7824717770630767 ns/iter |
0.68 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.8912361606629102 ns/iter |
2.729817976998011 ns/iter |
0.69 |
Regex_Caret_Period_Asterisk_Dollar |
1.5797289886742902 ns/iter |
2.0558551027745255 ns/iter |
0.77 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.5800476156214889 ns/iter |
1.98880359024982 ns/iter |
0.79 |
Regex_Caret_X_Hyphen |
6.276129892409034 ns/iter |
6.959121990280035 ns/iter |
0.90 |
Regex_Period_Md_Dollar |
17.189390372295737 ns/iter |
21.408194161732652 ns/iter |
0.80 |
Regex_Caret_Slash_Period_Asterisk |
4.493147317863447 ns/iter |
5.040952768632916 ns/iter |
0.89 |
Regex_Caret_Period_Range_Dollar |
1.6567607988240867 ns/iter |
2.1367010118396235 ns/iter |
0.78 |
Regex_Nested_Backtrack |
23.545984338968577 ns/iter |
33.51611131013647 ns/iter |
0.70 |
JSON_Array_Of_Objects_Unique |
316.2199447271199 ns/iter |
423.37203069864586 ns/iter |
0.75 |
JSON_Parse_1 |
3705.033794771336 ns/iter |
5332.408564841491 ns/iter |
0.69 |
JSON_Parse_Real |
6061.722570518135 ns/iter |
8398.770655973203 ns/iter |
0.72 |
JSON_Parse_Decimal |
7631.827626002989 ns/iter |
10244.377771474508 ns/iter |
0.74 |
JSON_Parse_Schema_ISO_Language |
3217071.22649568 ns/iter |
7365641.6015621675 ns/iter |
0.44 |
JSON_Fast_Hash_Helm_Chart_Lock |
55.62706566921761 ns/iter |
68.14282320395414 ns/iter |
0.82 |
JSON_Equality_Helm_Chart_Lock |
120.92959466900489 ns/iter |
164.87219856407947 ns/iter |
0.73 |
JSON_Divisible_By_Decimal |
177.83137998483173 ns/iter |
240.27730940372493 ns/iter |
0.74 |
JSON_String_Equal/10 |
5.982170200755337 ns/iter |
8.362457401063702 ns/iter |
0.72 |
JSON_String_Equal/100 |
5.723492966294831 ns/iter |
7.650074958464313 ns/iter |
0.75 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.7151752160783309 ns/iter |
0.870815733747951 ns/iter |
0.82 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.080077185433871 ns/iter |
4.413096001849851 ns/iter |
0.70 |
JSON_String_Fast_Hash/10 |
2.212138692103694 ns/iter |
2.9060769205636436 ns/iter |
0.76 |
JSON_String_Fast_Hash/100 |
1.8901408514469413 ns/iter |
2.6260991568417347 ns/iter |
0.72 |
JSON_String_Key_Hash/10 |
1.2794376614569332 ns/iter |
1.5959242097189628 ns/iter |
0.80 |
JSON_String_Key_Hash/100 |
1.988917323154577 ns/iter |
2.9585772353627586 ns/iter |
0.67 |
JSON_Object_Defines_Miss_Same_Length |
2.203990023658959 ns/iter |
2.966011169921861 ns/iter |
0.74 |
JSON_Object_Defines_Miss_Too_Small |
2.2125265248611785 ns/iter |
2.868996888352823 ns/iter |
0.77 |
JSON_Object_Defines_Miss_Too_Large |
2.2633403829608363 ns/iter |
2.936874416041347 ns/iter |
0.77 |
Pointer_Object_Traverse |
14.943348346833755 ns/iter |
18.994308396408137 ns/iter |
0.79 |
Pointer_Object_Try_Traverse |
18.7605130741295 ns/iter |
24.530311514845064 ns/iter |
0.76 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
143.81885955429945 ns/iter |
171.3230937952205 ns/iter |
0.84 |
Pointer_Walker_Schema_ISO_Language |
3621679.255208695 ns/iter |
4755984.8211916 ns/iter |
0.76 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
921304.7559448873 ns/iter |
1110620.463190051 ns/iter |
0.83 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1218428.420608114 ns/iter |
1472985.7860169108 ns/iter |
0.83 |
Pointer_Position_Tracker_Get_Deeply_Nested |
331.16036295858567 ns/iter |
400.63536723891934 ns/iter |
0.83 |
Schema_Frame_WoT_References |
4281739.263802994 ns/iter |
6871480.477476686 ns/iter |
0.62 |
Schema_Frame_OMC_References |
21257363.636364475 ns/iter |
52544583.36842043 ns/iter |
0.40 |
Schema_Frame_OMC_Locations |
20102194.057147115 ns/iter |
34370093.28571267 ns/iter |
0.58 |
Schema_Frame_ISO_Language_Locations |
68736283.30001792 ns/iter |
112185972.16668512 ns/iter |
0.61 |
Schema_Frame_KrakenD_References |
44153455.53334191 ns/iter |
71845816.69999942 ns/iter |
0.61 |
Schema_Frame_KrakenD_Reachable |
322892415.9999451 ns/iter |
532494875.999987 ns/iter |
0.61 |
Schema_Iterator_ISO_Language |
1665781.8396224212 ns/iter |
3170549.0924094 ns/iter |
0.53 |
Schema_Frame_ISO_Language_Locations_To_JSON |
65973541.62499869 ns/iter |
106386130.85715017 ns/iter |
0.62 |
Schema_Tracker_ISO_Language |
7442209.239128339 ns/iter |
12082212.411764974 ns/iter |
0.62 |
Schema_Tracker_ISO_Language_To_JSON |
12690745.535715159 ns/iter |
18680029.937499397 ns/iter |
0.68 |
Schema_Format_ISO_Language_To_JSON |
67056155.27274942 ns/iter |
90093065.42858602 ns/iter |
0.74 |
Schema_Bundle_Meta_2020_12 |
1193341.7331101275 ns/iter |
1803232.781610561 ns/iter |
0.66 |
Schema_Frame_Many_Resources_References |
247250944.33332136 ns/iter |
434457728.99997336 ns/iter |
0.57 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
128561108.20002869 ns/iter |
175101166.49998507 ns/iter |
0.73 |
Alterschema_Check_Readibility_OMC |
28205923.320001602 ns/iter |
50545421.58823364 ns/iter |
0.56 |
Alterschema_Apply_Readibility_KrakenD |
437343687.5000607 ns/iter |
604413541.9997474 ns/iter |
0.72 |
Alterschema_Check_Invalid_External_Refs |
59442916.66668278 ns/iter |
91113000.00001523 ns/iter |
0.65 |
EditorSchema_ForEditor_EmbeddedResources |
9526885.16214973 ns/iter |
14413085.341469169 ns/iter |
0.66 |
URITemplateRouter_Create |
15058.084215055596 ns/iter |
22455.81312163153 ns/iter |
0.67 |
URITemplateRouter_Match |
152.06648746050632 ns/iter |
226.53634318452825 ns/iter |
0.67 |
URITemplateRouter_Match_BasePath |
179.92789390444972 ns/iter |
225.08069757671154 ns/iter |
0.80 |
URITemplateRouterView_Restore |
11477.286771248288 ns/iter |
15244.592204601491 ns/iter |
0.75 |
URITemplateRouterView_Match |
123.68742061227137 ns/iter |
173.30602084221812 ns/iter |
0.71 |
URITemplateRouterView_Match_BasePath |
140.05440729401298 ns/iter |
197.4443432426317 ns/iter |
0.71 |
URITemplateRouterView_Arguments |
378.16149136203995 ns/iter |
531.3845899593722 ns/iter |
0.71 |
HTML_Build_Table_100000 |
59691861.11110503 ns/iter |
83912307.37498745 ns/iter |
0.71 |
HTML_Render_Table_100000 |
2742292.738970524 ns/iter |
4987305.6447369745 ns/iter |
0.55 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 6905cd1 | Previous: 30f46ee | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
3.158208861536604 ns/iter |
3.1134568007322034 ns/iter |
1.01 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
3.113440926696949 ns/iter |
3.110945735630948 ns/iter |
1.00 |
Regex_Period_Asterisk |
3.112298016036122 ns/iter |
3.109782226178792 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
3.1132576796193643 ns/iter |
3.110889204263579 ns/iter |
1.00 |
Regex_Period_Plus |
3.109342737942626 ns/iter |
3.109879135469962 ns/iter |
1.00 |
Regex_Period |
2.9283053755430832 ns/iter |
3.1106287605794725 ns/iter |
0.94 |
Regex_Caret_Period_Plus_Dollar |
3.115402954896455 ns/iter |
3.109989514751153 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.1146707932597497 ns/iter |
3.1100189557031253 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
3.1109780702731915 ns/iter |
3.1208074303694286 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.112697801246513 ns/iter |
3.1103293404258747 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
12.453532171421745 ns/iter |
10.271338607615608 ns/iter |
1.21 |
Regex_Period_Md_Dollar |
27.677061650331225 ns/iter |
27.397541039629612 ns/iter |
1.01 |
Regex_Caret_Slash_Period_Asterisk |
6.228858012125204 ns/iter |
6.227305507295629 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.0494272394661195 ns/iter |
4.0456902391236635 ns/iter |
1.00 |
Regex_Nested_Backtrack |
50.45147603402515 ns/iter |
65.34884734633285 ns/iter |
0.77 |
JSON_Array_Of_Objects_Unique |
404.7024967072365 ns/iter |
419.43769939384816 ns/iter |
0.96 |
JSON_Parse_1 |
5901.305727931946 ns/iter |
6105.787820572362 ns/iter |
0.97 |
JSON_Parse_Real |
10787.995621995786 ns/iter |
10971.174355741483 ns/iter |
0.98 |
JSON_Parse_Decimal |
11581.522175856493 ns/iter |
12085.56991360925 ns/iter |
0.96 |
JSON_Parse_Schema_ISO_Language |
3614714.544041134 ns/iter |
3669655.02631609 ns/iter |
0.99 |
JSON_Fast_Hash_Helm_Chart_Lock |
61.886797603317966 ns/iter |
60.39033225582332 ns/iter |
1.02 |
JSON_Equality_Helm_Chart_Lock |
163.87610779825448 ns/iter |
154.47868300198252 ns/iter |
1.06 |
JSON_Divisible_By_Decimal |
236.77742349853838 ns/iter |
252.81939627121577 ns/iter |
0.94 |
JSON_String_Equal/10 |
7.163934138438149 ns/iter |
5.91654252990254 ns/iter |
1.21 |
JSON_String_Equal/100 |
6.865825455705114 ns/iter |
6.540451454945272 ns/iter |
1.05 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9365440115152441 ns/iter |
0.935601173157776 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
14.757393713385135 ns/iter |
10.269936642094006 ns/iter |
1.44 |
JSON_String_Fast_Hash/10 |
2.80158705200948 ns/iter |
2.8013452874115314 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.804024055180237 ns/iter |
2.800030165723859 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
2.7023996831782946 ns/iter |
2.18098817777414 ns/iter |
1.24 |
JSON_String_Key_Hash/100 |
9.027062692946522 ns/iter |
6.5449649417775895 ns/iter |
1.38 |
JSON_Object_Defines_Miss_Same_Length |
3.7565266581437498 ns/iter |
3.7386873026145393 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.752094336615563 ns/iter |
3.739741259787386 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.7443757395045316 ns/iter |
3.7396664526104972 ns/iter |
1.00 |
Pointer_Object_Traverse |
25.235926432586172 ns/iter |
24.996264724368462 ns/iter |
1.01 |
Pointer_Object_Try_Traverse |
28.80858573218389 ns/iter |
27.986556793545063 ns/iter |
1.03 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
226.23523481679567 ns/iter |
156.0711303234423 ns/iter |
1.45 |
Pointer_Walker_Schema_ISO_Language |
3021385.0085108285 ns/iter |
3034571.034632019 ns/iter |
1.00 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1419249.8924949195 ns/iter |
1393257.823412879 ns/iter |
1.02 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1804058.088311779 ns/iter |
1888936.2903225461 ns/iter |
0.96 |
Pointer_Position_Tracker_Get_Deeply_Nested |
584.94048683772 ns/iter |
641.3950988416154 ns/iter |
0.91 |
Schema_Frame_WoT_References |
5143572.459854007 ns/iter |
5165129.713235468 ns/iter |
1.00 |
Schema_Frame_OMC_References |
21317984.18181943 ns/iter |
21058678.606061332 ns/iter |
1.01 |
Schema_Frame_OMC_Locations |
19615037.194442824 ns/iter |
19427255.72222217 ns/iter |
1.01 |
Schema_Frame_ISO_Language_Locations |
99804746.16666394 ns/iter |
98874696.49999048 ns/iter |
1.01 |
Schema_Frame_KrakenD_References |
40380954.23529472 ns/iter |
39276865.77777776 ns/iter |
1.03 |
Schema_Frame_KrakenD_Reachable |
598667928.0000544 ns/iter |
581535522.0000811 ns/iter |
1.03 |
Schema_Iterator_ISO_Language |
2286288.943708612 ns/iter |
2332473.861386059 ns/iter |
0.98 |
Schema_Frame_ISO_Language_Locations_To_JSON |
111900702.80001691 ns/iter |
109390739.4000098 ns/iter |
1.02 |
Schema_Tracker_ISO_Language |
4847174.631944679 ns/iter |
4928466.999999855 ns/iter |
0.98 |
Schema_Tracker_ISO_Language_To_JSON |
19271534.083331846 ns/iter |
19435093.27777646 ns/iter |
0.99 |
Schema_Format_ISO_Language_To_JSON |
109302640.8333344 ns/iter |
107301935.33335827 ns/iter |
1.02 |
Schema_Bundle_Meta_2020_12 |
1661238.1966835367 ns/iter |
1676556.5727913897 ns/iter |
0.99 |
Schema_Frame_Many_Resources_References |
380343401.00000465 ns/iter |
377071124.4999916 ns/iter |
1.01 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
219453498.66666675 ns/iter |
220670354.0000111 ns/iter |
0.99 |
Alterschema_Check_Readibility_OMC |
34188787.7500028 ns/iter |
33605748.142852984 ns/iter |
1.02 |
Alterschema_Apply_Readibility_KrakenD |
630990144.9999416 ns/iter |
611184269.999967 ns/iter |
1.03 |
Alterschema_Check_Invalid_External_Refs |
125076662.16667227 ns/iter |
123022444.49999005 ns/iter |
1.02 |
EditorSchema_ForEditor_EmbeddedResources |
13825357.745105851 ns/iter |
13739426.96078106 ns/iter |
1.01 |
URITemplateRouter_Create |
16418.923876073524 ns/iter |
16315.39531615944 ns/iter |
1.01 |
URITemplateRouter_Match |
172.66929458668136 ns/iter |
173.27975467350313 ns/iter |
1.00 |
URITemplateRouter_Match_BasePath |
207.89364506158378 ns/iter |
197.6774050760198 ns/iter |
1.05 |
URITemplateRouterView_Restore |
4984.990650952609 ns/iter |
4937.508842846528 ns/iter |
1.01 |
URITemplateRouterView_Match |
141.2119728016946 ns/iter |
145.96752183199848 ns/iter |
0.97 |
URITemplateRouterView_Match_BasePath |
162.30378971787616 ns/iter |
168.38231272610074 ns/iter |
0.96 |
URITemplateRouterView_Arguments |
477.6995322238065 ns/iter |
472.81196577150894 ns/iter |
1.01 |
HTML_Build_Table_100000 |
64157123.818187185 ns/iter |
62872782.090907596 ns/iter |
1.02 |
HTML_Render_Table_100000 |
5550439.253846224 ns/iter |
5354432.88235292 ns/iter |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
Details
| Benchmark suite | Current: 6905cd1 | Previous: b6640a8 | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
4.204243534293624 ns/iter |
4.1084155430506755 ns/iter |
1.02 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
4.606788052235273 ns/iter |
4.083483980504903 ns/iter |
1.13 |
Regex_Period_Asterisk |
4.799498693573178 ns/iter |
4.396056250001834 ns/iter |
1.09 |
Regex_Group_Period_Asterisk_Group |
4.097698087674468 ns/iter |
4.079760989427979 ns/iter |
1.00 |
Regex_Period_Plus |
4.742391071429454 ns/iter |
4.71222767857122 ns/iter |
1.01 |
Regex_Period |
4.730083269485938 ns/iter |
4.707028135509071 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
4.4108268749994295 ns/iter |
4.392972499999814 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
4.479018749999852 ns/iter |
4.39074887314582 ns/iter |
1.02 |
Regex_Caret_Period_Asterisk_Dollar |
4.122266927005232 ns/iter |
4.089198176945219 ns/iter |
1.01 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
4.088623043014631 ns/iter |
4.082747209821491 ns/iter |
1.00 |
Regex_Caret_X_Hyphen |
7.227715401784605 ns/iter |
7.212637276785878 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
34.75213213336127 ns/iter |
34.90334173056119 ns/iter |
1.00 |
Regex_Caret_Slash_Period_Asterisk |
6.920036607143386 ns/iter |
6.8957571428549205 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
4.101903459822356 ns/iter |
4.083793891220148 ns/iter |
1.00 |
Regex_Nested_Backtrack |
102.7678213049892 ns/iter |
102.73423437496375 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
467.44215791114857 ns/iter |
481.3858801892092 ns/iter |
0.97 |
JSON_Parse_1 |
8042.530133928035 ns/iter |
7987.3482142848015 ns/iter |
1.01 |
JSON_Parse_Real |
15841.733984825241 ns/iter |
15723.167410714366 ns/iter |
1.01 |
JSON_Parse_Decimal |
15657.676339288735 ns/iter |
15638.9308035695 ns/iter |
1.00 |
JSON_Parse_Schema_ISO_Language |
6779126.7857139865 ns/iter |
5972053.000000414 ns/iter |
1.14 |
JSON_Fast_Hash_Helm_Chart_Lock |
58.31266000000142 ns/iter |
57.50336000000971 ns/iter |
1.01 |
JSON_Equality_Helm_Chart_Lock |
258.9256071428281 ns/iter |
257.48648917345673 ns/iter |
1.01 |
JSON_Divisible_By_Decimal |
243.7707857142511 ns/iter |
248.18292857146062 ns/iter |
0.98 |
JSON_String_Equal/10 |
12.236501785715907 ns/iter |
12.21660714285885 ns/iter |
1.00 |
JSON_String_Equal/100 |
12.888332142856436 ns/iter |
12.863926785712465 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
1.8794233945350551 ns/iter |
1.8802668766790633 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
12.861062219370822 ns/iter |
12.865184540776065 ns/iter |
1.00 |
JSON_String_Fast_Hash/10 |
3.132466517857527 ns/iter |
3.1344642857139404 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
3.1698982142864502 ns/iter |
3.1677924107153133 ns/iter |
1.00 |
JSON_String_Key_Hash/10 |
4.086122864438717 ns/iter |
4.083736435863509 ns/iter |
1.00 |
JSON_String_Key_Hash/100 |
14.353690114492682 ns/iter |
14.366637659075879 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Same_Length |
5.020417999999154 ns/iter |
5.018022999997811 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7659374932747043 ns/iter |
3.7607764218575386 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
3.768181064699452 ns/iter |
3.7608942789962336 ns/iter |
1.00 |
Pointer_Object_Traverse |
42.25932619452912 ns/iter |
42.21917199399339 ns/iter |
1.00 |
Pointer_Object_Try_Traverse |
54.54007142859041 ns/iter |
52.432625000002574 ns/iter |
1.04 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
150.34712275235725 ns/iter |
149.5165111822866 ns/iter |
1.01 |
Pointer_Walker_Schema_ISO_Language |
11413971.87500104 ns/iter |
11397723.214283165 ns/iter |
1.00 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
2014664.214046991 ns/iter |
1995341.7857144424 ns/iter |
1.01 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
3092731.6964286836 ns/iter |
3112792.410714097 ns/iter |
0.99 |
Pointer_Position_Tracker_Get_Deeply_Nested |
613.5016741069929 ns/iter |
615.5002232140256 ns/iter |
1.00 |
Schema_Frame_WoT_References |
9853181.249997789 ns/iter |
9850121.333335362 ns/iter |
1.00 |
Schema_Frame_OMC_References |
41699476.470579185 ns/iter |
42867329.41176631 ns/iter |
0.97 |
Schema_Frame_OMC_Locations |
39109968.42104826 ns/iter |
40269711.11109863 ns/iter |
0.97 |
Schema_Frame_ISO_Language_Locations |
183609699.99997678 ns/iter |
189119600.00002638 ns/iter |
0.97 |
Schema_Frame_KrakenD_References |
86175811.11111072 ns/iter |
87423328.57140614 ns/iter |
0.99 |
Schema_Frame_KrakenD_Reachable |
478671699.9999499 ns/iter |
492468200.0005305 ns/iter |
0.97 |
Schema_Iterator_ISO_Language |
4915556.249999652 ns/iter |
4902763.4482752485 ns/iter |
1.00 |
Schema_Frame_ISO_Language_Locations_To_JSON |
284553999.9999573 ns/iter |
285066550.0000105 ns/iter |
1.00 |
Schema_Tracker_ISO_Language |
15936580.000000808 ns/iter |
15894104.44444689 ns/iter |
1.00 |
Schema_Tracker_ISO_Language_To_JSON |
47416185.71428522 ns/iter |
49059500.00002122 ns/iter |
0.97 |
Schema_Format_ISO_Language_To_JSON |
181572833.33342397 ns/iter |
188502266.6668495 ns/iter |
0.96 |
Schema_Bundle_Meta_2020_12 |
2846055.421682412 ns/iter |
2843966.6666727643 ns/iter |
1.00 |
Schema_Frame_Many_Resources_References |
1458074599.999918 ns/iter |
1452395199.9999554 ns/iter |
1.00 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
304472949.9999903 ns/iter |
310931600.0000035 ns/iter |
0.98 |
Alterschema_Check_Readibility_OMC |
58250672.727271274 ns/iter |
58948479.99998091 ns/iter |
0.99 |
Alterschema_Apply_Readibility_KrakenD |
927643999.9998729 ns/iter |
973018999.9995673 ns/iter |
0.95 |
Alterschema_Check_Invalid_External_Refs |
142545819.99998662 ns/iter |
144375599.99996665 ns/iter |
0.99 |
EditorSchema_ForEditor_EmbeddedResources |
27600416.00000477 ns/iter |
26958407.692308564 ns/iter |
1.02 |
URITemplateRouter_Create |
24835.564285711243 ns/iter |
23446.532962799603 ns/iter |
1.06 |
URITemplateRouter_Match |
206.6235577400477 ns/iter |
205.9487812499583 ns/iter |
1.00 |
URITemplateRouter_Match_BasePath |
247.15535714286875 ns/iter |
238.38707142869808 ns/iter |
1.04 |
URITemplateRouterView_Restore |
30610.308035718957 ns/iter |
29183.95628580222 ns/iter |
1.05 |
URITemplateRouterView_Match |
166.70495535718388 ns/iter |
151.44589285713192 ns/iter |
1.10 |
URITemplateRouterView_Match_BasePath |
195.11880634836575 ns/iter |
180.03472857376747 ns/iter |
1.08 |
URITemplateRouterView_Arguments |
448.66710907749734 ns/iter |
448.67393749996154 ns/iter |
1.00 |
HTML_Build_Table_100000 |
86922777.77777235 ns/iter |
86715785.71426965 ns/iter |
1.00 |
HTML_Render_Table_100000 |
7533153.333333253 ns/iter |
7858626.666666169 ns/iter |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 6905cd1 | Previous: b6640a8 | Ratio |
|---|---|---|---|
HTML_Build_Table_100000 |
63539360.99999786 ns/iter |
69470421.50000015 ns/iter |
0.91 |
HTML_Render_Table_100000 |
5545895.608000137 ns/iter |
10201523.956522474 ns/iter |
0.54 |
URITemplateRouter_Create |
14172.403249869993 ns/iter |
11374.413900971937 ns/iter |
1.25 |
URITemplateRouter_Match |
175.94846324028208 ns/iter |
153.71338875718396 ns/iter |
1.14 |
URITemplateRouter_Match_BasePath |
200.9598739807382 ns/iter |
172.0900568023186 ns/iter |
1.17 |
URITemplateRouterView_Restore |
6252.8272400004425 ns/iter |
2466.2273558419993 ns/iter |
2.54 |
URITemplateRouterView_Match |
126.3316020885989 ns/iter |
118.80731269790788 ns/iter |
1.06 |
URITemplateRouterView_Match_BasePath |
145.25543933389184 ns/iter |
134.06644879925022 ns/iter |
1.08 |
URITemplateRouterView_Arguments |
483.6801543938613 ns/iter |
476.57190697369913 ns/iter |
1.01 |
EditorSchema_ForEditor_EmbeddedResources |
14266967.244895792 ns/iter |
12777675.000001585 ns/iter |
1.12 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
212587478.66666758 ns/iter |
176164472.00003904 ns/iter |
1.21 |
Alterschema_Check_Readibility_OMC |
34547755.150003925 ns/iter |
32649767.81818777 ns/iter |
1.06 |
Alterschema_Apply_Readibility_KrakenD |
586278755.999956 ns/iter |
535906822.99977744 ns/iter |
1.09 |
Alterschema_Check_Invalid_External_Refs |
126100450.16666996 ns/iter |
92999820.75000912 ns/iter |
1.36 |
Schema_Frame_WoT_References |
5543266.212598825 ns/iter |
5007984.553957214 ns/iter |
1.11 |
Schema_Frame_OMC_References |
22614323.741934992 ns/iter |
21165665.000001933 ns/iter |
1.07 |
Schema_Frame_OMC_Locations |
21565959.454543795 ns/iter |
19176605.486490116 ns/iter |
1.12 |
Schema_Frame_ISO_Language_Locations |
108392393.16665803 ns/iter |
91744494.50000566 ns/iter |
1.18 |
Schema_Frame_KrakenD_References |
40317811.00000925 ns/iter |
37983957.000003435 ns/iter |
1.06 |
Schema_Frame_KrakenD_Reachable |
540110874.9999821 ns/iter |
687939862.0001211 ns/iter |
0.79 |
Schema_Iterator_ISO_Language |
2573649.3345588692 ns/iter |
2474654.7711269045 ns/iter |
1.04 |
Schema_Frame_ISO_Language_Locations_To_JSON |
225660748.0000336 ns/iter |
202300022.00006917 ns/iter |
1.12 |
Schema_Tracker_ISO_Language |
4911388.035212363 ns/iter |
4536224.118420538 ns/iter |
1.08 |
Schema_Tracker_ISO_Language_To_JSON |
22516281.838702966 ns/iter |
22563353.800001096 ns/iter |
1.00 |
Schema_Format_ISO_Language_To_JSON |
109989534.66666232 ns/iter |
95704933.14293215 ns/iter |
1.15 |
Schema_Bundle_Meta_2020_12 |
1830029.7968754836 ns/iter |
1719976.485224417 ns/iter |
1.06 |
Schema_Frame_Many_Resources_References |
386679499.0000244 ns/iter |
354219639.0000072 ns/iter |
1.09 |
Pointer_Object_Traverse |
26.411765938356222 ns/iter |
27.122672981797077 ns/iter |
0.97 |
Pointer_Object_Try_Traverse |
27.31234558849668 ns/iter |
28.296835317895574 ns/iter |
0.97 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
134.38566655329493 ns/iter |
154.40901210727787 ns/iter |
0.87 |
Pointer_Walker_Schema_ISO_Language |
3420622.3627448957 ns/iter |
3241804.823255734 ns/iter |
1.06 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1601082.4931193406 ns/iter |
1412342.890243667 ns/iter |
1.13 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
2046829.2163742683 ns/iter |
1701888.9707320873 ns/iter |
1.20 |
Pointer_Position_Tracker_Get_Deeply_Nested |
397.8495534576297 ns/iter |
392.00695051154446 ns/iter |
1.01 |
JSON_Array_Of_Objects_Unique |
415.79223780270735 ns/iter |
335.19333478130045 ns/iter |
1.24 |
JSON_Parse_1 |
7929.422594000933 ns/iter |
6892.31534236226 ns/iter |
1.15 |
JSON_Parse_Real |
12557.778071667166 ns/iter |
11015.584414972547 ns/iter |
1.14 |
JSON_Parse_Decimal |
18370.126742148415 ns/iter |
14400.428591978862 ns/iter |
1.28 |
JSON_Parse_Schema_ISO_Language |
4730254.709460115 ns/iter |
4081010.9534885306 ns/iter |
1.16 |
JSON_Fast_Hash_Helm_Chart_Lock |
71.95050958083074 ns/iter |
54.74275056339287 ns/iter |
1.31 |
JSON_Equality_Helm_Chart_Lock |
158.1375123253867 ns/iter |
135.92267059843388 ns/iter |
1.16 |
JSON_Divisible_By_Decimal |
248.320303174231 ns/iter |
257.6538830067034 ns/iter |
0.96 |
JSON_String_Equal/10 |
6.350605650255982 ns/iter |
5.743316185980317 ns/iter |
1.11 |
JSON_String_Equal/100 |
6.973380213894197 ns/iter |
7.195722591851822 ns/iter |
0.97 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.6234528376639616 ns/iter |
0.8259583902521599 ns/iter |
0.75 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
19.61010327337956 ns/iter |
12.9620641956704 ns/iter |
1.51 |
JSON_String_Fast_Hash/10 |
0.9334324276996476 ns/iter |
1.1525436188210083 ns/iter |
0.81 |
JSON_String_Fast_Hash/100 |
0.9340039174748591 ns/iter |
1.153264669143013 ns/iter |
0.81 |
JSON_String_Key_Hash/10 |
1.2465165070395818 ns/iter |
1.1529417928721564 ns/iter |
1.08 |
JSON_String_Key_Hash/100 |
12.444375263434258 ns/iter |
11.829451311579055 ns/iter |
1.05 |
JSON_Object_Defines_Miss_Same_Length |
3.4248449514050434 ns/iter |
3.007716384505892 ns/iter |
1.14 |
JSON_Object_Defines_Miss_Too_Small |
3.454856490093219 ns/iter |
3.6349564939259356 ns/iter |
0.95 |
JSON_Object_Defines_Miss_Too_Large |
3.4259795085416416 ns/iter |
3.7987453356772205 ns/iter |
0.90 |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.2477075198934846 ns/iter |
1.4398238342450056 ns/iter |
0.87 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.2453309387754845 ns/iter |
1.4407906407425917 ns/iter |
0.86 |
Regex_Period_Asterisk |
1.246320323432946 ns/iter |
1.4413627617873852 ns/iter |
0.86 |
Regex_Group_Period_Asterisk_Group |
1.244776476512216 ns/iter |
1.439861006349446 ns/iter |
0.86 |
Regex_Period_Plus |
1.2443443482436378 ns/iter |
1.4407976911196012 ns/iter |
0.86 |
Regex_Period |
1.2462057538845028 ns/iter |
1.4415296071014676 ns/iter |
0.86 |
Regex_Caret_Period_Plus_Dollar |
1.246038687538252 ns/iter |
1.4409187028066317 ns/iter |
0.86 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.5578303346302624 ns/iter |
1.728560715486061 ns/iter |
0.90 |
Regex_Caret_Period_Asterisk_Dollar |
1.5575583090516945 ns/iter |
1.7313505151144266 ns/iter |
0.90 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.558429698694394 ns/iter |
1.4408177519430254 ns/iter |
1.08 |
Regex_Caret_X_Hyphen |
12.145676721522394 ns/iter |
8.353728858237385 ns/iter |
1.45 |
Regex_Period_Md_Dollar |
29.190488021820464 ns/iter |
23.608229218714076 ns/iter |
1.24 |
Regex_Caret_Slash_Period_Asterisk |
4.978895457441681 ns/iter |
8.061462490454053 ns/iter |
0.62 |
Regex_Caret_Period_Range_Dollar |
1.5574804859144364 ns/iter |
1.7286207777781502 ns/iter |
0.90 |
Regex_Nested_Backtrack |
49.087554000926104 ns/iter |
40.4733201990951 ns/iter |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com