Do not restrict parallelism on Makefile#2396
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Removes the fixed 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| compile: .always | ||
| $(CMAKE) --build ./build --config $(PRESET) --target clang_format | ||
| $(CMAKE) --build ./build --config $(PRESET) --parallel 4 | ||
| $(CMAKE) --build ./build --config $(PRESET) |
There was a problem hiding this comment.
Calling cmake --build without --parallel can make some generators (e.g., Unix Makefiles / MSBuild) fall back to single-threaded builds unless CMAKE_BUILD_PARALLEL_LEVEL/MAKEFLAGS is set; is that intended here? If the goal is only to avoid capping jobs at 4, consider ensuring parallel builds remain enabled while still letting the level be user-controlled.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Makefile">
<violation number="1" location="Makefile:22">
P1: Removing `--parallel` entirely makes the build single-threaded for Make generators. Use `--parallel` (without a number) to allow the native build tool's default parallelism instead of capping at 4.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| compile: .always | ||
| $(CMAKE) --build ./build --config $(PRESET) --target clang_format | ||
| $(CMAKE) --build ./build --config $(PRESET) --parallel 4 | ||
| $(CMAKE) --build ./build --config $(PRESET) |
There was a problem hiding this comment.
P1: Removing --parallel entirely makes the build single-threaded for Make generators. Use --parallel (without a number) to allow the native build tool's default parallelism instead of capping at 4.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Makefile, line 22:
<comment>Removing `--parallel` entirely makes the build single-threaded for Make generators. Use `--parallel` (without a number) to allow the native build tool's default parallelism instead of capping at 4.</comment>
<file context>
@@ -19,7 +19,7 @@ configure: .always
compile: .always
$(CMAKE) --build ./build --config $(PRESET) --target clang_format
- $(CMAKE) --build ./build --config $(PRESET) --parallel 4
+ $(CMAKE) --build ./build --config $(PRESET)
$(CMAKE) --install ./build --prefix ./build/dist --config $(PRESET) --verbose \
--component sourcemeta_core
</file context>
Suggested change
| $(CMAKE) --build ./build --config $(PRESET) | |
| $(CMAKE) --build ./build --config $(PRESET) --parallel |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 7694e27 | Previous: 39431ca | Ratio |
|---|---|---|---|
GZIP_Compress_ISO_Language_Set_3_Locations |
38263198.38888518 ns/iter |
31645454.4999994 ns/iter |
1.21 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
4980160.656934266 ns/iter |
3043628.60434772 ns/iter |
1.64 |
GZIP_Compress_ISO_Language_Set_3_Schema |
2075470.7744808586 ns/iter |
1797243.9203083264 ns/iter |
1.15 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
394693.2934537127 ns/iter |
213019.88355021662 ns/iter |
1.85 |
HTML_Build_Table_100000 |
58310749.91666204 ns/iter |
53309098.46154205 ns/iter |
1.09 |
HTML_Render_Table_100000 |
1792043.36989773 ns/iter |
1937346.49614403 ns/iter |
0.92 |
JSONL_Parse_Large |
13126037.301885672 ns/iter |
9719847.819444755 ns/iter |
1.35 |
JSONL_Parse_Large_GZIP |
14264771.42857326 ns/iter |
10604821.151515132 ns/iter |
1.35 |
URITemplateRouter_Create |
30483.291684940326 ns/iter |
22698.113568325396 ns/iter |
1.34 |
URITemplateRouter_Match |
178.49756576654207 ns/iter |
124.60451423704633 ns/iter |
1.43 |
URITemplateRouter_Match_BasePath |
202.18882556958576 ns/iter |
141.59017156602349 ns/iter |
1.43 |
URITemplateRouterView_Restore |
7823.08573077491 ns/iter |
6716.548527446268 ns/iter |
1.16 |
URITemplateRouterView_Match |
146.19753453277733 ns/iter |
100.7921661958836 ns/iter |
1.45 |
URITemplateRouterView_Match_BasePath |
165.26501897658184 ns/iter |
117.61528661431865 ns/iter |
1.41 |
URITemplateRouterView_Arguments |
476.1549867368465 ns/iter |
358.73941112619923 ns/iter |
1.33 |
Pointer_Object_Traverse |
26.297734944271614 ns/iter |
20.60809918178272 ns/iter |
1.28 |
Pointer_Object_Try_Traverse |
22.15134883191602 ns/iter |
16.996531724834966 ns/iter |
1.30 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
144.66649912889966 ns/iter |
116.20399616327902 ns/iter |
1.24 |
Pointer_Walker_Schema_ISO_Language |
3276482.098131246 ns/iter |
2483282.0219780807 ns/iter |
1.32 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1618365.039260952 ns/iter |
1200980.4820513052 ns/iter |
1.35 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1803796.0385603756 ns/iter |
1328530.760000008 ns/iter |
1.36 |
Pointer_Position_Tracker_Get_Deeply_Nested |
559.2138049637937 ns/iter |
366.01017651473325 ns/iter |
1.53 |
JSON_Array_Of_Objects_Unique |
421.97100420369554 ns/iter |
346.044791659037 ns/iter |
1.22 |
JSON_Parse_1 |
8064.24258171364 ns/iter |
6195.993881095243 ns/iter |
1.30 |
JSON_Parse_Real |
12062.913017178365 ns/iter |
9280.499441354967 ns/iter |
1.30 |
JSON_Parse_Decimal |
18119.50586399443 ns/iter |
13061.412793201209 ns/iter |
1.39 |
JSON_Parse_Schema_ISO_Language |
4673980.812080325 ns/iter |
3663683.984375036 ns/iter |
1.28 |
JSON_Fast_Hash_Helm_Chart_Lock |
72.50835246392573 ns/iter |
52.21344400000589 ns/iter |
1.39 |
JSON_Equality_Helm_Chart_Lock |
161.56967687922568 ns/iter |
133.02389553619247 ns/iter |
1.21 |
JSON_Divisible_By_Decimal |
236.78659256172006 ns/iter |
176.48609344742985 ns/iter |
1.34 |
JSON_String_Equal/10 |
6.049295466702018 ns/iter |
4.7099803199935515 ns/iter |
1.28 |
JSON_String_Equal/100 |
6.6285898516246275 ns/iter |
5.650287479306423 ns/iter |
1.17 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.6234991508089301 ns/iter |
0.5518529651282013 ns/iter |
1.13 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
25.19986883708295 ns/iter |
17.089076886696688 ns/iter |
1.47 |
JSON_String_Fast_Hash/10 |
0.9341011076244428 ns/iter |
0.822725555972128 ns/iter |
1.14 |
JSON_String_Fast_Hash/100 |
0.9347177345720539 ns/iter |
0.8188005510492895 ns/iter |
1.14 |
JSON_String_Key_Hash/10 |
1.560420258454803 ns/iter |
1.3648500994699089 ns/iter |
1.14 |
JSON_String_Key_Hash/100 |
12.446414282196425 ns/iter |
11.67954016221623 ns/iter |
1.07 |
JSON_Object_Defines_Miss_Same_Length |
3.427908004245875 ns/iter |
3.0027773502950366 ns/iter |
1.14 |
JSON_Object_Defines_Miss_Too_Small |
3.7417721301771643 ns/iter |
3.2745459550102396 ns/iter |
1.14 |
JSON_Object_Defines_Miss_Too_Large |
3.1341654277754514 ns/iter |
2.728573026859333 ns/iter |
1.15 |
Regex_Lower_S_Or_Upper_S_Asterisk |
0.9343738767947977 ns/iter |
0.8188595775210362 ns/iter |
1.14 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
0.9356364041781651 ns/iter |
0.8180272182533145 ns/iter |
1.14 |
Regex_Period_Asterisk |
0.6227068000746339 ns/iter |
0.5455086096262912 ns/iter |
1.14 |
Regex_Group_Period_Asterisk_Group |
0.62318631823774 ns/iter |
0.5463970203209984 ns/iter |
1.14 |
Regex_Period_Plus |
0.9342230693815705 ns/iter |
0.8179611650684585 ns/iter |
1.14 |
Regex_Period |
0.9346234667853541 ns/iter |
0.8181898237872706 ns/iter |
1.14 |
Regex_Caret_Period_Plus_Dollar |
0.6233645822115785 ns/iter |
0.545914760853015 ns/iter |
1.14 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
0.6230430759853504 ns/iter |
0.5458605236851984 ns/iter |
1.14 |
Regex_Caret_Period_Asterisk_Dollar |
0.9344273394619895 ns/iter |
0.8187237561547237 ns/iter |
1.14 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
0.9348696502159591 ns/iter |
0.8190882545230909 ns/iter |
1.14 |
Regex_Caret_X_Hyphen |
4.9871817007320915 ns/iter |
3.2731549212656783 ns/iter |
1.52 |
Regex_Period_Md_Dollar |
29.8555673633785 ns/iter |
28.512128945815416 ns/iter |
1.05 |
Regex_Caret_Slash_Period_Asterisk |
4.359023095959193 ns/iter |
2.727764932609776 ns/iter |
1.60 |
Regex_Caret_Period_Range_Dollar |
0.9388648151157895 ns/iter |
0.8187250132863849 ns/iter |
1.15 |
Regex_Nested_Backtrack |
38.451204900514405 ns/iter |
33.46222442864931 ns/iter |
1.15 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows/msvc)
Details
| Benchmark suite | Current: 7694e27 | Previous: 39431ca | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
7.568507812497468 ns/iter |
7.5535468750003485 ns/iter |
1.00 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
7.503496651786179 ns/iter |
7.501869419642863 ns/iter |
1.00 |
Regex_Period_Asterisk |
7.519438616070723 ns/iter |
7.502682142857558 ns/iter |
1.00 |
Regex_Group_Period_Asterisk_Group |
7.499616071429825 ns/iter |
7.497907366071286 ns/iter |
1.00 |
Regex_Period_Plus |
9.68539013533051 ns/iter |
9.671043750000052 ns/iter |
1.00 |
Regex_Period |
9.67895754607742 ns/iter |
9.674457546096688 ns/iter |
1.00 |
Regex_Caret_Period_Plus_Dollar |
9.676274999996792 ns/iter |
9.672692367532116 ns/iter |
1.00 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
9.685234778193001 ns/iter |
9.690007992454186 ns/iter |
1.00 |
Regex_Caret_Period_Asterisk_Dollar |
7.505599330355851 ns/iter |
7.502177455357893 ns/iter |
1.00 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
7.507061607144903 ns/iter |
7.605095535714059 ns/iter |
0.99 |
Regex_Caret_X_Hyphen |
11.87547343749884 ns/iter |
11.87265781249991 ns/iter |
1.00 |
Regex_Period_Md_Dollar |
38.779033236096474 ns/iter |
39.773635004037764 ns/iter |
0.97 |
Regex_Caret_Slash_Period_Asterisk |
11.455151785712912 ns/iter |
11.458317857141814 ns/iter |
1.00 |
Regex_Caret_Period_Range_Dollar |
9.67604843750536 ns/iter |
9.67254102824883 ns/iter |
1.00 |
Regex_Nested_Backtrack |
46.38371085678787 ns/iter |
46.29308139047352 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
461.5988530355469 ns/iter |
463.58008788034886 ns/iter |
1.00 |
JSON_Parse_1 |
7768.731026785198 ns/iter |
7865.024553570521 ns/iter |
0.99 |
JSON_Parse_Real |
15745.875000001368 ns/iter |
16412.66972769882 ns/iter |
0.96 |
JSON_Parse_Decimal |
15620.189732144598 ns/iter |
15531.078124999858 ns/iter |
1.01 |
JSON_Parse_Schema_ISO_Language |
5902906.250002258 ns/iter |
6040185.714285582 ns/iter |
0.98 |
JSON_Fast_Hash_Helm_Chart_Lock |
60.06865178570869 ns/iter |
116.5946331877458 ns/iter |
0.52 |
JSON_Equality_Helm_Chart_Lock |
259.2401834480831 ns/iter |
345.4114354727007 ns/iter |
0.75 |
JSON_Divisible_By_Decimal |
273.00401906236993 ns/iter |
266.9881822557878 ns/iter |
1.02 |
JSON_String_Equal/10 |
12.559414285720193 ns/iter |
13.102193914721628 ns/iter |
0.96 |
JSON_String_Equal/100 |
13.179991682229627 ns/iter |
13.783218749998026 ns/iter |
0.96 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
1.88276518025217 ns/iter |
1.8882324124003262 ns/iter |
1.00 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
12.561189285715306 ns/iter |
12.933171428571198 ns/iter |
0.97 |
JSON_String_Fast_Hash/10 |
3.1372406299012323 ns/iter |
3.163506781477337 ns/iter |
0.99 |
JSON_String_Fast_Hash/100 |
3.1364656250007426 ns/iter |
3.158012946428812 ns/iter |
0.99 |
JSON_String_Key_Hash/10 |
3.7654620535728816 ns/iter |
3.7858610491075293 ns/iter |
0.99 |
JSON_String_Key_Hash/100 |
16.55686104984076 ns/iter |
14.515023149487305 ns/iter |
1.14 |
JSON_Object_Defines_Miss_Same_Length |
3.784114278957535 ns/iter |
3.7726322544643205 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Small |
3.7676808035718476 ns/iter |
3.7836166003862424 ns/iter |
1.00 |
JSON_Object_Defines_Miss_Too_Large |
5.032093750003241 ns/iter |
5.047299000000294 ns/iter |
1.00 |
Pointer_Object_Traverse |
39.668194727679456 ns/iter |
40.598809025872434 ns/iter |
0.98 |
Pointer_Object_Try_Traverse |
52.42203999996491 ns/iter |
52.185050000002775 ns/iter |
1.00 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
169.43846223915423 ns/iter |
161.717879464288 ns/iter |
1.05 |
Pointer_Walker_Schema_ISO_Language |
11490098.214283405 ns/iter |
11506553.571428362 ns/iter |
1.00 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1977862.1428583525 ns/iter |
1968970.7142857416 ns/iter |
1.00 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
3138035.7142865025 ns/iter |
3089799.553571534 ns/iter |
1.02 |
Pointer_Position_Tracker_Get_Deeply_Nested |
626.8234825645795 ns/iter |
614.3141741070986 ns/iter |
1.02 |
URITemplateRouter_Create |
39293.660714280675 ns/iter |
40204.27717485589 ns/iter |
0.98 |
URITemplateRouter_Match |
226.1556071428978 ns/iter |
214.2471874999785 ns/iter |
1.06 |
URITemplateRouter_Match_BasePath |
257.3214980947511 ns/iter |
252.95086620318307 ns/iter |
1.02 |
URITemplateRouterView_Restore |
30530.650154780713 ns/iter |
30469.758928575175 ns/iter |
1.00 |
URITemplateRouterView_Match |
156.4907474780436 ns/iter |
157.32500000001133 ns/iter |
0.99 |
URITemplateRouterView_Match_BasePath |
182.7343823870477 ns/iter |
187.79182033855557 ns/iter |
0.97 |
URITemplateRouterView_Arguments |
446.2101282472082 ns/iter |
446.7095625000183 ns/iter |
1.00 |
JSONL_Parse_Large |
28041911.99998968 ns/iter |
27877451.999997903 ns/iter |
1.01 |
JSONL_Parse_Large_GZIP |
27523576.000003234 ns/iter |
27574684.000001073 ns/iter |
1.00 |
HTML_Build_Table_100000 |
84357177.77779752 ns/iter |
82920622.22223093 ns/iter |
1.02 |
HTML_Render_Table_100000 |
7034342.2222221205 ns/iter |
7291019.999999864 ns/iter |
0.96 |
GZIP_Compress_ISO_Language_Set_3_Locations |
40257388.88887847 ns/iter |
44298176.470587194 ns/iter |
0.91 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
10237367.187500013 ns/iter |
10625303.124999873 ns/iter |
0.96 |
GZIP_Compress_ISO_Language_Set_3_Schema |
2270877.9264223306 ns/iter |
2299402.3411369817 ns/iter |
0.99 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
661305.8035717196 ns/iter |
652844.2857142888 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 7694e27 | Previous: 39431ca | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.620852107150112 ns/iter |
2.857600744488333 ns/iter |
0.92 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.0790361024011608 ns/iter |
2.5920301545839486 ns/iter |
0.80 |
Regex_Period_Asterisk |
2.034640604358347 ns/iter |
2.6356160100971824 ns/iter |
0.77 |
Regex_Group_Period_Asterisk_Group |
2.0611749419047576 ns/iter |
2.5884595582351997 ns/iter |
0.80 |
Regex_Period_Plus |
2.0641700544337542 ns/iter |
2.2069957743345143 ns/iter |
0.94 |
Regex_Period |
2.120874738843687 ns/iter |
2.3385828421208177 ns/iter |
0.91 |
Regex_Caret_Period_Plus_Dollar |
2.0639957845171324 ns/iter |
2.2774014415265835 ns/iter |
0.91 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.243565652391156 ns/iter |
2.223672360482258 ns/iter |
1.01 |
Regex_Caret_Period_Asterisk_Dollar |
2.1783302421239137 ns/iter |
2.476191692824711 ns/iter |
0.88 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.168823995973241 ns/iter |
2.4452712042095013 ns/iter |
0.89 |
Regex_Caret_X_Hyphen |
6.8163789591068635 ns/iter |
6.992623381226392 ns/iter |
0.97 |
Regex_Period_Md_Dollar |
17.51225117414049 ns/iter |
20.73258090454534 ns/iter |
0.84 |
Regex_Caret_Slash_Period_Asterisk |
4.555366084313982 ns/iter |
8.874070416912069 ns/iter |
0.51 |
Regex_Caret_Period_Range_Dollar |
1.7344431090830157 ns/iter |
2.4761736856273955 ns/iter |
0.70 |
Regex_Nested_Backtrack |
24.653308240850677 ns/iter |
29.796535864492768 ns/iter |
0.83 |
JSON_Array_Of_Objects_Unique |
439.8859653321915 ns/iter |
528.630708000037 ns/iter |
0.83 |
JSON_Parse_1 |
4199.654163737562 ns/iter |
5230.4104928532915 ns/iter |
0.80 |
JSON_Parse_Real |
6848.131134892287 ns/iter |
6762.266083780757 ns/iter |
1.01 |
JSON_Parse_Decimal |
8679.308867044447 ns/iter |
8949.361808626421 ns/iter |
0.97 |
JSON_Parse_Schema_ISO_Language |
3408751.0452260156 ns/iter |
3115658.54359019 ns/iter |
1.09 |
JSON_Fast_Hash_Helm_Chart_Lock |
60.97180421398393 ns/iter |
69.65321888395917 ns/iter |
0.88 |
JSON_Equality_Helm_Chart_Lock |
157.5154797613785 ns/iter |
165.56446418897025 ns/iter |
0.95 |
JSON_Divisible_By_Decimal |
184.2816735409968 ns/iter |
202.09465750916397 ns/iter |
0.91 |
JSON_String_Equal/10 |
7.1253335577483785 ns/iter |
7.987980817250533 ns/iter |
0.89 |
JSON_String_Equal/100 |
6.471448095964985 ns/iter |
7.256538719116549 ns/iter |
0.89 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.8165413673189549 ns/iter |
0.9042596128842697 ns/iter |
0.90 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
3.5154805197491776 ns/iter |
4.634462678288134 ns/iter |
0.76 |
JSON_String_Fast_Hash/10 |
2.4277817092949303 ns/iter |
2.853388442343289 ns/iter |
0.85 |
JSON_String_Fast_Hash/100 |
2.1481351005402733 ns/iter |
2.4657267733071877 ns/iter |
0.87 |
JSON_String_Key_Hash/10 |
1.4140935227602867 ns/iter |
1.698997158556 ns/iter |
0.83 |
JSON_String_Key_Hash/100 |
2.4847076045073413 ns/iter |
2.5240970799069773 ns/iter |
0.98 |
JSON_Object_Defines_Miss_Same_Length |
2.5363053159248876 ns/iter |
2.4273291102919874 ns/iter |
1.04 |
JSON_Object_Defines_Miss_Too_Small |
2.522920755248203 ns/iter |
2.5486354632525536 ns/iter |
0.99 |
JSON_Object_Defines_Miss_Too_Large |
2.598969780689122 ns/iter |
2.4388233601912863 ns/iter |
1.07 |
Pointer_Object_Traverse |
15.043796408784951 ns/iter |
14.788753013767499 ns/iter |
1.02 |
Pointer_Object_Try_Traverse |
19.802998008599722 ns/iter |
20.131587304449507 ns/iter |
0.98 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
158.68109775334025 ns/iter |
171.77020647054593 ns/iter |
0.92 |
Pointer_Walker_Schema_ISO_Language |
4531855.481012585 ns/iter |
5226810.959731586 ns/iter |
0.87 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1010930.3491829372 ns/iter |
1148242.6839465399 ns/iter |
0.88 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1489031.1026157879 ns/iter |
1842792.3155556729 ns/iter |
0.81 |
Pointer_Position_Tracker_Get_Deeply_Nested |
374.44650190712946 ns/iter |
387.71031615116095 ns/iter |
0.97 |
URITemplateRouter_Create |
24904.67723385495 ns/iter |
28640.77939469013 ns/iter |
0.87 |
URITemplateRouter_Match |
177.63022775540927 ns/iter |
174.2594190206643 ns/iter |
1.02 |
URITemplateRouter_Match_BasePath |
198.33921242527052 ns/iter |
223.27953219105308 ns/iter |
0.89 |
URITemplateRouterView_Restore |
11642.907905146845 ns/iter |
11293.229721830554 ns/iter |
1.03 |
URITemplateRouterView_Match |
131.69347763817763 ns/iter |
153.5561773056754 ns/iter |
0.86 |
URITemplateRouterView_Match_BasePath |
156.41038734460028 ns/iter |
156.80025233499424 ns/iter |
1.00 |
URITemplateRouterView_Arguments |
424.69185573898875 ns/iter |
470.54319136769794 ns/iter |
0.90 |
JSONL_Parse_Large |
12876035.807019496 ns/iter |
13362775.510203466 ns/iter |
0.96 |
JSONL_Parse_Large_GZIP |
13343846.392155113 ns/iter |
15912622.39583339 ns/iter |
0.84 |
HTML_Build_Table_100000 |
65162435.22221683 ns/iter |
68594192.62499955 ns/iter |
0.95 |
HTML_Render_Table_100000 |
3461444.8636373235 ns/iter |
5304830.69014079 ns/iter |
0.65 |
GZIP_Compress_ISO_Language_Set_3_Locations |
30305149.29166846 ns/iter |
40694473.49999936 ns/iter |
0.74 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
5316804.933333212 ns/iter |
7029042.948980366 ns/iter |
0.76 |
GZIP_Compress_ISO_Language_Set_3_Schema |
1531282.4468548014 ns/iter |
1958265.4238805466 ns/iter |
0.78 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
310446.46025272936 ns/iter |
394640.79230364494 ns/iter |
0.79 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 7694e27 | Previous: 39431ca | Ratio |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.1933485322608086 ns/iter |
2.4660408012839348 ns/iter |
0.89 |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.1956100585966905 ns/iter |
2.463995944945357 ns/iter |
0.89 |
Regex_Period_Asterisk |
2.1839590730617076 ns/iter |
2.46534170256471 ns/iter |
0.89 |
Regex_Group_Period_Asterisk_Group |
2.2043049090546027 ns/iter |
2.4623954496522193 ns/iter |
0.90 |
Regex_Period_Plus |
2.4911932195939612 ns/iter |
3.8682404037039304 ns/iter |
0.64 |
Regex_Period |
2.8026619816272222 ns/iter |
4.218860874181633 ns/iter |
0.66 |
Regex_Caret_Period_Plus_Dollar |
2.4979486736878167 ns/iter |
3.87021254547123 ns/iter |
0.65 |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.806119776184225 ns/iter |
4.216649427921897 ns/iter |
0.67 |
Regex_Caret_Period_Asterisk_Dollar |
2.181208513479936 ns/iter |
2.4606693219141254 ns/iter |
0.89 |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.1942980270851904 ns/iter |
2.8155550518108017 ns/iter |
0.78 |
Regex_Caret_X_Hyphen |
5.607385163557351 ns/iter |
7.032812047818567 ns/iter |
0.80 |
Regex_Period_Md_Dollar |
28.007164582217193 ns/iter |
26.622303335897634 ns/iter |
1.05 |
Regex_Caret_Slash_Period_Asterisk |
5.913951166108994 ns/iter |
7.368631510073414 ns/iter |
0.80 |
Regex_Caret_Period_Range_Dollar |
3.7411850781763567 ns/iter |
2.463761790421221 ns/iter |
1.52 |
Regex_Nested_Backtrack |
36.938140795040354 ns/iter |
36.763226894875636 ns/iter |
1.00 |
JSON_Array_Of_Objects_Unique |
412.4353323141461 ns/iter |
440.31001921175044 ns/iter |
0.94 |
JSON_Parse_1 |
5860.592490142059 ns/iter |
5860.361392307404 ns/iter |
1.00 |
JSON_Parse_Real |
10649.69689083773 ns/iter |
10399.55966369214 ns/iter |
1.02 |
JSON_Parse_Decimal |
11335.974393313774 ns/iter |
11612.458508932606 ns/iter |
0.98 |
JSON_Parse_Schema_ISO_Language |
3645180.324607348 ns/iter |
3758326.2956987806 ns/iter |
0.97 |
JSON_Fast_Hash_Helm_Chart_Lock |
61.00048509559228 ns/iter |
73.47938464758258 ns/iter |
0.83 |
JSON_Equality_Helm_Chart_Lock |
169.40048754270433 ns/iter |
161.20876604913954 ns/iter |
1.05 |
JSON_Divisible_By_Decimal |
239.07444416594038 ns/iter |
239.65813945830396 ns/iter |
1.00 |
JSON_String_Equal/10 |
6.234353806961492 ns/iter |
6.331795279367821 ns/iter |
0.98 |
JSON_String_Equal/100 |
6.871304885690844 ns/iter |
7.038941698665199 ns/iter |
0.98 |
JSON_String_Equal_Small_By_Perfect_Hash/10 |
0.9366265878047421 ns/iter |
1.0546241710565007 ns/iter |
0.89 |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 |
10.275005779233506 ns/iter |
12.47756452333512 ns/iter |
0.82 |
JSON_String_Fast_Hash/10 |
2.8020808035194844 ns/iter |
2.8152939298512125 ns/iter |
1.00 |
JSON_String_Fast_Hash/100 |
2.801764766033144 ns/iter |
2.818106948039136 ns/iter |
0.99 |
JSON_String_Key_Hash/10 |
2.181007072383689 ns/iter |
2.461388768111574 ns/iter |
0.89 |
JSON_String_Key_Hash/100 |
6.536456414975174 ns/iter |
8.084461204501201 ns/iter |
0.81 |
JSON_Object_Defines_Miss_Same_Length |
3.7382426164169593 ns/iter |
4.2218176661474125 ns/iter |
0.89 |
JSON_Object_Defines_Miss_Too_Small |
3.7418783931217248 ns/iter |
4.229099742018546 ns/iter |
0.88 |
JSON_Object_Defines_Miss_Too_Large |
3.739822695817801 ns/iter |
4.220842893103267 ns/iter |
0.89 |
Pointer_Object_Traverse |
24.170593708037135 ns/iter |
27.324502947423014 ns/iter |
0.88 |
Pointer_Object_Try_Traverse |
26.196730032848308 ns/iter |
30.206886605057218 ns/iter |
0.87 |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
152.20709887185635 ns/iter |
190.09368235292308 ns/iter |
0.80 |
Pointer_Walker_Schema_ISO_Language |
3018455.3189656073 ns/iter |
3088562.500000024 ns/iter |
0.98 |
Pointer_Maybe_Tracked_Deeply_Nested/0 |
1447003.23673477 ns/iter |
1409522.2351737788 ns/iter |
1.03 |
Pointer_Maybe_Tracked_Deeply_Nested/1 |
1805228.7800512896 ns/iter |
1722168.2266010582 ns/iter |
1.05 |
Pointer_Position_Tracker_Get_Deeply_Nested |
660.0256863878312 ns/iter |
650.5874328910945 ns/iter |
1.01 |
URITemplateRouter_Create |
31740.493352626723 ns/iter |
30350.605392260633 ns/iter |
1.05 |
URITemplateRouter_Match |
180.6136609997344 ns/iter |
182.10819686325326 ns/iter |
0.99 |
URITemplateRouter_Match_BasePath |
211.20674820946255 ns/iter |
223.54648703662755 ns/iter |
0.94 |
URITemplateRouterView_Restore |
7908.44331694274 ns/iter |
8598.887419633022 ns/iter |
0.92 |
URITemplateRouterView_Match |
142.2160491470199 ns/iter |
147.42242667666528 ns/iter |
0.96 |
URITemplateRouterView_Match_BasePath |
160.8190670037403 ns/iter |
169.74799878748146 ns/iter |
0.95 |
URITemplateRouterView_Arguments |
482.0488353249551 ns/iter |
470.3557217429083 ns/iter |
1.02 |
JSONL_Parse_Large |
10917466.76562444 ns/iter |
10121653.042857101 ns/iter |
1.08 |
JSONL_Parse_Large_GZIP |
12151622.241378453 ns/iter |
11392978.770491809 ns/iter |
1.07 |
HTML_Build_Table_100000 |
66794837.09090371 ns/iter |
83421942.87499893 ns/iter |
0.80 |
HTML_Render_Table_100000 |
5457735.187500034 ns/iter |
5049850.288732156 ns/iter |
1.08 |
GZIP_Compress_ISO_Language_Set_3_Locations |
34803185.649997205 ns/iter |
36381361.36842269 ns/iter |
0.96 |
GZIP_Decompress_ISO_Language_Set_3_Locations |
4824108.234482803 ns/iter |
4675728.026845474 ns/iter |
1.03 |
GZIP_Compress_ISO_Language_Set_3_Schema |
1911941.278688603 ns/iter |
2151822.9631902245 ns/iter |
0.89 |
GZIP_Decompress_ISO_Language_Set_3_Schema |
376700.9378713842 ns/iter |
296422.5513146701 ns/iter |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com