Upgrade Core to 57e8c91ed68e3ee903526fd2f45cb16ca46759d8

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[cubic-dev-ai]

No issues found across 64 files

[augmentcode]

🤖 Augment PR Summary

Summary: Upgrades vendored Sourcemeta Core to 57e8c91 and syncs downstream build/config changes.
Key changes:

• Adds new Core ip component (IPv4/IPv6 validation) and wires it into URI utilities.
• Bumps Core default C++ standard to C++23 and adopts newer stdlib features (std::ranges, std::to_chars/from_chars, std::unreachable).
• Adds std::formatter specializations for Core JSON and vocabularies to enable std::format.
• Improves JSON parsing/stringifying and schema analysis using ranges algorithms and explicit branch prediction.
• Extends JSON Schema support with $vocabulary parsing and new alterschema lints (forbid_empty_enum, invalid_external_ref).
• Enhances URI parsing/recomposition with IP-literal tracking and avoids exception-based numeric conversions.
• Extends URI Template router with per-route argument storage and v2 binary serialization support.

Notes: Core URI now depends on the new IP library, and serialized router files written by this version use a new format version.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

vendor/core/src/core/uri/CMakeLists.txt:11 — Linking sourcemeta_core_uri to sourcemeta::core::ip as PRIVATE can break consumers when core::uri is built as a static library (the dependency won’t propagate, leading to unresolved symbols at final link). Consider making this dependency part of the public link interface if uri’s object code calls into ip.

Severity: high

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

vendor/core/src/core/uritemplate/include/sourcemeta/core/uritemplate_router.h:80 — Argument uses std::string_view and add() persists the passed arguments, so passing temporary strings (argument names or string values) can leave dangling views and cause UB later. The lifetime note currently only mentions uri_template, so callers may not realize the same constraint applies to arguments.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

vendor/core/config.cmake.in:66 — sourcemeta_core_ip.cmake is included both for the ip component and again as a dependency of uri, so the default component list will attempt to include it twice. If the generated sourcemeta_core_ip.cmake isn’t idempotent (e.g., guarded with if(NOT TARGET ...) / include_guard()), this can break find_package(core) for default installs.

Severity: medium

Other Locations

• vendor/core/config.cmake.in:64

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}