Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
There was a problem hiding this comment.
No issues found across 19 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
🤖 Augment PR SummarySummary: Updates the vendored Changes:
Technical Notes: The new code generators depend on the updated 🤖 Was this summary useful? React with 👍 or 👎 |
| OUTPUT "${SOURCEMETA_CORE_IDNA_DATA_HEADER}" | ||
| COMMAND "${Python3_EXECUTABLE}" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/codegen.py" | ||
| COMMAND "${SOURCEMETA_CORE_IDNA_CODEGEN_TARGET}" |
There was a problem hiding this comment.
In vendor/core/src/core/idna/CMakeLists.txt:18, sourcemeta_executable(OUTPUT ...) sets SOURCEMETA_CORE_IDNA_CODEGEN_TARGET to the target name (see vendor/core/cmake/common/targets/executable.cmake:27-29), but add_custom_command(COMMAND ...)typically needs the actual executable path (e.g. via$<TARGET_FILE:...>); using the raw target name can make the build fail when the binary isn’t on PATH` (notably with multi-config generators).
Severity: high
Other Locations
vendor/core/src/core/unicode/CMakeLists.txt:18
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com