Upgrade Sourcemeta dependencies#922
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
There was a problem hiding this comment.
No issues found across 157 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
🤖 Augment PR SummarySummary: This PR updates vendored Sourcemeta dependencies (Core + Blaze) and incorporates new upstream functionality and canonicalization/compilation improvements. Changes:
Technical Notes: Most code changes are vendored upstream improvements (explicit lambda return types, designated initializers, and safer string-view handling) with a few notable behavioral additions around IRIs, routing introspection, and annotation emission control. 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| return result; | ||
| return result; | ||
| } catch (const YAMLParseError &error) { |
There was a problem hiding this comment.
vendor/core/src/core/yaml/yaml.cc:44 — Catching YAMLParseError and rethrowing YAMLFileParseError will erase more-specific derived exceptions (e.g. ones carrying extra context like an anchor name), potentially reducing diagnosability. Consider whether you want to preserve specialized error details while still attaching the path.
Severity: medium
Other Locations
vendor/core/src/core/yaml/yaml.cc:81
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| } else if (character == sourcemeta::core::URI_SLASH || | ||
| sourcemeta::core::uri_is_pchar(character)) { | ||
| ++index; | ||
| } else if ((static_cast<unsigned char>(character) & 0x80U) != 0U) { |
There was a problem hiding this comment.
vendor/core/src/core/uri/path.cc:35 — canonicalize_path now accepts literal non-ASCII (RFC 3987) bytes, but it still only percent-decodes RFC 3986 unreserved characters, so semantically equivalent IRI paths like /caf%C3%A9 vs /café may not compare the same in strip_path_prefix/rebase_path. Consider whether these helpers should normalize percent-encoded UTF-8 iunreserved sequences consistently when Unicode is allowed.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com