feature request: support for pre-commit hooks

[kbroch-rivosinc]

Wondering if there's any interest in adding support for this tool https://pre-commit.com/index.html to run jsonschema?
Similar to this: https://github.com/python-jsonschema/jsonschema/blob/main/.pre-commit-hooks.yaml

If so, I can supply the PR.

[jviotti]

Hey @kbroch-rivosinc ,

Thanks for reaching out! I'm not very familiar with https://pre-commit.com/index.html, but if you know how to do it, I would certainly be interested in a PR!

Would it be possible to write an e2e test that exercises the functionality for real? That way we can be sure to not break it in the future!

[kbroch-rivosinc]

Great. I'm working on the PR.

I think it will be possible to do e2e testing. My first thought is to use whatever test cases you have if apropos. There's a command pre-commit try-repo. So CI flow could build new version of jsonschema and then run the pre-commit try-repo hooks against that new build to see if anything breaks. Let me know if that sounds feasible.

[jviotti]

Awesome! Feel free to send a PR integrating it, and I'll take care of the testing. It will be a good exercise for me to understand pre-commit hooks better!

[jviotti]

@kbroch-rivosinc Please try v7.3.0 (https://github.com/sourcemeta/jsonschema/releases/tag/v7.3.0). You should be able to use it with the lint command. If you need any other pre-commit integration, we'll easily make it work, as we even have tests for it now!

[kbroch-rivosinc]

Just tried it locally in the PR and it is working great. Thank you!