Skip to content

Do not provide a linter error on an explicit additionalProperties: true#632

Merged
jviotti merged 1 commit intomainfrom
additional-properties-true
Jan 27, 2026
Merged

Do not provide a linter error on an explicit additionalProperties: true#632
jviotti merged 1 commit intomainfrom
additional-properties-true

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 27, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

…rue`

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Jan 27, 2026

🤖 Augment PR Summary

Summary: Removes the linter rule that flagged an explicit additionalProperties: true (or empty schema) as redundant.

Changes:

  • Bumps the vendored sourcemeta/core dependency and removes the AdditionalPropertiesDefault linter rule from build/registration.
  • Updates lint tests to use properties_default as the failing rule and adjusts lint --list expectations (including rule counts).

Technical Notes: The linter will no longer emit the additional_properties_default diagnostic when additionalProperties is explicitly set to true.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 071e643 into main Jan 27, 2026
13 checks passed
@jviotti jviotti deleted the additional-properties-true branch January 27, 2026 15:03
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 28, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | minor | `v14.4.0` → `v14.5.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary>

### [`v14.5.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.5.0)

[Compare Source](sourcemeta/jsonschema@v14.4.0...v14.5.0)

#### What's Changed

- Add VS code extension promotion message on install across various distributions by [@&#8203;Karan-Palan](https://github.com/Karan-Palan) in [#&#8203;628](sourcemeta/jsonschema#628)
- Match `jsonschema.json` `resolve` option with and without `.json` by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;630](sourcemeta/jsonschema#630)
- Do not provide a linter error on an explicit `additionalProperties: true` by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;632](sourcemeta/jsonschema#632)

**Full Changelog**: <sourcemeta/jsonschema@v14.4.0...v14.5.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi4xMiIsInVwZGF0ZWRJblZlciI6IjQyLjkyLjEyIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant