Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR adds Windows coverage for the existing CI HTTP integration tests by introducing PowerShell-based test runners. Changes:
Technical Notes: The new tests rely on external HTTPS endpoints under 🤖 Was this summary useful? React with 👍 or 👎 |
| macro(add_jsonschema_test_windows_ci name) | ||
| if(JSONSCHEMA_TESTS_CI AND WIN32) | ||
| add_test(NAME JSONSchema.ci.${name} COMMAND | ||
| powershell -ExecutionPolicy Bypass -File |
There was a problem hiding this comment.
test/CMakeLists.txt:20 Running powershell without disabling profiles/non-interactive mode can pick up environment/profile side-effects, which can make these CI tests less deterministic on some Windows agents.
Severity: low
⏳ Generating Fix in Augment link...
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| } | ||
|
|
||
| $resolvedTmp = (Resolve-Path $TMP).Path.TrimEnd('\') | ||
| $output = $result.Stdout + $result.Stderr |
There was a problem hiding this comment.
test/ci/pass_install_http.ps1:60 Building $output via $result.Stdout + $result.Stderr doesn’t preserve the real ordering if the CLI writes to both streams, so the output assertion can become flaky even when the CLI behavior is correct. (The Unix equivalent captures combined output in-order.)
Severity: medium
Other Locations
test/ci/pass_install_add_http.ps1:52
⏳ Generating Fix in Augment link...
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/ci/pass_bundle_http.ps1">
<violation number="1" location="test/ci/pass_bundle_http.ps1:9">
P3: Use a case-sensitive comparison here so the JSON diff fails on casing changes as well.</violation>
</file>
<file name="test/ci/pass_install_add_http.ps1">
<violation number="1" location="test/ci/pass_install_add_http.ps1:75">
P2: Use a 5.1-compatible `Join-Path` form here; the third positional path segment is not accepted by Windows PowerShell.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com