Skip to content

Upgrade Blaze to 3494e9c82e0e8fbd974d99888accb4d7b8df5fff#738

Merged
jviotti merged 1 commit intomainfrom
js-port-output
Apr 27, 2026
Merged

Upgrade Blaze to 3494e9c82e0e8fbd974d99888accb4d7b8df5fff#738
jviotti merged 1 commit intomainfrom
js-port-output

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Apr 27, 2026

See: sourcemeta/blaze#752
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 27, 2026

🤖 Augment PR Summary

Summary: This PR updates the vendored Blaze dependency to commit 3494e9c8….

Changes:

  • Bumps the Blaze revision in DEPENDENCIES to pull in upstream changes.
  • Enhances the JavaScript port so Blaze.validate() can optionally return JSON Schema Standard Output Format results (flag and basic) in addition to the existing boolean/callback modes.
  • Adds a JS describe() helper (and related opcode constants module) to produce human-readable messages for evaluation events/errors.
  • Updates the JavaScript README to document standard output usage and the low-level evaluation callback API.
  • Expands the JS package contents to ship the new modules and raises the declared Node engine requirement.
  • Updates Blaze’s CMake trace-JSON formatting target to include new standard-output test fixtures.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

}

callback(type, valid, instruction, evaluatePath, instanceLocation, annotation) {
if (evaluatePath === '') return;
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor/blaze/ports/javascript/index.mjs:4011: SimpleOutput.callback returns early when evaluatePath === '', which can drop failures whose keywordLocation is the root schema. For example, a top-level boolean false schema (AssertionFail at evaluatePath "") would likely yield an empty errors array in basic standard output.

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Comment thread vendor/blaze/ports/javascript/index.d.mts
@jviotti jviotti merged commit 68068a8 into main Apr 27, 2026
14 checks passed
@jviotti jviotti deleted the js-port-output branch April 27, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant