Skip to content

Use x-format-assertion for the configuration schema#1003

Merged
jviotti merged 1 commit into
mainfrom
config-format
Jun 2, 2026
Merged

Use x-format-assertion for the configuration schema#1003
jviotti merged 1 commit into
mainfrom
config-format

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Jun 2, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Jun 2, 2026

🤖 Augment PR Summary

Summary: This PR makes configuration-schema format constraints (URI/email/etc.) assertive by introducing and using an x-format-assertion switch.

Changes:

  • Bumped Blaze to a revision that can force format assertions per-schema.
  • Updated @sourcemeta/jsonschema to a newer version used by the build/test tooling.
  • Replaced prior “TODO: Use Format Assertion…” $comment entries with x-format-assertion: true in the configuration-related schemas.
  • Extended the configuration schema test suite with negative cases for non-absolute URIs, invalid URI-references, and invalid emails.
  • Documented a limitation in the Blaze JavaScript port regarding Format Assertion vocabulary support.

Technical Notes: Blaze’s format compilation logic now treats x-format-assertion: true as enabling assertion behavior even when the global format_assertion tweak is not set, which allows enforcing format under the default 2020-12 “format-annotation” vocabulary.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 78e58c3 into main Jun 2, 2026
3 of 5 checks passed
@jviotti jviotti deleted the config-format branch June 2, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant