Skip to content

Don't add the first tab by default to the URL params in the explorer#617

Merged
jviotti merged 1 commit intomainfrom
tabs-default
Jan 26, 2026
Merged

Don't add the first tab by default to the URL params in the explorer#617
jviotti merged 1 commit intomainfrom
tabs-default

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Jan 26, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Jan 26, 2026

🤖 Augment PR Summary

Summary: This PR prevents the schema explorer from adding a default ?tab=... query parameter on initial page load.

Changes:

  • Updated src/web/scripts/tabs.js to make URL updates optional when selecting a tab.
  • Ensured the default (first) tab is selected without mutating window.location.
  • Added Playwright coverage to verify default tab selection, tab-click URL updates, and deep-linking via ?tab=.

Technical Notes: Uses history.replaceState only for user-driven tab changes (or when a tab is explicitly provided via query string).

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 49f327c into main Jan 26, 2026
4 checks passed
@jviotti jviotti deleted the tabs-default branch January 26, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant