Promote integration snippets in the schema pages#631
Merged
Conversation
a134b67 to
2911562
Compare
🤖 Augment PR SummarySummary: This PR enhances schema pages by surfacing copyable “integration snippets” and refactors the tab UI logic to support multiple independent tab groups. Changes:
Technical Notes: The schema page now has two tab groups (usage snippets and details), and the copy feature relies on the Clipboard API in the browser. 🤖 Was this summary useful? React with 👍 or 👎 |
2911562 to
b21d73e
Compare
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/web/scripts/copy.js">
<violation number="1" location="src/web/scripts/copy.js:4">
P2: `navigator.clipboard.writeText()` returns a Promise that is not being handled. If the copy fails (permissions denied, non-secure context, etc.), this produces an unhandled promise rejection **and** the checkmark icon is still shown, misleading the user into thinking the copy succeeded. The icon feedback should only appear on successful copy.</violation>
</file>
<file name="src/web/scripts/tabs.js">
<violation number="1" location="src/web/scripts/tabs.js:26">
P2: When the URL contains a value for `urlParam` that doesn't match any tab (e.g., `?tab=nonexistent`), no tab gets selected and no fallback occurs. The `forEach` silently finds no match, leaving all tabs in an indeterminate state. Consider tracking whether a match was found and falling back to the first tab if not.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
b21d73e to
2697a61
Compare
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
2697a61 to
6b4799b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com