Skip to content

Get rid of sandbox manifest files#648

Merged
jviotti merged 1 commit intomainfrom
cleanup-tests
Feb 18, 2026
Merged

Get rid of sandbox manifest files#648
jviotti merged 1 commit intomainfrom
cleanup-tests

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 18, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Feb 18, 2026

🤖 Augment PR Summary

Summary: This PR removes the previous “sandbox manifest” workflow and replaces it with CLI-level regression tests that validate the generated sandbox/index output structure.

Changes:

  • Removed the sandbox manifest check step from Makefile and deleted the sandbox-manifest-refresh target.
  • Dropped the Docker-based sandbox manifest validation by removing the copied manifest files and manifest-check.sh from test/sandbox/Dockerfile.
  • Deleted test/sandbox/manifest-check.sh and legacy manifest snapshot files under test/sandbox.
  • Added a set of new CLI tests under test/cli/index/common that build an index, enumerate the output via find | sort, and diff against an expected manifest.
  • Registered the new tests in test/cli/CMakeLists.txt to cover scenarios like default vs headless output, filename edge cases (camelcase, periods, index.html, versions), URL-encoding (%25), YAML schemas, missing $id, and path overlaps/clashes.

Technical Notes: The new tests exercise output determinism by comparing full directory/file manifests, shifting validation from pre-generated snapshot files to reproducible, configuration-driven test fixtures.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

@jviotti jviotti merged commit 6e14ef8 into main Feb 18, 2026
6 checks passed
@jviotti jviotti deleted the cleanup-tests branch February 18, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant