Skip to content

Comments

Handle configuration base paths correctly on multi-file setups#651

Merged
jviotti merged 4 commits intomainfrom
base-paths-multi-config
Feb 18, 2026
Merged

Handle configuration base paths correctly on multi-file setups#651
jviotti merged 4 commits intomainfrom
base-paths-multi-config

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 18, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

@jviotti jviotti marked this pull request as ready for review February 18, 2026 20:06
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

@augmentcode
Copy link

augmentcode bot commented Feb 18, 2026

🤖 Augment PR Summary

Summary: Improves configuration parsing so relative paths resolve correctly when a configuration is composed from multiple files via extends/include.

Changes:

  • Adds a new metadata field x-sourcemeta-one:path to collection entries and updates the JSON schema accordingly.
  • During Configuration::read, stamps each collection entry with the originating configuration file path.
  • During Configuration::parse, derives the per-entry base directory from that stamped path (and strips the metadata before passing to Blaze parsing).
  • Updates CLI golden outputs and configuration read unit tests to expect the new metadata field.
  • Adds a new unit test covering multi-file base-path behavior (relative lint rules and collection paths from an extended file).

Technical Notes: This keeps path resolution deterministic across mixed single-file/multi-file setups without changing existing entry formats beyond the additional x- metadata.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 61ce0ba into main Feb 18, 2026
5 checks passed
@jviotti jviotti deleted the base-paths-multi-config branch February 18, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant