Skip to content

Turn the docker Makefile target into an e2e full target#673

Merged
jviotti merged 1 commit intomainfrom
better-docker-target
Feb 25, 2026
Merged

Turn the docker Makefile target into an e2e full target#673
jviotti merged 1 commit intomainfrom
better-docker-target

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 25, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

@augmentcode
Copy link

augmentcode bot commented Feb 25, 2026

🤖 Augment PR Summary

Summary: Repurposes the docker Makefile target to run a full Docker-based E2E flow (build image, build+start sandbox, run E2E/UI tests, then teardown).
CI: Updates GitHub Actions to call make docker-build so CI keeps only building the image instead of running the full suite.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Makefile">

<violation number="1" location="Makefile:37">
P1: If `test-e2e` or `test-ui` fails, Make will abort before reaching `docker-sandbox-down`, leaving Docker sandbox containers running and ports occupied. The teardown step should be guaranteed to run regardless of test outcome (similar to a `trap` or `try/finally` pattern). Consider using a recipe that captures the test exit code and always runs teardown.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the better-docker-target branch from c39555d to d09c65f Compare February 25, 2026 15:45
@jviotti
Copy link
Member Author

jviotti commented Feb 25, 2026

augment review

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit d30796d into main Feb 25, 2026
5 checks passed
@jviotti jviotti deleted the better-docker-target branch February 25, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant