Add higher level profiling to the indexing phases with --time#695
Merged
Add higher level profiling to the indexing phases with --time#695
--time#695Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
force-pushed
the
better-index-logs
branch
from
0962b36 to
6a897d7
Compare
🤖 Augment PR SummarySummary: Adds coarse-grained phase profiling to the Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="benchmark/index.sh">
<violation number="1" location="benchmark/index.sh:34">
P2: Enabling `--profile` inside the timed benchmark path skews the reported latency by including profiling overhead instead of just indexing time.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
jviotti
changed the title
--time
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 1305de4 | Previous: af2e09c | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
43 ms |
44 ms |
0.98 |
Add one schema (100 existing) |
913 ms |
986 ms |
0.93 |
Add one schema (1000 existing) |
9506 ms |
9724 ms |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 1305de4 | Previous: af2e09c | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
44 ms |
49 ms |
0.90 |
Add one schema (100 existing) |
869 ms |
1109 ms |
0.78 |
Add one schema (1000 existing) |
8679 ms |
10474 ms |
0.83 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com