Skip to content

Speed up resolver::add during the detection phase#696

Merged
jviotti merged 1 commit intomainfrom
resolver-add-frame
Mar 3, 2026
Merged

Speed up resolver::add during the detection phase#696
jviotti merged 1 commit intomainfrom
resolver-add-frame

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 3, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@augmentcode
Copy link

augmentcode bot commented Mar 3, 2026

🤖 Augment PR Summary

Summary: Switches CustomResolver::add to frame schemas using SchemaFrame::Mode::Locations instead of References.
Rationale: Avoids the more expensive reference-analysis work during detection/registration while still registering embedded schema resources via frame.locations().

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 204bc66 Previous: af2e09c Ratio
Add one schema (0 existing) 52 ms 49 ms 1.06
Add one schema (100 existing) 1107 ms 1109 ms 1.00
Add one schema (1000 existing) 10662 ms 10474 ms 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 204bc66 Previous: e77e189 Ratio
Add one schema (0 existing) 40 ms 50 ms 0.80
Add one schema (100 existing) 976 ms 1134 ms 0.86
Add one schema (1000 existing) 9981 ms 10685 ms 0.93

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit e24c535 into main Mar 3, 2026
6 checks passed
@jviotti jviotti deleted the resolver-add-frame branch March 3, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant