Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Updates the vendored Changes:
Technical Notes: Blaze changes also add branch prediction hints and consolidate evaluator state handling; Core changes are primarily aimed at improving inlining/dispatch performance while keeping APIs functionally equivalent. 🤖 Was this summary useful? React with 👍 or 👎 |
| include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_io.cmake") | ||
| include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_uritemplate.cmake") | ||
| elseif(component STREQUAL "json") | ||
| include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_preprocessor.cmake") |
There was a problem hiding this comment.
numeric/json now pull in the new sourcemeta::core::preprocessor target, but several other component branches still include sourcemeta_core_numeric.cmake/sourcemeta_core_json.cmake without first including sourcemeta_core_preprocessor.cmake. This may break find_package(core COMPONENTS jsonl/jsonpointer/jsonschema/...) if the imported targets reference sourcemeta::core::preprocessor before it’s defined.
Severity: medium
Other Locations
vendor/core/config.cmake.in:71vendor/core/config.cmake.in:77vendor/core/config.cmake.in:85vendor/core/config.cmake.in:93vendor/core/config.cmake.in:101vendor/core/config.cmake.in:112
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 7438cf2 | Previous: 17bb92c | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
43 ms |
44 ms |
0.98 |
Add one schema (100 existing) |
884 ms |
921 ms |
0.96 |
Add one schema (1000 existing) |
9167 ms |
9290 ms |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 7438cf2 | Previous: e24c535 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
45 ms |
50 ms |
0.90 |
Add one schema (100 existing) |
983 ms |
1027 ms |
0.96 |
Add one schema (1000 existing) |
9460 ms |
10065 ms |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com