Skip to content

Upgrade Core and Blaze to the latest versions#699

Merged
jviotti merged 1 commit intomainfrom
blaze-fast-2
Mar 4, 2026
Merged

Upgrade Core and Blaze to the latest versions#699
jviotti merged 1 commit intomainfrom
blaze-fast-2

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 3, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 21 files

@augmentcode
Copy link

augmentcode bot commented Mar 3, 2026

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core and sourcemeta/blaze dependencies to newer revisions, bringing in evaluator and Core library improvements.

Changes:

  • Bumps core and blaze SHAs in DEPENDENCIES (and Blaze’s vendored Core reference).
  • Refactors Blaze’s evaluator dispatch to pass a shared DispatchContext (schema/callback/evaluator/property target) instead of threading many parameters.
  • Adds resolve_instance() to avoid unnecessary pointer resolution work when instance locations are empty.
  • Introduces a new Core “preprocessor” component providing SOURCEMETA_FORCEINLINE, and wires it into CMake packaging.
  • Moves multiple Core JSON and Decimal accessors from .cc files into headers as force-inlined implementations.
  • Updates Core JSON/Numeric targets to link against the new preprocessor component.

Technical Notes: Blaze changes also add branch prediction hints and consolidate evaluator state handling; Core changes are primarily aimed at improving inlining/dispatch performance while keeping APIs functionally equivalent.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_io.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_uritemplate.cmake")
elseif(component STREQUAL "json")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_preprocessor.cmake")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numeric/json now pull in the new sourcemeta::core::preprocessor target, but several other component branches still include sourcemeta_core_numeric.cmake/sourcemeta_core_json.cmake without first including sourcemeta_core_preprocessor.cmake. This may break find_package(core COMPONENTS jsonl/jsonpointer/jsonschema/...) if the imported targets reference sourcemeta::core::preprocessor before it’s defined.

Severity: medium

Other Locations
  • vendor/core/config.cmake.in:71
  • vendor/core/config.cmake.in:77
  • vendor/core/config.cmake.in:85
  • vendor/core/config.cmake.in:93
  • vendor/core/config.cmake.in:101
  • vendor/core/config.cmake.in:112

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 7438cf2 Previous: 17bb92c Ratio
Add one schema (0 existing) 43 ms 44 ms 0.98
Add one schema (100 existing) 884 ms 921 ms 0.96
Add one schema (1000 existing) 9167 ms 9290 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 7438cf2 Previous: e24c535 Ratio
Add one schema (0 existing) 45 ms 50 ms 0.90
Add one schema (100 existing) 983 ms 1027 ms 0.96
Add one schema (1000 existing) 9460 ms 10065 ms 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 2cbd5ce into main Mar 4, 2026
6 checks passed
@jviotti jviotti deleted the blaze-fast-2 branch March 4, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant