Skip to content

Improve index benchmark details #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
Mar 18, 2026
Merged

Improve index benchmark details #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions benchmark/index.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,9 @@ do
generate_schema "schema-$index"
index=$((index + 1))
done
echo "Reindexing outside measurements..." >&2
"$INDEX" --skip-banner "$TMP/one.json" "$TMP/output" > /dev/null 2>&1
echo "Measuring: index 100 schemas..." >&2
RESULT_INDEX_100="$(measure)"
echo " Result: ${RESULT_INDEX_100}ms" >&2

# Measure adding one schema (with a $ref) to a 100-schema registry
echo "Measuring: add one schema (100 existing)..." >&2
Expand All @@ -131,8 +132,9 @@ do
generate_schema "schema-$index"
index=$((index + 1))
done
echo "Reindexing outside measurements..." >&2
"$INDEX" --skip-banner "$TMP/one.json" "$TMP/output" > /dev/null 2>&1
echo "Measuring: index 1000 schemas..." >&2
RESULT_INDEX_1000="$(measure)"
echo " Result: ${RESULT_INDEX_1000}ms" >&2

# Measure adding one schema (with a $ref) to a 1000-schema registry
echo "Measuring: add one schema (1000 existing)..." >&2
Expand All @@ -159,8 +161,9 @@ do
generate_schema "schema-$index"
index=$((index + 1))
done
echo "Reindexing outside measurements..." >&2
"$INDEX" --skip-banner "$TMP/one.json" "$TMP/output" > /dev/null 2>&1
echo "Measuring: index 10000 schemas..." >&2
RESULT_INDEX_10000="$(measure)"
echo " Result: ${RESULT_INDEX_10000}ms" >&2

# Measure adding one schema (with a $ref) to a 10000-schema registry
echo "Measuring: add one schema (10000 existing)..." >&2
Expand Down Expand Up @@ -240,6 +243,21 @@ cat << EOF
"name": "Cached rebuild (10001 existing)",
"unit": "ms",
"value": $RESULT_CACHED_10001
},
{
"name": "Index 100 schemas",
"unit": "ms",
"value": $RESULT_INDEX_100
},
{
"name": "Index 1000 schemas",
"unit": "ms",
"value": $RESULT_INDEX_1000
},
{
"name": "Index 10000 schemas",
"unit": "ms",
"value": $RESULT_INDEX_10000
}
]
EOF
6 changes: 4 additions & 2 deletions src/index/index.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,17 +392,19 @@ static auto index_main(const std::string_view &program,
sourcemeta::one::BuildPhase::Produce, build_type, entries,
canonical_output, resolver.data(), this_version, incremental, comment,
changed, removed)};
PROFILE_END(profiling, "Producing (Delta)");
execute_plan(mutex, entries, canonical_output, resolver, configuration,
raw_configuration, concurrency, produce_plan, "Producing");
PROFILE_END(profiling, "Producing");
PROFILE_END(profiling, "Producing (Build)");

auto combine_plan{sourcemeta::one::delta(
sourcemeta::one::BuildPhase::Combine, build_type, entries,
canonical_output, resolver.data(), this_version, incremental, comment,
changed, removed)};
PROFILE_END(profiling, "Combining (Delta)");
execute_plan(mutex, entries, canonical_output, resolver, configuration,
raw_configuration, concurrency, combine_plan, "Combining");
PROFILE_END(profiling, "Combining");
PROFILE_END(profiling, "Combining (Build)");

/////////////////////////////////////////////////////////////////////////////
// (8) Save state and profile
Expand Down
Loading