Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: Upgrades the vendored uWebSockets/uSockets dependency from v20.75.0 to v20.76.0.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| std::swap(this->topicTree, other.topicTree); | ||
| std::swap(this->webSocketContextDeleters, other.webSocketContextDeleters); | ||
| std::swap(this->webSocketContexts, other.webSocketContexts); | ||
| } |
There was a problem hiding this comment.
TemplatedApp::operator=(TemplatedApp&&) returns TemplatedApp& but currently has no return statement, which is undefined behavior (and may fail builds under warnings-as-errors). Consider ensuring it returns a valid reference to the assigned object.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| /* Returns the remote port number or -1 on failure */ | ||
| unsigned int getRemotePort() { | ||
| int port = us_socket_remote_port(SSL, (us_socket_t *) this); | ||
| return (unsigned int) port; |
There was a problem hiding this comment.
getRemotePort() documents “-1 on failure” but returns unsigned int and casts the int result, so a failure would become a large positive value. Consider aligning the return type/contract so callers can reliably detect failure.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| if ((family & 0xf0) >> 4 == 1) { | ||
| /* Family 1 is INET4 */ | ||
| return addr.ipv4_addr.src_port; |
There was a problem hiding this comment.
ProxyParser::getSourcePort() returns the raw src_port value, but PROXY v2 ports are stored in network byte order, so callers may observe byte-swapped ports on little-endian hosts. This also impacts HttpResponse::getProxiedRemotePort().
Severity: medium
Other Locations
vendor/uwebsockets/src/ProxyParser.h:106vendor/uwebsockets/src/HttpResponse.h:236
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 1811c6a | Previous: 0a8a48c | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
23 ms |
24 ms |
0.96 |
Add one schema (100 existing) |
24 ms |
30 ms |
0.80 |
Add one schema (1000 existing) |
76 ms |
75 ms |
1.01 |
Add one schema (10000 existing) |
694 ms |
624 ms |
1.11 |
Update one schema (1 existing) |
18 ms |
20 ms |
0.90 |
Update one schema (101 existing) |
24 ms |
25 ms |
0.96 |
Update one schema (1001 existing) |
78 ms |
78 ms |
1 |
Update one schema (10001 existing) |
636 ms |
645 ms |
0.99 |
Cached rebuild (1 existing) |
11 ms |
12 ms |
0.92 |
Cached rebuild (101 existing) |
12 ms |
12 ms |
1 |
Cached rebuild (1001 existing) |
28 ms |
27 ms |
1.04 |
Cached rebuild (10001 existing) |
199 ms |
202 ms |
0.99 |
Index 100 schemas |
116 ms |
131 ms |
0.89 |
Index 1000 schemas |
992 ms |
972 ms |
1.02 |
Index 10000 schemas |
14904 ms |
14132 ms |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 1811c6a | Previous: 0a8a48c | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
24 ms |
21 ms |
1.14 |
Add one schema (100 existing) |
28 ms |
21 ms |
1.33 |
Add one schema (1000 existing) |
74 ms |
57 ms |
1.30 |
Add one schema (10000 existing) |
699 ms |
462 ms |
1.51 |
Update one schema (1 existing) |
23 ms |
18 ms |
1.28 |
Update one schema (101 existing) |
28 ms |
21 ms |
1.33 |
Update one schema (1001 existing) |
78 ms |
61 ms |
1.28 |
Update one schema (10001 existing) |
703 ms |
472 ms |
1.49 |
Cached rebuild (1 existing) |
12 ms |
10 ms |
1.20 |
Cached rebuild (101 existing) |
14 ms |
10 ms |
1.40 |
Cached rebuild (1001 existing) |
29 ms |
21 ms |
1.38 |
Cached rebuild (10001 existing) |
238 ms |
131 ms |
1.82 |
Index 100 schemas |
126 ms |
86 ms |
1.47 |
Index 1000 schemas |
1349 ms |
798 ms |
1.69 |
Index 10000 schemas |
17775 ms |
11305 ms |
1.57 |
This comment was automatically generated by workflow using github-action-benchmark.
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com